* [PATCH v4 0/3] cec: One Touch Record tests
@ 2021-06-24 4:06 Deborah Brouwer
2021-06-24 4:06 ` [PATCH v4 1/3] cec-follower: use log_addr_type to get local device type Deborah Brouwer
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Deborah Brouwer @ 2021-06-24 4:06 UTC (permalink / raw)
To: linux-media; +Cc: hverkuil, jaffe1, Deborah Brouwer
This is part of an Outreachy project to expand the testing of
One Touch Record messages as handled by CEC adapters.
Changes since v3:
Patch 1/3: cec-follower: use log_addr_type to get local device type
- new patch
Patch 2/3: cec: expand One Touch Record tests
- this patch combines the previously separate patches for
One Touch Record TV Screen and On/Off tests
- accurately check if the initiator is a recording device
- add digital service and analog service validation
- add invalid operand tests
- create a new helper function to send invalid record on operands
without the 10s reply timeout
- always require feature abort in response to an invalid operand
Patch 3/3 cec: add One Touch Record Standby tests
- no change
Changes since v2:
Patch 1/3 cec: expand One Touch Record TV Screen test:
- replace numbers with corresponding defines
Patch 2/3 cec: expand One Touch Record On/Off tests
- rename commit to reflect expanded scope of tests
- increase msg timeout for reply to 10s
- rename helper function and invert return value
- use primary device type to identify remote follower
- use logical address type to identify remote initiator
- limit range of accepted external plug numbers to 6
- disallow external physical address source
- keep track of whether the device is recording
- add additional invalid tests
Patch 3/3 cec: add One Touch Record Standby tests
- new patch
Changes since v1:
Patch 1/2 cec: expand One Touch Record TV Screen test:
- add space after 'switch'
- add "return" before fail
- check analog broadcast type and broadcast system operand
- add a comment when follower ignores message
Patch 2/2 cec: expand One Touch Record On test
- new patch
Deborah Brouwer (3):
cec-follower: use log_addr_type to get local device type
cec: expand One Touch Record tests
cec: add One Touch Record Standby tests
utils/cec-compliance/cec-compliance.cpp | 1 +
utils/cec-compliance/cec-compliance.h | 1 +
utils/cec-compliance/cec-test-power.cpp | 63 ++++
utils/cec-compliance/cec-test.cpp | 366 ++++++++++++++++++++++--
utils/cec-follower/cec-follower.cpp | 1 +
utils/cec-follower/cec-follower.h | 7 +-
utils/cec-follower/cec-processing.cpp | 19 +-
utils/cec-follower/cec-tuner.cpp | 233 +++++++++++++--
8 files changed, 635 insertions(+), 56 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v4 1/3] cec-follower: use log_addr_type to get local device type 2021-06-24 4:06 [PATCH v4 0/3] cec: One Touch Record tests Deborah Brouwer @ 2021-06-24 4:06 ` Deborah Brouwer 2021-06-24 4:06 ` [PATCH v4 2/3] cec: expand One Touch Record tests Deborah Brouwer 2021-06-24 4:06 ` [PATCH v4 3/3] cec: add One Touch Record Standby tests Deborah Brouwer 2 siblings, 0 replies; 5+ messages in thread From: Deborah Brouwer @ 2021-06-24 4:06 UTC (permalink / raw) To: linux-media; +Cc: hverkuil, jaffe1, Deborah Brouwer A device may use a Backup logical address (aka Reserved in CEC Version < 2.0) if the logical addresses that the device would normally used are unavailable. Since a Backup logical address is not unique to any device type, it cannot be used to determine the device type of the follower. Instead use the more accurate log_addr_type as returned by CEC_ADAP_G_LOG_ADDRS to find the device type. Signed-off-by: Deborah Brouwer <deborahbrouwer3563@gmail.com> --- utils/cec-follower/cec-follower.h | 2 +- utils/cec-follower/cec-processing.cpp | 7 ++++--- utils/cec-follower/cec-tuner.cpp | 2 +- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/utils/cec-follower/cec-follower.h b/utils/cec-follower/cec-follower.h index 3fa95417..343ae998 100644 --- a/utils/cec-follower/cec-follower.h +++ b/utils/cec-follower/cec-follower.h @@ -222,7 +222,7 @@ void sad_encode(const struct short_audio_desc *sad, __u32 *descriptor); // cec-tuner.cpp void tuner_dev_info_init(struct state *state); -void process_tuner_record_timer_msgs(struct node *node, struct cec_msg &msg, unsigned me); +void process_tuner_record_timer_msgs(struct node *node, struct cec_msg &msg, unsigned me, __u8 type); // CEC processing void reply_feature_abort(struct node *node, struct cec_msg *msg, diff --git a/utils/cec-follower/cec-processing.cpp b/utils/cec-follower/cec-processing.cpp index 41bb990c..b1c8f3d9 100644 --- a/utils/cec-follower/cec-processing.cpp +++ b/utils/cec-follower/cec-processing.cpp @@ -271,7 +271,7 @@ static void update_deck_state(struct node *node, unsigned me, __u8 deck_state_ne } } -static void processMsg(struct node *node, struct cec_msg &msg, unsigned me) +static void processMsg(struct node *node, struct cec_msg &msg, unsigned me, __u8 type) { __u8 to = cec_msg_destination(&msg); __u8 from = cec_msg_initiator(&msg); @@ -672,7 +672,7 @@ static void processMsg(struct node *node, struct cec_msg &msg, unsigned me) case CEC_MSG_SET_TIMER_PROGRAM_TITLE: case CEC_MSG_TIMER_CLEARED_STATUS: case CEC_MSG_TIMER_STATUS: - process_tuner_record_timer_msgs(node, msg, me); + process_tuner_record_timer_msgs(node, msg, me, type); return; /* Dynamic Auto Lipsync */ @@ -1009,6 +1009,7 @@ void testProcessing(struct node *node, bool wallclock) doioctl(node, CEC_S_MODE, &mode); doioctl(node, CEC_ADAP_G_LOG_ADDRS, &laddrs); me = laddrs.log_addr[0]; + __u8 type = laddrs.log_addr_type[0]; poll_remote_devs(node, me); @@ -1088,7 +1089,7 @@ void testProcessing(struct node *node, bool wallclock) msg.sequence, ts2s(msg.rx_ts, wallclock).c_str()); } if (node->adap_la_mask) - processMsg(node, msg, me); + processMsg(node, msg, me, type); } __u8 pwr_state = current_power_state(node); diff --git a/utils/cec-follower/cec-tuner.cpp b/utils/cec-follower/cec-tuner.cpp index b9c21684..d1718986 100644 --- a/utils/cec-follower/cec-tuner.cpp +++ b/utils/cec-follower/cec-tuner.cpp @@ -482,7 +482,7 @@ static bool analog_set_tuner_dev_info(struct node *node, struct cec_msg *msg) return false; } -void process_tuner_record_timer_msgs(struct node *node, struct cec_msg &msg, unsigned me) +void process_tuner_record_timer_msgs(struct node *node, struct cec_msg &msg, unsigned me, __u8 type) { bool is_bcast = cec_msg_is_broadcast(&msg); -- 2.25.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v4 2/3] cec: expand One Touch Record tests 2021-06-24 4:06 [PATCH v4 0/3] cec: One Touch Record tests Deborah Brouwer 2021-06-24 4:06 ` [PATCH v4 1/3] cec-follower: use log_addr_type to get local device type Deborah Brouwer @ 2021-06-24 4:06 ` Deborah Brouwer 2021-06-24 7:57 ` Hans Verkuil 2021-06-24 4:06 ` [PATCH v4 3/3] cec: add One Touch Record Standby tests Deborah Brouwer 2 siblings, 1 reply; 5+ messages in thread From: Deborah Brouwer @ 2021-06-24 4:06 UTC (permalink / raw) To: linux-media; +Cc: hverkuil, jaffe1, Deborah Brouwer Expand the One Touch Record tests so that the follower and initiator know their local and remote device types and respond accordingly. Send Record TV Screen and check that Record On source replies are valid. Send Record On source messages and check that Record Status replies are valid. Send Record Off and check that the recording terminates. Signed-off-by: Deborah Brouwer <deborahbrouwer3563@gmail.com> --- utils/cec-compliance/cec-compliance.cpp | 1 + utils/cec-compliance/cec-compliance.h | 1 + utils/cec-compliance/cec-test.cpp | 366 ++++++++++++++++++++++-- utils/cec-follower/cec-follower.cpp | 1 + utils/cec-follower/cec-follower.h | 3 +- utils/cec-follower/cec-processing.cpp | 4 +- utils/cec-follower/cec-tuner.cpp | 222 ++++++++++++-- 7 files changed, 549 insertions(+), 49 deletions(-) diff --git a/utils/cec-compliance/cec-compliance.cpp b/utils/cec-compliance/cec-compliance.cpp index c04904c2..d4b12298 100644 --- a/utils/cec-compliance/cec-compliance.cpp +++ b/utils/cec-compliance/cec-compliance.cpp @@ -1236,6 +1236,7 @@ int main(int argc, char **argv) node.num_log_addrs = laddrs.num_log_addrs; memcpy(node.log_addr, laddrs.log_addr, laddrs.num_log_addrs); node.adap_la_mask = laddrs.log_addr_mask; + node.prim_devtype = laddrs.primary_device_type[0]; printf("Find remote devices:\n"); printf("\tPolling: %s\n", ok(poll_remote_devs(&node))); diff --git a/utils/cec-compliance/cec-compliance.h b/utils/cec-compliance/cec-compliance.h index 818181ab..41e2d63d 100644 --- a/utils/cec-compliance/cec-compliance.h +++ b/utils/cec-compliance/cec-compliance.h @@ -166,6 +166,7 @@ struct node { struct remote remote[16]; __u16 phys_addr; bool in_standby; + __u8 prim_devtype; }; struct remote_subtest { diff --git a/utils/cec-compliance/cec-test.cpp b/utils/cec-compliance/cec-test.cpp index 40d8369d..864ab83c 100644 --- a/utils/cec-compliance/cec-test.cpp +++ b/utils/cec-compliance/cec-test.cpp @@ -48,6 +48,69 @@ static int test_play_mode(struct node *node, unsigned me, unsigned la, __u8 play return OK; } +static int one_touch_rec_on_send(struct node *node, unsigned me, unsigned la, + const struct cec_op_record_src &rec_src, __u8 &rec_status) +{ + struct cec_msg msg; + + cec_msg_init(&msg, me, la); + cec_msg_record_off(&msg, false); + fail_on_test(!transmit_timeout(node, &msg)); + + cec_msg_init(&msg, me, la); + cec_msg_record_on(&msg, true, &rec_src); + fail_on_test(!transmit_timeout(node, &msg, 10000)); + fail_on_test(timed_out_or_abort(&msg)); + cec_ops_record_status(&msg, &rec_status); + + return OK; +} + +static int one_touch_rec_on_send_invalid(struct node *node, unsigned me, unsigned la, + const struct cec_op_record_src &rec_src) +{ + struct cec_msg msg; + + cec_msg_init(&msg, me, la); + cec_msg_record_on(&msg, true, &rec_src); + fail_on_test(!transmit_timeout(node, &msg)); + fail_on_test(!cec_msg_status_is_abort(&msg)); + fail_on_test(abort_reason(&msg) != CEC_OP_ABORT_INVALID_OP); + + return OK; +} + +/* + * Returns true if the Record Status is an error and the request + * to start recording has failed. + */ +static bool rec_status_is_a_valid_error_status(__u8 rec_status) +{ + switch (rec_status) { + case CEC_OP_RECORD_STATUS_NO_DIG_SERVICE: + case CEC_OP_RECORD_STATUS_NO_ANA_SERVICE: + case CEC_OP_RECORD_STATUS_NO_SERVICE: + case CEC_OP_RECORD_STATUS_INVALID_EXT_PLUG: + case CEC_OP_RECORD_STATUS_INVALID_EXT_PHYS_ADDR: + case CEC_OP_RECORD_STATUS_UNSUP_CA: + case CEC_OP_RECORD_STATUS_NO_CA_ENTITLEMENTS: + case CEC_OP_RECORD_STATUS_CANT_COPY_SRC: + case CEC_OP_RECORD_STATUS_NO_MORE_COPIES: + case CEC_OP_RECORD_STATUS_NO_MEDIA: + case CEC_OP_RECORD_STATUS_PLAYING: + case CEC_OP_RECORD_STATUS_ALREADY_RECORDING: + case CEC_OP_RECORD_STATUS_MEDIA_PROT: + case CEC_OP_RECORD_STATUS_NO_SIGNAL: + case CEC_OP_RECORD_STATUS_MEDIA_PROBLEM: + case CEC_OP_RECORD_STATUS_NO_SPACE: + case CEC_OP_RECORD_STATUS_PARENTAL_LOCK: + case CEC_OP_RECORD_STATUS_OTHER: + return true; + default: + return false; + } +} + /* System Information */ int system_info_polling(struct node *node, unsigned me, unsigned la, bool interactive) @@ -1141,24 +1204,14 @@ static const vec_remote_subtests tuner_ctl_subtests{ /* One Touch Record */ -/* - TODO: These are very rudimentary tests which should be expanded. - - - The HDMI CEC 1.4b spec details that Standby shall not be acted upon while the - device is recording, but it should remember that it received Standby. - */ - static int one_touch_rec_tv_screen(struct node *node, unsigned me, unsigned la, bool interactive) { - /* - TODO: - - Page 36 in HDMI CEC 1.4b spec lists additional behaviors that should be - checked for. - - The TV should ignore this message when received from other LA than Recording or - Reserved. - */ struct cec_msg msg; + cec_msg_init(&msg, me, la); + cec_msg_report_physical_addr(&msg, node->phys_addr, node->prim_devtype); + fail_on_test(!transmit_timeout(node, &msg)); + cec_msg_init(&msg, me, la); cec_msg_record_tv_screen(&msg, true); fail_on_test(!transmit_timeout(node, &msg)); @@ -1172,45 +1225,283 @@ static int one_touch_rec_tv_screen(struct node *node, unsigned me, unsigned la, return OK_REFUSED; if (cec_msg_status_is_abort(&msg)) return OK_PRESUMED; + /* Follower should ignore this message if it is not sent by a recording device */ + if (node->prim_devtype != CEC_OP_PRIM_DEVTYPE_RECORD) { + fail_on_test(!timed_out(&msg)); + return OK; + } + fail_on_test(timed_out(&msg)); - return 0; + struct cec_op_record_src rec_src = {}; + + cec_ops_record_on(&msg, &rec_src); + + if (rec_src.type < CEC_OP_RECORD_SRC_OWN || rec_src.type > CEC_OP_RECORD_SRC_EXT_PHYS_ADDR) + return fail("Invalid source.\n"); + + if (rec_src.type == CEC_OP_RECORD_SRC_DIGITAL && + rec_src.digital.service_id_method == CEC_OP_SERVICE_ID_METHOD_BY_DIG_ID) { + switch (rec_src.digital.dig_bcast_system) { + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ARIB_GEN: + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ATSC_GEN: + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_DVB_GEN: + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ARIB_BS: + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ARIB_CS: + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ARIB_T: + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ATSC_CABLE: + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ATSC_SAT: + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ATSC_T: + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_DVB_C: + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_DVB_S: + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_DVB_S2: + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_DVB_T: + break; + default: + return fail("Invalid digital service broadcast system operand.\n"); + } + } + + if (rec_src.type == CEC_OP_RECORD_SRC_ANALOG) { + fail_on_test(rec_src.analog.ana_bcast_type > CEC_OP_ANA_BCAST_TYPE_TERRESTRIAL); + fail_on_test(rec_src.analog.bcast_system > CEC_OP_BCAST_SYSTEM_PAL_DK && + rec_src.analog.bcast_system != CEC_OP_BCAST_SYSTEM_OTHER); + fail_on_test(rec_src.analog.ana_freq == 0 || rec_src.analog.ana_freq == 0xffff); + } + + if (rec_src.type == CEC_OP_RECORD_SRC_EXT_PLUG) + fail_on_test(rec_src.ext_plug.plug == 0); + + return OK; } static int one_touch_rec_on(struct node *node, unsigned me, unsigned la, bool interactive) { - /* - TODO: Page 36 in HDMI CEC 1.4b spec lists additional behaviors that should be - checked for. - */ struct cec_msg msg; struct cec_op_record_src rec_src = {}; rec_src.type = CEC_OP_RECORD_SRC_OWN; cec_msg_init(&msg, me, la); cec_msg_record_on(&msg, true, &rec_src); - fail_on_test(!transmit_timeout(node, &msg)); + /* Allow 10s for reply because the spec says it may take several seconds to accurately respond. */ + fail_on_test(!transmit_timeout(node, &msg, 10000)); fail_on_test(timed_out(&msg)); - fail_on_test(cec_has_record(1 << la) && unrecognized_op(&msg)); - if (unrecognized_op(&msg)) + if (unrecognized_op(&msg)) { + fail_on_test(node->remote[la].prim_type == CEC_OP_PRIM_DEVTYPE_RECORD); return OK_NOT_SUPPORTED; + } if (refused(&msg)) return OK_REFUSED; if (cec_msg_status_is_abort(&msg)) return OK_PRESUMED; - return 0; + __u8 rec_status; + + cec_ops_record_status(&msg, &rec_status); + if (rec_status != CEC_OP_RECORD_STATUS_CUR_SRC) + fail_on_test(!rec_status_is_a_valid_error_status(rec_status)); + + memset(&rec_src, 0, sizeof(rec_src)); + rec_src.type = CEC_OP_RECORD_SRC_DIGITAL; + rec_src.digital.service_id_method = CEC_OP_SERVICE_ID_METHOD_BY_DIG_ID; + rec_src.digital.dig_bcast_system = CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ARIB_BS; + rec_src.digital.arib.transport_id = 1046; + rec_src.digital.arib.service_id = 30505; + rec_src.digital.arib.orig_network_id = 1; + fail_on_test(one_touch_rec_on_send(node, me, la, rec_src, rec_status)); + if (rec_status != CEC_OP_RECORD_STATUS_DIG_SERVICE) + fail_on_test(!rec_status_is_a_valid_error_status(rec_status)); + + memset(&rec_src, 0, sizeof(rec_src)); + rec_src.type = CEC_OP_RECORD_SRC_DIGITAL; + rec_src.digital.service_id_method = CEC_OP_SERVICE_ID_METHOD_BY_DIG_ID; + rec_src.digital.dig_bcast_system = CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ATSC_T; + rec_src.digital.atsc.transport_id = 1675; + rec_src.digital.atsc.program_number = 3; + fail_on_test(one_touch_rec_on_send(node, me, la, rec_src, rec_status)); + if (rec_status != CEC_OP_RECORD_STATUS_DIG_SERVICE) + fail_on_test(!rec_status_is_a_valid_error_status(rec_status)); + + memset(&rec_src, 0, sizeof(rec_src)); + rec_src.type = CEC_OP_RECORD_SRC_DIGITAL; + rec_src.digital.service_id_method = CEC_OP_SERVICE_ID_METHOD_BY_DIG_ID; + rec_src.digital.dig_bcast_system = CEC_OP_DIG_SERVICE_BCAST_SYSTEM_DVB_S2; + rec_src.digital.dvb.transport_id = 61; + rec_src.digital.dvb.service_id = 7193; + rec_src.digital.dvb.orig_network_id = 70; + fail_on_test(one_touch_rec_on_send(node, me, la, rec_src, rec_status)); + if (rec_status != CEC_OP_RECORD_STATUS_DIG_SERVICE) + fail_on_test(!rec_status_is_a_valid_error_status(rec_status)); + + memset(&rec_src, 0, sizeof(rec_src)); + rec_src.type = CEC_OP_RECORD_SRC_DIGITAL; + rec_src.digital.service_id_method = CEC_OP_SERVICE_ID_METHOD_BY_CHANNEL; + rec_src.digital.dig_bcast_system = CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ARIB_T; + rec_src.digital.channel.channel_number_fmt = 1; + rec_src.digital.channel.major = 0; + rec_src.digital.channel.minor = 51992; + fail_on_test(one_touch_rec_on_send(node, me, la, rec_src, rec_status)); + if (rec_status != CEC_OP_RECORD_STATUS_DIG_SERVICE) + fail_on_test(!rec_status_is_a_valid_error_status(rec_status)); + + memset(&rec_src, 0, sizeof(rec_src)); + rec_src.type = CEC_OP_RECORD_SRC_DIGITAL; + rec_src.digital.service_id_method = CEC_OP_SERVICE_ID_METHOD_BY_CHANNEL; + rec_src.digital.dig_bcast_system = CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ATSC_SAT; + rec_src.digital.channel.channel_number_fmt = 2; + rec_src.digital.channel.major = 3; + rec_src.digital.channel.minor = 55295; + fail_on_test(one_touch_rec_on_send(node, me, la, rec_src, rec_status)); + if (rec_status != CEC_OP_RECORD_STATUS_DIG_SERVICE) + fail_on_test(!rec_status_is_a_valid_error_status(rec_status)); + + memset(&rec_src, 0, sizeof(rec_src)); + rec_src.type = CEC_OP_RECORD_SRC_DIGITAL; + rec_src.digital.service_id_method = CEC_OP_SERVICE_ID_METHOD_BY_CHANNEL; + rec_src.digital.dig_bcast_system = CEC_OP_DIG_SERVICE_BCAST_SYSTEM_DVB_T; + rec_src.digital.channel.channel_number_fmt = 1; + rec_src.digital.channel.major = 0; + rec_src.digital.channel.minor = 21; + fail_on_test(one_touch_rec_on_send(node, me, la, rec_src, rec_status)); + if (rec_status != CEC_OP_RECORD_STATUS_DIG_SERVICE) + fail_on_test(!rec_status_is_a_valid_error_status(rec_status)); + + memset(&rec_src, 0, sizeof(rec_src)); + rec_src.type = CEC_OP_RECORD_STATUS_ANA_SERVICE; + rec_src.analog.ana_bcast_type = CEC_OP_ANA_BCAST_TYPE_CABLE; + rec_src.analog.ana_freq = (471250 * 10) / 625; + rec_src.analog.bcast_system = CEC_OP_BCAST_SYSTEM_PAL_BG; + fail_on_test(one_touch_rec_on_send(node, me, la, rec_src, rec_status)); + if (rec_status != CEC_OP_RECORD_STATUS_ANA_SERVICE) + fail_on_test(!rec_status_is_a_valid_error_status(rec_status)); + + memset(&rec_src, 0, sizeof(rec_src)); + rec_src.type = CEC_OP_RECORD_STATUS_ANA_SERVICE; + rec_src.analog.ana_bcast_type = CEC_OP_ANA_BCAST_TYPE_SATELLITE; + rec_src.analog.ana_freq = (551250 * 10) / 625; + rec_src.analog.bcast_system = CEC_OP_BCAST_SYSTEM_SECAM_BG; + fail_on_test(one_touch_rec_on_send(node, me, la, rec_src, rec_status)); + if (rec_status != CEC_OP_RECORD_STATUS_ANA_SERVICE) + fail_on_test(!rec_status_is_a_valid_error_status(rec_status)); + + memset(&rec_src, 0, sizeof(rec_src)); + rec_src.type = CEC_OP_RECORD_STATUS_ANA_SERVICE; + rec_src.analog.ana_bcast_type = CEC_OP_ANA_BCAST_TYPE_TERRESTRIAL; + rec_src.analog.ana_freq = (185250 * 10) / 625; + rec_src.analog.bcast_system = CEC_OP_BCAST_SYSTEM_PAL_DK; + fail_on_test(one_touch_rec_on_send(node, me, la, rec_src, rec_status)); + if (rec_status != CEC_OP_RECORD_STATUS_ANA_SERVICE) + fail_on_test(!rec_status_is_a_valid_error_status(rec_status)); + + memset(&rec_src, 0, sizeof(rec_src)); + rec_src.type = CEC_OP_RECORD_SRC_EXT_PLUG; + rec_src.ext_plug.plug = 1; + fail_on_test(one_touch_rec_on_send(node, me, la, rec_src, rec_status)); + if (rec_status != CEC_OP_RECORD_STATUS_EXT_INPUT) + fail_on_test(!rec_status_is_a_valid_error_status(rec_status)); + + memset(&rec_src, 0, sizeof(rec_src)); + rec_src.type = CEC_OP_RECORD_SRC_EXT_PHYS_ADDR; + fail_on_test(one_touch_rec_on_send(node, me, la, rec_src, rec_status)); + if (rec_status != CEC_OP_RECORD_STATUS_EXT_INPUT) + fail_on_test(!rec_status_is_a_valid_error_status(rec_status)); + + return OK; } -static int one_touch_rec_off(struct node *node, unsigned me, unsigned la, bool interactive) +static int one_touch_rec_on_invalid(struct node *node, unsigned me, unsigned la, bool interactive) { struct cec_msg msg; cec_msg_init(&msg, me, la); - cec_msg_record_off(&msg, false); + cec_msg_record_on_own(&msg); + msg.msg[2] = 0; /* Invalid source operand */ fail_on_test(!transmit_timeout(node, &msg)); - fail_on_test(cec_has_record(1 << la) && unrecognized_op(&msg)); if (unrecognized_op(&msg)) return OK_NOT_SUPPORTED; + fail_on_test(!cec_msg_status_is_abort(&msg)); + fail_on_test(abort_reason(&msg) != CEC_OP_ABORT_INVALID_OP); + + cec_msg_init(&msg, me, la); + cec_msg_record_on_own(&msg); + msg.msg[2] = 6; /* Invalid source operand */ + fail_on_test(!transmit_timeout(node, &msg)); + fail_on_test(!cec_msg_status_is_abort(&msg)); + fail_on_test(abort_reason(&msg) != CEC_OP_ABORT_INVALID_OP); + + struct cec_op_record_src rec_src = {}; + + rec_src.type = CEC_OP_RECORD_SRC_DIGITAL; + rec_src.digital.service_id_method = CEC_OP_SERVICE_ID_METHOD_BY_CHANNEL; + rec_src.digital.dig_bcast_system = 0x7f; /* Invalid digital service broadcast system */ + rec_src.digital.channel.channel_number_fmt = 1; + rec_src.digital.channel.major = 0; + rec_src.digital.channel.minor = 30203; + fail_on_test(one_touch_rec_on_send_invalid(node, me, la, rec_src)); + + memset(&rec_src, 0, sizeof(rec_src)); + rec_src.type = CEC_OP_RECORD_SRC_DIGITAL; + rec_src.digital.service_id_method = CEC_OP_SERVICE_ID_METHOD_BY_DIG_ID; + rec_src.digital.dig_bcast_system = CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ATSC_SAT; + rec_src.digital.atsc.transport_id = 0; /* Invalid transport id */ + rec_src.digital.atsc.program_number = 50316; + fail_on_test(one_touch_rec_on_send_invalid(node, me, la, rec_src)); + + memset(&rec_src, 0, sizeof(rec_src)); + rec_src.type = CEC_OP_RECORD_SRC_DIGITAL; + rec_src.digital.service_id_method = CEC_OP_SERVICE_ID_METHOD_BY_DIG_ID; + rec_src.digital.dig_bcast_system = CEC_OP_DIG_SERVICE_BCAST_SYSTEM_DVB_T; + rec_src.digital.dvb.transport_id = 1004; + rec_src.digital.dvb.service_id = 0; /* Invalid service id */ + rec_src.digital.dvb.orig_network_id = 8945; + fail_on_test(one_touch_rec_on_send_invalid(node, me, la, rec_src)); + + memset(&rec_src, 0, sizeof(rec_src)); + rec_src.type = CEC_OP_RECORD_SRC_ANALOG; + rec_src.analog.ana_bcast_type = 0xff; /* Invalid analog broadcast type */ + rec_src.analog.ana_freq = (519250 * 10) / 625; + rec_src.analog.bcast_system = CEC_OP_BCAST_SYSTEM_PAL_BG; + fail_on_test(one_touch_rec_on_send_invalid(node, me, la, rec_src)); + + memset(&rec_src, 0, sizeof(rec_src)); + rec_src.type = CEC_OP_RECORD_SRC_ANALOG; + rec_src.analog.ana_bcast_type = CEC_OP_ANA_BCAST_TYPE_TERRESTRIAL; + rec_src.analog.ana_freq = 0; /* Invalid analog frequency */ + rec_src.analog.bcast_system = CEC_OP_BCAST_SYSTEM_NTSC_M; + fail_on_test(one_touch_rec_on_send_invalid(node, me, la, rec_src)); + + memset(&rec_src, 0, sizeof(rec_src)); + rec_src.type = CEC_OP_RECORD_SRC_ANALOG; + rec_src.analog.ana_bcast_type = CEC_OP_ANA_BCAST_TYPE_CABLE; + rec_src.analog.ana_freq = 0xffff; /* Invalid analog frequency */ + rec_src.analog.bcast_system = CEC_OP_BCAST_SYSTEM_SECAM_L; + fail_on_test(one_touch_rec_on_send_invalid(node, me, la, rec_src)); + + memset(&rec_src, 0, sizeof(rec_src)); + rec_src.type = CEC_OP_RECORD_SRC_ANALOG; + rec_src.analog.ana_bcast_type = CEC_OP_ANA_BCAST_TYPE_SATELLITE; + rec_src.analog.ana_freq = (703250 * 10) / 625; + rec_src.analog.bcast_system = 0xff; /* Invalid analog broadcast system */ + fail_on_test(one_touch_rec_on_send_invalid(node, me, la, rec_src)); + + memset(&rec_src, 0, sizeof(rec_src)); + rec_src.type = CEC_OP_RECORD_SRC_EXT_PLUG; + rec_src.ext_plug.plug = 0; /* Invalid plug */ + fail_on_test(one_touch_rec_on_send_invalid(node, me, la, rec_src)); + + return OK; +} + +static int one_touch_rec_off(struct node *node, unsigned me, unsigned la, bool interactive) +{ + struct cec_msg msg; + + cec_msg_init(&msg, me, la); + cec_msg_record_off(&msg, true); + fail_on_test(!transmit_timeout(node, &msg)); + if (unrecognized_op(&msg)) { + fail_on_test(node->remote[la].prim_type == CEC_OP_PRIM_DEVTYPE_RECORD); + return OK_NOT_SUPPORTED; + } if (refused(&msg)) return OK_REFUSED; if (cec_msg_status_is_abort(&msg)) @@ -1218,13 +1509,30 @@ static int one_touch_rec_off(struct node *node, unsigned me, unsigned la, bool i if (timed_out(&msg)) return OK_PRESUMED; - return 0; + __u8 rec_status; + + cec_ops_record_status(&msg, &rec_status); + + fail_on_test(rec_status != CEC_OP_RECORD_STATUS_TERMINATED_OK && + rec_status != CEC_OP_RECORD_STATUS_ALREADY_TERM); + + return OK; } static const vec_remote_subtests one_touch_rec_subtests{ { "Record TV Screen", CEC_LOG_ADDR_MASK_TV, one_touch_rec_tv_screen }, - { "Record On", CEC_LOG_ADDR_MASK_RECORD, one_touch_rec_on }, - { "Record Off", CEC_LOG_ADDR_MASK_RECORD, one_touch_rec_off }, + { + "Record On", + CEC_LOG_ADDR_MASK_RECORD | CEC_LOG_ADDR_MASK_BACKUP, + one_touch_rec_on, + }, + { + "Record On Invalid Operand", + CEC_LOG_ADDR_MASK_RECORD | CEC_LOG_ADDR_MASK_BACKUP, + one_touch_rec_on_invalid, + }, + { "Record Off", CEC_LOG_ADDR_MASK_RECORD | CEC_LOG_ADDR_MASK_BACKUP, one_touch_rec_off }, + }; /* Timer Programming */ diff --git a/utils/cec-follower/cec-follower.cpp b/utils/cec-follower/cec-follower.cpp index ff47d698..482192e7 100644 --- a/utils/cec-follower/cec-follower.cpp +++ b/utils/cec-follower/cec-follower.cpp @@ -317,6 +317,7 @@ void state_init(struct node &node) node.state.deck_report_changes_to = 0; node.state.deck_state = CEC_OP_DECK_INFO_STOP; node.state.deck_skip_start = 0; + node.state.one_touch_record_on = false; tuner_dev_info_init(&node.state); node.state.last_aud_rate_rx_ts = 0; } diff --git a/utils/cec-follower/cec-follower.h b/utils/cec-follower/cec-follower.h index 343ae998..589ea6bf 100644 --- a/utils/cec-follower/cec-follower.h +++ b/utils/cec-follower/cec-follower.h @@ -53,6 +53,7 @@ struct state { __u8 deck_report_changes_to; __u8 deck_state; __u64 deck_skip_start; + bool one_touch_record_on; time_t toggle_power_status; __u64 last_aud_rate_rx_ts; }; @@ -62,6 +63,7 @@ struct node { const char *device; unsigned caps; unsigned available_log_addrs; + __u8 remote_prim_devtype; unsigned adap_la_mask; unsigned remote_la_mask; __u16 remote_phys_addr[15]; @@ -74,7 +76,6 @@ struct node { bool has_deck_ctl; bool has_rec_tv; bool has_osd_string; - bool ignore_la[16]; unsigned short ignore_opcode[256]; }; diff --git a/utils/cec-follower/cec-processing.cpp b/utils/cec-follower/cec-processing.cpp index b1c8f3d9..f985a841 100644 --- a/utils/cec-follower/cec-processing.cpp +++ b/utils/cec-follower/cec-processing.cpp @@ -396,8 +396,10 @@ static void processMsg(struct node *node, struct cec_msg &msg, unsigned me, __u8 __u8 prim_dev_type; cec_ops_report_physical_addr(&msg, &phys_addr, &prim_dev_type); - if (from < 15) + if (from < 15) { node->remote_phys_addr[from] = phys_addr; + node->remote_prim_devtype = prim_dev_type; + } return; } diff --git a/utils/cec-follower/cec-tuner.cpp b/utils/cec-follower/cec-tuner.cpp index d1718986..4ecb62a6 100644 --- a/utils/cec-follower/cec-tuner.cpp +++ b/utils/cec-follower/cec-tuner.cpp @@ -482,6 +482,155 @@ static bool analog_set_tuner_dev_info(struct node *node, struct cec_msg *msg) return false; } +static bool digital_service_info_valid(const struct cec_op_record_src &rec_src) +{ + switch (rec_src.digital.dig_bcast_system) { + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ARIB_GEN: + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ARIB_CS: + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ATSC_GEN: + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ATSC_CABLE: + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_DVB_GEN: + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_DVB_C: + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_DVB_S: + return true; + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ARIB_BS: + if (rec_src.digital.service_id_method == CEC_OP_SERVICE_ID_METHOD_BY_DIG_ID) { + for (unsigned i = 0; i < NUM_DIGITAL_CHANS; i++) { + + if (rec_src.digital.arib.transport_id == digital_arib_data[0][i].tsid && + rec_src.digital.arib.service_id == digital_arib_data[0][i].sid && + rec_src.digital.arib.orig_network_id == digital_arib_data[0][i].onid) + return true; + } + } else { + for (unsigned i = 0; i < NUM_DIGITAL_CHANS; i++) { + + if (rec_src.digital.channel.channel_number_fmt == digital_arib_data[0][i].fmt && + rec_src.digital.channel.major == digital_arib_data[0][i].major && + rec_src.digital.channel.minor == digital_arib_data[0][i].minor) + return true; + } + } + return false; + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ARIB_T: + if (rec_src.digital.service_id_method == CEC_OP_SERVICE_ID_METHOD_BY_DIG_ID) { + for (unsigned i = 0; i < NUM_DIGITAL_CHANS; i++) { + + if (rec_src.digital.arib.transport_id == digital_arib_data[1][i].tsid && + rec_src.digital.arib.service_id == digital_arib_data[1][i].sid && + rec_src.digital.arib.orig_network_id == digital_arib_data[1][i].onid) + return true; + } + } else { + for (unsigned i = 0; i < NUM_DIGITAL_CHANS; i++) { + + if (rec_src.digital.channel.channel_number_fmt == digital_arib_data[1][i].fmt && + rec_src.digital.channel.major == digital_arib_data[1][i].major && + rec_src.digital.channel.minor == digital_arib_data[1][i].minor) + return true; + } + } + return false; + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ATSC_SAT: + if (rec_src.digital.service_id_method == CEC_OP_SERVICE_ID_METHOD_BY_DIG_ID) { + + for (unsigned i = 0; i < NUM_DIGITAL_CHANS; i++) { + + if (rec_src.digital.atsc.transport_id == digital_atsc_data[0][i].tsid && + rec_src.digital.atsc.program_number == digital_atsc_data[0][i].sid) + return true; + } + } else { + for (unsigned i = 0; i < NUM_DIGITAL_CHANS; i++) { + + if (rec_src.digital.channel.channel_number_fmt == digital_atsc_data[0][i].fmt && + rec_src.digital.channel.major == digital_atsc_data[0][i].major && + rec_src.digital.channel.minor == digital_atsc_data[0][i].minor) + return true; + } + } + return false; + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ATSC_T: + if (rec_src.digital.service_id_method == CEC_OP_SERVICE_ID_METHOD_BY_DIG_ID) { + for (unsigned i = 0; i < NUM_DIGITAL_CHANS; i++) { + + if (rec_src.digital.atsc.transport_id == digital_atsc_data[1][i].tsid && + rec_src.digital.atsc.program_number == digital_atsc_data[1][i].sid) + return true; + } + } else { + for (unsigned i = 0; i < NUM_DIGITAL_CHANS; i++) { + + if (rec_src.digital.channel.channel_number_fmt == digital_atsc_data[1][i].fmt && + rec_src.digital.channel.major == digital_atsc_data[1][i].major && + rec_src.digital.channel.minor == digital_atsc_data[1][i].minor) + return true; + } + } + return false; + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_DVB_S2: + if (rec_src.digital.service_id_method == CEC_OP_SERVICE_ID_METHOD_BY_DIG_ID) { + for (unsigned i = 0; i < NUM_DIGITAL_CHANS; i++) { + if (rec_src.digital.dvb.transport_id == digital_dvb_data[0][i].tsid && + rec_src.digital.dvb.service_id == digital_dvb_data[0][i].sid && + rec_src.digital.dvb.orig_network_id == digital_dvb_data[0][i].onid) + return true; + } + } else { + for (unsigned i = 0; i < NUM_DIGITAL_CHANS; i++) { + + if (rec_src.digital.channel.channel_number_fmt == digital_dvb_data[0][i].fmt && + rec_src.digital.channel.major == digital_dvb_data[0][i].major && + rec_src.digital.channel.minor == digital_dvb_data[0][i].minor) + return true; + } + } + return false; + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_DVB_T: + if (rec_src.digital.service_id_method == CEC_OP_SERVICE_ID_METHOD_BY_DIG_ID) { + for (unsigned i = 0; i < NUM_DIGITAL_CHANS; i++) { + + if (rec_src.digital.dvb.transport_id == digital_dvb_data[1][i].tsid && + rec_src.digital.dvb.service_id == digital_dvb_data[1][i].sid && + rec_src.digital.dvb.orig_network_id == digital_dvb_data[1][i].onid) + return true; + } + } else { + for (unsigned i = 0; i < NUM_DIGITAL_CHANS; i++) { + + if (rec_src.digital.channel.channel_number_fmt == digital_dvb_data[1][i].fmt && + rec_src.digital.channel.major == digital_dvb_data[1][i].major && + rec_src.digital.channel.minor == digital_dvb_data[1][i].minor) + return true; + } + } + return false; + default: + return false; + } +} + +static bool analog_service_info_valid(const cec_op_record_src &rec_src) +{ + __u8 bcast_type = rec_src.analog.ana_bcast_type; + unsigned freq = (rec_src.analog.ana_freq * 625) / 10; + __u8 bcast_system = rec_src.analog.bcast_system; + + if (bcast_type > CEC_OP_ANA_BCAST_TYPE_TERRESTRIAL) + return false; + + if (bcast_system > CEC_OP_BCAST_SYSTEM_PAL_DK && bcast_system != CEC_OP_BCAST_SYSTEM_OTHER) + return false; + + for (unsigned i = 0; i < NUM_ANALOG_FREQS; i++) { + + if (freq == analog_freqs_khz[bcast_type][bcast_system][i]) + return true; + } + + return false; +} + void process_tuner_record_timer_msgs(struct node *node, struct cec_msg &msg, unsigned me, __u8 type) { bool is_bcast = cec_msg_is_broadcast(&msg); @@ -577,23 +726,16 @@ void process_tuner_record_timer_msgs(struct node *node, struct cec_msg &msg, uns return; } - /* - One Touch Record - - This is only a basic implementation. - - TODO: - - If we are a TV, we should only send Record On if the - remote end is a Recording device or Reserved. Otherwise ignore. - - - Device state should reflect whether we are recording, etc. In - recording mode we should ignore Standby messages. - */ + /* One Touch Record */ case CEC_MSG_RECORD_TV_SCREEN: { if (!node->has_rec_tv) break; + /* Ignore if initiator is not a recording device */ + if (node->remote_prim_devtype != CEC_OP_PRIM_DEVTYPE_RECORD) + return; + struct cec_op_record_src rec_src = {}; rec_src.type = CEC_OP_RECORD_SRC_OWN; @@ -602,24 +744,68 @@ void process_tuner_record_timer_msgs(struct node *node, struct cec_msg &msg, uns transmit(node, &msg); return; } - case CEC_MSG_RECORD_ON: - if (!cec_has_record(1 << me)) + case CEC_MSG_RECORD_ON: { + if (type != CEC_LOG_ADDR_TYPE_RECORD) + break; + + __u8 rec_status; + bool feature_abort = false; + struct cec_op_record_src rec_src = {}; + + cec_ops_record_on(&msg, &rec_src); + switch (rec_src.type) { + case CEC_OP_RECORD_SRC_OWN: + rec_status = CEC_OP_RECORD_STATUS_CUR_SRC; + break; + case CEC_OP_RECORD_SRC_DIGITAL: + if (digital_service_info_valid(rec_src)) + rec_status = CEC_OP_RECORD_STATUS_DIG_SERVICE; + else + feature_abort = true; + break; + case CEC_OP_RECORD_SRC_ANALOG: + if (analog_service_info_valid(rec_src)) + rec_status = CEC_OP_RECORD_STATUS_ANA_SERVICE; + else + feature_abort = true; + break; + case CEC_OP_RECORD_SRC_EXT_PLUG: + /* Plug number range is 1-255 in spec, but a realistic range of connectors is 6. */ + if (rec_src.ext_plug.plug < 1 || rec_src.ext_plug.plug > 6) + feature_abort = true; + else + rec_status = CEC_OP_RECORD_STATUS_EXT_INPUT; + break; + case CEC_OP_RECORD_SRC_EXT_PHYS_ADDR: + rec_status = CEC_OP_RECORD_STATUS_INVALID_EXT_PHYS_ADDR; break; + default: + feature_abort = true; + break; + } + if (feature_abort) { + reply_feature_abort(node, &msg, CEC_OP_ABORT_INVALID_OP); + return; + } + if (node->state.one_touch_record_on) + rec_status = CEC_OP_RECORD_STATUS_ALREADY_RECORDING; cec_msg_set_reply_to(&msg, &msg); - cec_msg_record_status(&msg, CEC_OP_RECORD_STATUS_CUR_SRC); + cec_msg_record_status(&msg, rec_status); transmit(node, &msg); + node->state.one_touch_record_on = true; return; + } case CEC_MSG_RECORD_OFF: - if (!cec_has_record(1 << me)) + if (type != CEC_LOG_ADDR_TYPE_RECORD) break; + cec_msg_set_reply_to(&msg, &msg); cec_msg_record_status(&msg, CEC_OP_RECORD_STATUS_TERMINATED_OK); transmit(node, &msg); + node->state.one_touch_record_on = false; return; case CEC_MSG_RECORD_STATUS: return; - - /* Timer Programming -- 2.25.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v4 2/3] cec: expand One Touch Record tests 2021-06-24 4:06 ` [PATCH v4 2/3] cec: expand One Touch Record tests Deborah Brouwer @ 2021-06-24 7:57 ` Hans Verkuil 0 siblings, 0 replies; 5+ messages in thread From: Hans Verkuil @ 2021-06-24 7:57 UTC (permalink / raw) To: Deborah Brouwer, linux-media; +Cc: jaffe1 On 24/06/2021 06:06, Deborah Brouwer wrote: > Expand the One Touch Record tests so that the follower and initiator know > their local and remote device types and respond accordingly. Send Record > TV Screen and check that Record On source replies are valid. Send Record > On source messages and check that Record Status replies are valid. Send > Record Off and check that the recording terminates. > > Signed-off-by: Deborah Brouwer <deborahbrouwer3563@gmail.com> > --- > utils/cec-compliance/cec-compliance.cpp | 1 + > utils/cec-compliance/cec-compliance.h | 1 + > utils/cec-compliance/cec-test.cpp | 366 ++++++++++++++++++++++-- > utils/cec-follower/cec-follower.cpp | 1 + > utils/cec-follower/cec-follower.h | 3 +- > utils/cec-follower/cec-processing.cpp | 4 +- > utils/cec-follower/cec-tuner.cpp | 222 ++++++++++++-- > 7 files changed, 549 insertions(+), 49 deletions(-) > > diff --git a/utils/cec-compliance/cec-compliance.cpp b/utils/cec-compliance/cec-compliance.cpp > index c04904c2..d4b12298 100644 > --- a/utils/cec-compliance/cec-compliance.cpp > +++ b/utils/cec-compliance/cec-compliance.cpp > @@ -1236,6 +1236,7 @@ int main(int argc, char **argv) > node.num_log_addrs = laddrs.num_log_addrs; > memcpy(node.log_addr, laddrs.log_addr, laddrs.num_log_addrs); > node.adap_la_mask = laddrs.log_addr_mask; > + node.prim_devtype = laddrs.primary_device_type[0]; > > printf("Find remote devices:\n"); > printf("\tPolling: %s\n", ok(poll_remote_devs(&node))); > diff --git a/utils/cec-compliance/cec-compliance.h b/utils/cec-compliance/cec-compliance.h > index 818181ab..41e2d63d 100644 > --- a/utils/cec-compliance/cec-compliance.h > +++ b/utils/cec-compliance/cec-compliance.h > @@ -166,6 +166,7 @@ struct node { > struct remote remote[16]; > __u16 phys_addr; > bool in_standby; > + __u8 prim_devtype; > }; > > struct remote_subtest { > diff --git a/utils/cec-compliance/cec-test.cpp b/utils/cec-compliance/cec-test.cpp > index 40d8369d..864ab83c 100644 > --- a/utils/cec-compliance/cec-test.cpp > +++ b/utils/cec-compliance/cec-test.cpp > @@ -48,6 +48,69 @@ static int test_play_mode(struct node *node, unsigned me, unsigned la, __u8 play > return OK; > } > > +static int one_touch_rec_on_send(struct node *node, unsigned me, unsigned la, > + const struct cec_op_record_src &rec_src, __u8 &rec_status) > +{ > + struct cec_msg msg; > + > + cec_msg_init(&msg, me, la); > + cec_msg_record_off(&msg, false); > + fail_on_test(!transmit_timeout(node, &msg)); > + > + cec_msg_init(&msg, me, la); > + cec_msg_record_on(&msg, true, &rec_src); Add a comment here why you need a 10000 ms timeout. > + fail_on_test(!transmit_timeout(node, &msg, 10000)); > + fail_on_test(timed_out_or_abort(&msg)); > + cec_ops_record_status(&msg, &rec_status); > + > + return OK; > +} > + > +static int one_touch_rec_on_send_invalid(struct node *node, unsigned me, unsigned la, > + const struct cec_op_record_src &rec_src) > +{ > + struct cec_msg msg; > + > + cec_msg_init(&msg, me, la); > + cec_msg_record_on(&msg, true, &rec_src); > + fail_on_test(!transmit_timeout(node, &msg)); > + fail_on_test(!cec_msg_status_is_abort(&msg)); > + fail_on_test(abort_reason(&msg) != CEC_OP_ABORT_INVALID_OP); > + > + return OK; > +} > + > +/* > + * Returns true if the Record Status is an error and the request I would rephrase this to: ...is an error indicating that the request... > + * to start recording has failed. > + */ > +static bool rec_status_is_a_valid_error_status(__u8 rec_status) > +{ > + switch (rec_status) { > + case CEC_OP_RECORD_STATUS_NO_DIG_SERVICE: > + case CEC_OP_RECORD_STATUS_NO_ANA_SERVICE: > + case CEC_OP_RECORD_STATUS_NO_SERVICE: > + case CEC_OP_RECORD_STATUS_INVALID_EXT_PLUG: > + case CEC_OP_RECORD_STATUS_INVALID_EXT_PHYS_ADDR: > + case CEC_OP_RECORD_STATUS_UNSUP_CA: > + case CEC_OP_RECORD_STATUS_NO_CA_ENTITLEMENTS: > + case CEC_OP_RECORD_STATUS_CANT_COPY_SRC: > + case CEC_OP_RECORD_STATUS_NO_MORE_COPIES: > + case CEC_OP_RECORD_STATUS_NO_MEDIA: > + case CEC_OP_RECORD_STATUS_PLAYING: > + case CEC_OP_RECORD_STATUS_ALREADY_RECORDING: > + case CEC_OP_RECORD_STATUS_MEDIA_PROT: > + case CEC_OP_RECORD_STATUS_NO_SIGNAL: > + case CEC_OP_RECORD_STATUS_MEDIA_PROBLEM: > + case CEC_OP_RECORD_STATUS_NO_SPACE: > + case CEC_OP_RECORD_STATUS_PARENTAL_LOCK: > + case CEC_OP_RECORD_STATUS_OTHER: > + return true; > + default: > + return false; > + } > +} > + > /* System Information */ > > int system_info_polling(struct node *node, unsigned me, unsigned la, bool interactive) > @@ -1141,24 +1204,14 @@ static const vec_remote_subtests tuner_ctl_subtests{ > > /* One Touch Record */ > > -/* > - TODO: These are very rudimentary tests which should be expanded. > - > - - The HDMI CEC 1.4b spec details that Standby shall not be acted upon while the > - device is recording, but it should remember that it received Standby. > - */ > - > static int one_touch_rec_tv_screen(struct node *node, unsigned me, unsigned la, bool interactive) > { > - /* > - TODO: > - - Page 36 in HDMI CEC 1.4b spec lists additional behaviors that should be > - checked for. > - - The TV should ignore this message when received from other LA than Recording or > - Reserved. > - */ > struct cec_msg msg; > > + cec_msg_init(&msg, me, la); > + cec_msg_report_physical_addr(&msg, node->phys_addr, node->prim_devtype); > + fail_on_test(!transmit_timeout(node, &msg)); > + > cec_msg_init(&msg, me, la); > cec_msg_record_tv_screen(&msg, true); > fail_on_test(!transmit_timeout(node, &msg)); > @@ -1172,45 +1225,283 @@ static int one_touch_rec_tv_screen(struct node *node, unsigned me, unsigned la, > return OK_REFUSED; > if (cec_msg_status_is_abort(&msg)) > return OK_PRESUMED; > + /* Follower should ignore this message if it is not sent by a recording device */ > + if (node->prim_devtype != CEC_OP_PRIM_DEVTYPE_RECORD) { > + fail_on_test(!timed_out(&msg)); > + return OK; > + } > + fail_on_test(timed_out(&msg)); > > - return 0; > + struct cec_op_record_src rec_src = {}; > + > + cec_ops_record_on(&msg, &rec_src); > + > + if (rec_src.type < CEC_OP_RECORD_SRC_OWN || rec_src.type > CEC_OP_RECORD_SRC_EXT_PHYS_ADDR) > + return fail("Invalid source.\n"); I would use the normal fail_on_test for this. > + > + if (rec_src.type == CEC_OP_RECORD_SRC_DIGITAL && > + rec_src.digital.service_id_method == CEC_OP_SERVICE_ID_METHOD_BY_DIG_ID) { > + switch (rec_src.digital.dig_bcast_system) { > + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ARIB_GEN: > + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ATSC_GEN: > + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_DVB_GEN: > + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ARIB_BS: > + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ARIB_CS: > + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ARIB_T: > + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ATSC_CABLE: > + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ATSC_SAT: > + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ATSC_T: > + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_DVB_C: > + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_DVB_S: > + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_DVB_S2: > + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_DVB_T: > + break; > + default: > + return fail("Invalid digital service broadcast system operand.\n"); > + } > + } > + > + if (rec_src.type == CEC_OP_RECORD_SRC_ANALOG) { > + fail_on_test(rec_src.analog.ana_bcast_type > CEC_OP_ANA_BCAST_TYPE_TERRESTRIAL); > + fail_on_test(rec_src.analog.bcast_system > CEC_OP_BCAST_SYSTEM_PAL_DK && > + rec_src.analog.bcast_system != CEC_OP_BCAST_SYSTEM_OTHER); > + fail_on_test(rec_src.analog.ana_freq == 0 || rec_src.analog.ana_freq == 0xffff); > + } > + > + if (rec_src.type == CEC_OP_RECORD_SRC_EXT_PLUG) > + fail_on_test(rec_src.ext_plug.plug == 0); > + > + return OK; > } > > static int one_touch_rec_on(struct node *node, unsigned me, unsigned la, bool interactive) > { > - /* > - TODO: Page 36 in HDMI CEC 1.4b spec lists additional behaviors that should be > - checked for. > - */ > struct cec_msg msg; > struct cec_op_record_src rec_src = {}; > > rec_src.type = CEC_OP_RECORD_SRC_OWN; > cec_msg_init(&msg, me, la); > cec_msg_record_on(&msg, true, &rec_src); > - fail_on_test(!transmit_timeout(node, &msg)); > + /* Allow 10s for reply because the spec says it may take several seconds to accurately respond. */ > + fail_on_test(!transmit_timeout(node, &msg, 10000)); > fail_on_test(timed_out(&msg)); > - fail_on_test(cec_has_record(1 << la) && unrecognized_op(&msg)); > - if (unrecognized_op(&msg)) > + if (unrecognized_op(&msg)) { > + fail_on_test(node->remote[la].prim_type == CEC_OP_PRIM_DEVTYPE_RECORD); > return OK_NOT_SUPPORTED; > + } > if (refused(&msg)) > return OK_REFUSED; > if (cec_msg_status_is_abort(&msg)) > return OK_PRESUMED; > > - return 0; > + __u8 rec_status; > + > + cec_ops_record_status(&msg, &rec_status); > + if (rec_status != CEC_OP_RECORD_STATUS_CUR_SRC) > + fail_on_test(!rec_status_is_a_valid_error_status(rec_status)); > + Add a comment here stating that these digital services are taken from the cec-follower tuner emulation. I would also order these tests by broadcast system: so first test the ARIB variants, then ATSC, then DVB. > + memset(&rec_src, 0, sizeof(rec_src)); > + rec_src.type = CEC_OP_RECORD_SRC_DIGITAL; > + rec_src.digital.service_id_method = CEC_OP_SERVICE_ID_METHOD_BY_DIG_ID; > + rec_src.digital.dig_bcast_system = CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ARIB_BS; > + rec_src.digital.arib.transport_id = 1046; > + rec_src.digital.arib.service_id = 30505; > + rec_src.digital.arib.orig_network_id = 1; > + fail_on_test(one_touch_rec_on_send(node, me, la, rec_src, rec_status)); > + if (rec_status != CEC_OP_RECORD_STATUS_DIG_SERVICE) > + fail_on_test(!rec_status_is_a_valid_error_status(rec_status)); > + > + memset(&rec_src, 0, sizeof(rec_src)); > + rec_src.type = CEC_OP_RECORD_SRC_DIGITAL; > + rec_src.digital.service_id_method = CEC_OP_SERVICE_ID_METHOD_BY_DIG_ID; > + rec_src.digital.dig_bcast_system = CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ATSC_T; > + rec_src.digital.atsc.transport_id = 1675; > + rec_src.digital.atsc.program_number = 3; > + fail_on_test(one_touch_rec_on_send(node, me, la, rec_src, rec_status)); > + if (rec_status != CEC_OP_RECORD_STATUS_DIG_SERVICE) > + fail_on_test(!rec_status_is_a_valid_error_status(rec_status)); > + > + memset(&rec_src, 0, sizeof(rec_src)); > + rec_src.type = CEC_OP_RECORD_SRC_DIGITAL; > + rec_src.digital.service_id_method = CEC_OP_SERVICE_ID_METHOD_BY_DIG_ID; > + rec_src.digital.dig_bcast_system = CEC_OP_DIG_SERVICE_BCAST_SYSTEM_DVB_S2; > + rec_src.digital.dvb.transport_id = 61; > + rec_src.digital.dvb.service_id = 7193; > + rec_src.digital.dvb.orig_network_id = 70; > + fail_on_test(one_touch_rec_on_send(node, me, la, rec_src, rec_status)); > + if (rec_status != CEC_OP_RECORD_STATUS_DIG_SERVICE) > + fail_on_test(!rec_status_is_a_valid_error_status(rec_status)); > + > + memset(&rec_src, 0, sizeof(rec_src)); > + rec_src.type = CEC_OP_RECORD_SRC_DIGITAL; > + rec_src.digital.service_id_method = CEC_OP_SERVICE_ID_METHOD_BY_CHANNEL; > + rec_src.digital.dig_bcast_system = CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ARIB_T; > + rec_src.digital.channel.channel_number_fmt = 1; > + rec_src.digital.channel.major = 0; > + rec_src.digital.channel.minor = 51992; > + fail_on_test(one_touch_rec_on_send(node, me, la, rec_src, rec_status)); > + if (rec_status != CEC_OP_RECORD_STATUS_DIG_SERVICE) > + fail_on_test(!rec_status_is_a_valid_error_status(rec_status)); > + > + memset(&rec_src, 0, sizeof(rec_src)); > + rec_src.type = CEC_OP_RECORD_SRC_DIGITAL; > + rec_src.digital.service_id_method = CEC_OP_SERVICE_ID_METHOD_BY_CHANNEL; > + rec_src.digital.dig_bcast_system = CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ATSC_SAT; > + rec_src.digital.channel.channel_number_fmt = 2; > + rec_src.digital.channel.major = 3; > + rec_src.digital.channel.minor = 55295; > + fail_on_test(one_touch_rec_on_send(node, me, la, rec_src, rec_status)); > + if (rec_status != CEC_OP_RECORD_STATUS_DIG_SERVICE) > + fail_on_test(!rec_status_is_a_valid_error_status(rec_status)); > + > + memset(&rec_src, 0, sizeof(rec_src)); > + rec_src.type = CEC_OP_RECORD_SRC_DIGITAL; > + rec_src.digital.service_id_method = CEC_OP_SERVICE_ID_METHOD_BY_CHANNEL; > + rec_src.digital.dig_bcast_system = CEC_OP_DIG_SERVICE_BCAST_SYSTEM_DVB_T; > + rec_src.digital.channel.channel_number_fmt = 1; > + rec_src.digital.channel.major = 0; > + rec_src.digital.channel.minor = 21; > + fail_on_test(one_touch_rec_on_send(node, me, la, rec_src, rec_status)); > + if (rec_status != CEC_OP_RECORD_STATUS_DIG_SERVICE) > + fail_on_test(!rec_status_is_a_valid_error_status(rec_status)); > + Add a comment here as well, mentioning that these channels are based on what the cec-follower emulates. > + memset(&rec_src, 0, sizeof(rec_src)); > + rec_src.type = CEC_OP_RECORD_STATUS_ANA_SERVICE; > + rec_src.analog.ana_bcast_type = CEC_OP_ANA_BCAST_TYPE_CABLE; > + rec_src.analog.ana_freq = (471250 * 10) / 625; > + rec_src.analog.bcast_system = CEC_OP_BCAST_SYSTEM_PAL_BG; > + fail_on_test(one_touch_rec_on_send(node, me, la, rec_src, rec_status)); > + if (rec_status != CEC_OP_RECORD_STATUS_ANA_SERVICE) > + fail_on_test(!rec_status_is_a_valid_error_status(rec_status)); > + > + memset(&rec_src, 0, sizeof(rec_src)); > + rec_src.type = CEC_OP_RECORD_STATUS_ANA_SERVICE; > + rec_src.analog.ana_bcast_type = CEC_OP_ANA_BCAST_TYPE_SATELLITE; > + rec_src.analog.ana_freq = (551250 * 10) / 625; > + rec_src.analog.bcast_system = CEC_OP_BCAST_SYSTEM_SECAM_BG; > + fail_on_test(one_touch_rec_on_send(node, me, la, rec_src, rec_status)); > + if (rec_status != CEC_OP_RECORD_STATUS_ANA_SERVICE) > + fail_on_test(!rec_status_is_a_valid_error_status(rec_status)); > + > + memset(&rec_src, 0, sizeof(rec_src)); > + rec_src.type = CEC_OP_RECORD_STATUS_ANA_SERVICE; > + rec_src.analog.ana_bcast_type = CEC_OP_ANA_BCAST_TYPE_TERRESTRIAL; > + rec_src.analog.ana_freq = (185250 * 10) / 625; > + rec_src.analog.bcast_system = CEC_OP_BCAST_SYSTEM_PAL_DK; > + fail_on_test(one_touch_rec_on_send(node, me, la, rec_src, rec_status)); > + if (rec_status != CEC_OP_RECORD_STATUS_ANA_SERVICE) > + fail_on_test(!rec_status_is_a_valid_error_status(rec_status)); > + > + memset(&rec_src, 0, sizeof(rec_src)); > + rec_src.type = CEC_OP_RECORD_SRC_EXT_PLUG; > + rec_src.ext_plug.plug = 1; > + fail_on_test(one_touch_rec_on_send(node, me, la, rec_src, rec_status)); > + if (rec_status != CEC_OP_RECORD_STATUS_EXT_INPUT) > + fail_on_test(!rec_status_is_a_valid_error_status(rec_status)); > + > + memset(&rec_src, 0, sizeof(rec_src)); > + rec_src.type = CEC_OP_RECORD_SRC_EXT_PHYS_ADDR; > + fail_on_test(one_touch_rec_on_send(node, me, la, rec_src, rec_status)); > + if (rec_status != CEC_OP_RECORD_STATUS_EXT_INPUT) > + fail_on_test(!rec_status_is_a_valid_error_status(rec_status)); > + > + return OK; > } > > -static int one_touch_rec_off(struct node *node, unsigned me, unsigned la, bool interactive) > +static int one_touch_rec_on_invalid(struct node *node, unsigned me, unsigned la, bool interactive) > { > struct cec_msg msg; > > cec_msg_init(&msg, me, la); > - cec_msg_record_off(&msg, false); > + cec_msg_record_on_own(&msg); > + msg.msg[2] = 0; /* Invalid source operand */ > fail_on_test(!transmit_timeout(node, &msg)); > - fail_on_test(cec_has_record(1 << la) && unrecognized_op(&msg)); > if (unrecognized_op(&msg)) > return OK_NOT_SUPPORTED; > + fail_on_test(!cec_msg_status_is_abort(&msg)); > + fail_on_test(abort_reason(&msg) != CEC_OP_ABORT_INVALID_OP); > + > + cec_msg_init(&msg, me, la); > + cec_msg_record_on_own(&msg); > + msg.msg[2] = 6; /* Invalid source operand */ > + fail_on_test(!transmit_timeout(node, &msg)); > + fail_on_test(!cec_msg_status_is_abort(&msg)); > + fail_on_test(abort_reason(&msg) != CEC_OP_ABORT_INVALID_OP); > + > + struct cec_op_record_src rec_src = {}; > + > + rec_src.type = CEC_OP_RECORD_SRC_DIGITAL; > + rec_src.digital.service_id_method = CEC_OP_SERVICE_ID_METHOD_BY_CHANNEL; > + rec_src.digital.dig_bcast_system = 0x7f; /* Invalid digital service broadcast system */ > + rec_src.digital.channel.channel_number_fmt = 1; > + rec_src.digital.channel.major = 0; > + rec_src.digital.channel.minor = 30203; > + fail_on_test(one_touch_rec_on_send_invalid(node, me, la, rec_src)); > + > + memset(&rec_src, 0, sizeof(rec_src)); > + rec_src.type = CEC_OP_RECORD_SRC_DIGITAL; > + rec_src.digital.service_id_method = CEC_OP_SERVICE_ID_METHOD_BY_DIG_ID; > + rec_src.digital.dig_bcast_system = CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ATSC_SAT; > + rec_src.digital.atsc.transport_id = 0; /* Invalid transport id */ > + rec_src.digital.atsc.program_number = 50316; > + fail_on_test(one_touch_rec_on_send_invalid(node, me, la, rec_src)); > + > + memset(&rec_src, 0, sizeof(rec_src)); > + rec_src.type = CEC_OP_RECORD_SRC_DIGITAL; > + rec_src.digital.service_id_method = CEC_OP_SERVICE_ID_METHOD_BY_DIG_ID; > + rec_src.digital.dig_bcast_system = CEC_OP_DIG_SERVICE_BCAST_SYSTEM_DVB_T; > + rec_src.digital.dvb.transport_id = 1004; > + rec_src.digital.dvb.service_id = 0; /* Invalid service id */ > + rec_src.digital.dvb.orig_network_id = 8945; > + fail_on_test(one_touch_rec_on_send_invalid(node, me, la, rec_src)); > + > + memset(&rec_src, 0, sizeof(rec_src)); > + rec_src.type = CEC_OP_RECORD_SRC_ANALOG; > + rec_src.analog.ana_bcast_type = 0xff; /* Invalid analog broadcast type */ > + rec_src.analog.ana_freq = (519250 * 10) / 625; > + rec_src.analog.bcast_system = CEC_OP_BCAST_SYSTEM_PAL_BG; > + fail_on_test(one_touch_rec_on_send_invalid(node, me, la, rec_src)); > + > + memset(&rec_src, 0, sizeof(rec_src)); > + rec_src.type = CEC_OP_RECORD_SRC_ANALOG; > + rec_src.analog.ana_bcast_type = CEC_OP_ANA_BCAST_TYPE_TERRESTRIAL; > + rec_src.analog.ana_freq = 0; /* Invalid analog frequency */ > + rec_src.analog.bcast_system = CEC_OP_BCAST_SYSTEM_NTSC_M; > + fail_on_test(one_touch_rec_on_send_invalid(node, me, la, rec_src)); > + > + memset(&rec_src, 0, sizeof(rec_src)); > + rec_src.type = CEC_OP_RECORD_SRC_ANALOG; > + rec_src.analog.ana_bcast_type = CEC_OP_ANA_BCAST_TYPE_CABLE; > + rec_src.analog.ana_freq = 0xffff; /* Invalid analog frequency */ > + rec_src.analog.bcast_system = CEC_OP_BCAST_SYSTEM_SECAM_L; > + fail_on_test(one_touch_rec_on_send_invalid(node, me, la, rec_src)); > + > + memset(&rec_src, 0, sizeof(rec_src)); > + rec_src.type = CEC_OP_RECORD_SRC_ANALOG; > + rec_src.analog.ana_bcast_type = CEC_OP_ANA_BCAST_TYPE_SATELLITE; > + rec_src.analog.ana_freq = (703250 * 10) / 625; > + rec_src.analog.bcast_system = 0xff; /* Invalid analog broadcast system */ > + fail_on_test(one_touch_rec_on_send_invalid(node, me, la, rec_src)); > + > + memset(&rec_src, 0, sizeof(rec_src)); > + rec_src.type = CEC_OP_RECORD_SRC_EXT_PLUG; > + rec_src.ext_plug.plug = 0; /* Invalid plug */ > + fail_on_test(one_touch_rec_on_send_invalid(node, me, la, rec_src)); > + > + return OK; > +} > + > +static int one_touch_rec_off(struct node *node, unsigned me, unsigned la, bool interactive) > +{ > + struct cec_msg msg; > + > + cec_msg_init(&msg, me, la); > + cec_msg_record_off(&msg, true); > + fail_on_test(!transmit_timeout(node, &msg)); Is a 10s timeout also needed for <Record Off>? It sounds reasonable. > + if (unrecognized_op(&msg)) { > + fail_on_test(node->remote[la].prim_type == CEC_OP_PRIM_DEVTYPE_RECORD); > + return OK_NOT_SUPPORTED; > + } > if (refused(&msg)) > return OK_REFUSED; > if (cec_msg_status_is_abort(&msg)) > @@ -1218,13 +1509,30 @@ static int one_touch_rec_off(struct node *node, unsigned me, unsigned la, bool i > if (timed_out(&msg)) > return OK_PRESUMED; > > - return 0; > + __u8 rec_status; > + > + cec_ops_record_status(&msg, &rec_status); > + > + fail_on_test(rec_status != CEC_OP_RECORD_STATUS_TERMINATED_OK && > + rec_status != CEC_OP_RECORD_STATUS_ALREADY_TERM); > + > + return OK; > } > > static const vec_remote_subtests one_touch_rec_subtests{ > { "Record TV Screen", CEC_LOG_ADDR_MASK_TV, one_touch_rec_tv_screen }, > - { "Record On", CEC_LOG_ADDR_MASK_RECORD, one_touch_rec_on }, > - { "Record Off", CEC_LOG_ADDR_MASK_RECORD, one_touch_rec_off }, > + { > + "Record On", > + CEC_LOG_ADDR_MASK_RECORD | CEC_LOG_ADDR_MASK_BACKUP, > + one_touch_rec_on, > + }, > + { > + "Record On Invalid Operand", > + CEC_LOG_ADDR_MASK_RECORD | CEC_LOG_ADDR_MASK_BACKUP, > + one_touch_rec_on_invalid, > + }, > + { "Record Off", CEC_LOG_ADDR_MASK_RECORD | CEC_LOG_ADDR_MASK_BACKUP, one_touch_rec_off }, > + > }; > > /* Timer Programming */ > diff --git a/utils/cec-follower/cec-follower.cpp b/utils/cec-follower/cec-follower.cpp > index ff47d698..482192e7 100644 > --- a/utils/cec-follower/cec-follower.cpp > +++ b/utils/cec-follower/cec-follower.cpp > @@ -317,6 +317,7 @@ void state_init(struct node &node) > node.state.deck_report_changes_to = 0; > node.state.deck_state = CEC_OP_DECK_INFO_STOP; > node.state.deck_skip_start = 0; > + node.state.one_touch_record_on = false; > tuner_dev_info_init(&node.state); > node.state.last_aud_rate_rx_ts = 0; > } > diff --git a/utils/cec-follower/cec-follower.h b/utils/cec-follower/cec-follower.h > index 343ae998..589ea6bf 100644 > --- a/utils/cec-follower/cec-follower.h > +++ b/utils/cec-follower/cec-follower.h > @@ -53,6 +53,7 @@ struct state { > __u8 deck_report_changes_to; > __u8 deck_state; > __u64 deck_skip_start; > + bool one_touch_record_on; > time_t toggle_power_status; > __u64 last_aud_rate_rx_ts; > }; > @@ -62,6 +63,7 @@ struct node { > const char *device; > unsigned caps; > unsigned available_log_addrs; > + __u8 remote_prim_devtype; > unsigned adap_la_mask; > unsigned remote_la_mask; > __u16 remote_phys_addr[15]; > @@ -74,7 +76,6 @@ struct node { > bool has_deck_ctl; > bool has_rec_tv; > bool has_osd_string; > - Please keep this newline. > bool ignore_la[16]; > unsigned short ignore_opcode[256]; > }; > diff --git a/utils/cec-follower/cec-processing.cpp b/utils/cec-follower/cec-processing.cpp > index b1c8f3d9..f985a841 100644 > --- a/utils/cec-follower/cec-processing.cpp > +++ b/utils/cec-follower/cec-processing.cpp > @@ -396,8 +396,10 @@ static void processMsg(struct node *node, struct cec_msg &msg, unsigned me, __u8 > __u8 prim_dev_type; > > cec_ops_report_physical_addr(&msg, &phys_addr, &prim_dev_type); > - if (from < 15) > + if (from < 15) { > node->remote_phys_addr[from] = phys_addr; > + node->remote_prim_devtype = prim_dev_type; > + } > return; > } > > diff --git a/utils/cec-follower/cec-tuner.cpp b/utils/cec-follower/cec-tuner.cpp > index d1718986..4ecb62a6 100644 > --- a/utils/cec-follower/cec-tuner.cpp > +++ b/utils/cec-follower/cec-tuner.cpp > @@ -482,6 +482,155 @@ static bool analog_set_tuner_dev_info(struct node *node, struct cec_msg *msg) > return false; > } > > +static bool digital_service_info_valid(const struct cec_op_record_src &rec_src) > +{ > + switch (rec_src.digital.dig_bcast_system) { > + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ARIB_GEN: > + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ARIB_CS: > + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ATSC_GEN: > + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ATSC_CABLE: > + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_DVB_GEN: > + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_DVB_C: > + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_DVB_S: > + return true; > + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ARIB_BS: > + if (rec_src.digital.service_id_method == CEC_OP_SERVICE_ID_METHOD_BY_DIG_ID) { > + for (unsigned i = 0; i < NUM_DIGITAL_CHANS; i++) { > + > + if (rec_src.digital.arib.transport_id == digital_arib_data[0][i].tsid && > + rec_src.digital.arib.service_id == digital_arib_data[0][i].sid && > + rec_src.digital.arib.orig_network_id == digital_arib_data[0][i].onid) > + return true; > + } > + } else { > + for (unsigned i = 0; i < NUM_DIGITAL_CHANS; i++) { > + > + if (rec_src.digital.channel.channel_number_fmt == digital_arib_data[0][i].fmt && > + rec_src.digital.channel.major == digital_arib_data[0][i].major && > + rec_src.digital.channel.minor == digital_arib_data[0][i].minor) > + return true; > + } > + } > + return false; I think you are mixing up two different things here: detecting whether one of the operands is invalid, and whether the operands are valid, but do not match one of the emulated channels/services. In the first case you Feature Abort with Invalid Op, in the second case the recording status changes to an error (CEC_OP_RECORD_STATUS_NO_DIG/ANA_SERVICE). For the second case (validating service information), you should be able to use existing functions in cec-tuner.cpp, I think at least digital_get_service_idx() can be used. I'm not sure about analog_get_nearest_service_idx(): getting the closest analog channel may not be appropriate. > + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ARIB_T: > + if (rec_src.digital.service_id_method == CEC_OP_SERVICE_ID_METHOD_BY_DIG_ID) { > + for (unsigned i = 0; i < NUM_DIGITAL_CHANS; i++) { > + > + if (rec_src.digital.arib.transport_id == digital_arib_data[1][i].tsid && > + rec_src.digital.arib.service_id == digital_arib_data[1][i].sid && > + rec_src.digital.arib.orig_network_id == digital_arib_data[1][i].onid) > + return true; > + } > + } else { > + for (unsigned i = 0; i < NUM_DIGITAL_CHANS; i++) { > + > + if (rec_src.digital.channel.channel_number_fmt == digital_arib_data[1][i].fmt && > + rec_src.digital.channel.major == digital_arib_data[1][i].major && > + rec_src.digital.channel.minor == digital_arib_data[1][i].minor) > + return true; > + } > + } > + return false; > + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ATSC_SAT: > + if (rec_src.digital.service_id_method == CEC_OP_SERVICE_ID_METHOD_BY_DIG_ID) { > + > + for (unsigned i = 0; i < NUM_DIGITAL_CHANS; i++) { > + > + if (rec_src.digital.atsc.transport_id == digital_atsc_data[0][i].tsid && > + rec_src.digital.atsc.program_number == digital_atsc_data[0][i].sid) > + return true; > + } > + } else { > + for (unsigned i = 0; i < NUM_DIGITAL_CHANS; i++) { > + > + if (rec_src.digital.channel.channel_number_fmt == digital_atsc_data[0][i].fmt && > + rec_src.digital.channel.major == digital_atsc_data[0][i].major && > + rec_src.digital.channel.minor == digital_atsc_data[0][i].minor) > + return true; > + } > + } > + return false; > + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_ATSC_T: > + if (rec_src.digital.service_id_method == CEC_OP_SERVICE_ID_METHOD_BY_DIG_ID) { > + for (unsigned i = 0; i < NUM_DIGITAL_CHANS; i++) { > + > + if (rec_src.digital.atsc.transport_id == digital_atsc_data[1][i].tsid && > + rec_src.digital.atsc.program_number == digital_atsc_data[1][i].sid) > + return true; > + } > + } else { > + for (unsigned i = 0; i < NUM_DIGITAL_CHANS; i++) { > + > + if (rec_src.digital.channel.channel_number_fmt == digital_atsc_data[1][i].fmt && > + rec_src.digital.channel.major == digital_atsc_data[1][i].major && > + rec_src.digital.channel.minor == digital_atsc_data[1][i].minor) > + return true; > + } > + } > + return false; > + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_DVB_S2: > + if (rec_src.digital.service_id_method == CEC_OP_SERVICE_ID_METHOD_BY_DIG_ID) { > + for (unsigned i = 0; i < NUM_DIGITAL_CHANS; i++) { > + if (rec_src.digital.dvb.transport_id == digital_dvb_data[0][i].tsid && > + rec_src.digital.dvb.service_id == digital_dvb_data[0][i].sid && > + rec_src.digital.dvb.orig_network_id == digital_dvb_data[0][i].onid) > + return true; > + } > + } else { > + for (unsigned i = 0; i < NUM_DIGITAL_CHANS; i++) { > + > + if (rec_src.digital.channel.channel_number_fmt == digital_dvb_data[0][i].fmt && > + rec_src.digital.channel.major == digital_dvb_data[0][i].major && > + rec_src.digital.channel.minor == digital_dvb_data[0][i].minor) > + return true; > + } > + } > + return false; > + case CEC_OP_DIG_SERVICE_BCAST_SYSTEM_DVB_T: > + if (rec_src.digital.service_id_method == CEC_OP_SERVICE_ID_METHOD_BY_DIG_ID) { > + for (unsigned i = 0; i < NUM_DIGITAL_CHANS; i++) { > + > + if (rec_src.digital.dvb.transport_id == digital_dvb_data[1][i].tsid && > + rec_src.digital.dvb.service_id == digital_dvb_data[1][i].sid && > + rec_src.digital.dvb.orig_network_id == digital_dvb_data[1][i].onid) > + return true; > + } > + } else { > + for (unsigned i = 0; i < NUM_DIGITAL_CHANS; i++) { > + > + if (rec_src.digital.channel.channel_number_fmt == digital_dvb_data[1][i].fmt && > + rec_src.digital.channel.major == digital_dvb_data[1][i].major && > + rec_src.digital.channel.minor == digital_dvb_data[1][i].minor) > + return true; > + } > + } > + return false; > + default: > + return false; > + } > +} > + > +static bool analog_service_info_valid(const cec_op_record_src &rec_src) > +{ > + __u8 bcast_type = rec_src.analog.ana_bcast_type; > + unsigned freq = (rec_src.analog.ana_freq * 625) / 10; > + __u8 bcast_system = rec_src.analog.bcast_system; > + > + if (bcast_type > CEC_OP_ANA_BCAST_TYPE_TERRESTRIAL) > + return false; > + > + if (bcast_system > CEC_OP_BCAST_SYSTEM_PAL_DK && bcast_system != CEC_OP_BCAST_SYSTEM_OTHER) > + return false; > + > + for (unsigned i = 0; i < NUM_ANALOG_FREQS; i++) { > + > + if (freq == analog_freqs_khz[bcast_type][bcast_system][i]) > + return true; > + } > + > + return false; > +} > + > void process_tuner_record_timer_msgs(struct node *node, struct cec_msg &msg, unsigned me, __u8 type) > { > bool is_bcast = cec_msg_is_broadcast(&msg); > @@ -577,23 +726,16 @@ void process_tuner_record_timer_msgs(struct node *node, struct cec_msg &msg, uns > return; > } > > - /* > - One Touch Record > - > - This is only a basic implementation. > - > - TODO: > - - If we are a TV, we should only send Record On if the > - remote end is a Recording device or Reserved. Otherwise ignore. > - > - - Device state should reflect whether we are recording, etc. In > - recording mode we should ignore Standby messages. > - */ > + /* One Touch Record */ > > case CEC_MSG_RECORD_TV_SCREEN: { > if (!node->has_rec_tv) > break; > > + /* Ignore if initiator is not a recording device */ > + if (node->remote_prim_devtype != CEC_OP_PRIM_DEVTYPE_RECORD) > + return; > + > struct cec_op_record_src rec_src = {}; > > rec_src.type = CEC_OP_RECORD_SRC_OWN; > @@ -602,24 +744,68 @@ void process_tuner_record_timer_msgs(struct node *node, struct cec_msg &msg, uns > transmit(node, &msg); > return; > } > - case CEC_MSG_RECORD_ON: > - if (!cec_has_record(1 << me)) > + case CEC_MSG_RECORD_ON: { > + if (type != CEC_LOG_ADDR_TYPE_RECORD) > + break; > + > + __u8 rec_status; > + bool feature_abort = false; > + struct cec_op_record_src rec_src = {}; > + > + cec_ops_record_on(&msg, &rec_src); > + switch (rec_src.type) { > + case CEC_OP_RECORD_SRC_OWN: > + rec_status = CEC_OP_RECORD_STATUS_CUR_SRC; > + break; > + case CEC_OP_RECORD_SRC_DIGITAL: > + if (digital_service_info_valid(rec_src)) > + rec_status = CEC_OP_RECORD_STATUS_DIG_SERVICE; > + else > + feature_abort = true; > + break; > + case CEC_OP_RECORD_SRC_ANALOG: > + if (analog_service_info_valid(rec_src)) > + rec_status = CEC_OP_RECORD_STATUS_ANA_SERVICE; > + else > + feature_abort = true; > + break; > + case CEC_OP_RECORD_SRC_EXT_PLUG: > + /* Plug number range is 1-255 in spec, but a realistic range of connectors is 6. */ > + if (rec_src.ext_plug.plug < 1 || rec_src.ext_plug.plug > 6) > + feature_abort = true; > + else > + rec_status = CEC_OP_RECORD_STATUS_EXT_INPUT; > + break; > + case CEC_OP_RECORD_SRC_EXT_PHYS_ADDR: > + rec_status = CEC_OP_RECORD_STATUS_INVALID_EXT_PHYS_ADDR; > break; > + default: > + feature_abort = true; > + break; > + } > + if (feature_abort) { > + reply_feature_abort(node, &msg, CEC_OP_ABORT_INVALID_OP); > + return; > + } > + if (node->state.one_touch_record_on) > + rec_status = CEC_OP_RECORD_STATUS_ALREADY_RECORDING; > cec_msg_set_reply_to(&msg, &msg); > - cec_msg_record_status(&msg, CEC_OP_RECORD_STATUS_CUR_SRC); > + cec_msg_record_status(&msg, rec_status); > transmit(node, &msg); > + node->state.one_touch_record_on = true; > return; > + } > case CEC_MSG_RECORD_OFF: > - if (!cec_has_record(1 << me)) > + if (type != CEC_LOG_ADDR_TYPE_RECORD) > break; > + > cec_msg_set_reply_to(&msg, &msg); > cec_msg_record_status(&msg, CEC_OP_RECORD_STATUS_TERMINATED_OK); > transmit(node, &msg); > + node->state.one_touch_record_on = false; > return; > case CEC_MSG_RECORD_STATUS: > return; > - > - > /* > Timer Programming > > Regards, Hans ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v4 3/3] cec: add One Touch Record Standby tests 2021-06-24 4:06 [PATCH v4 0/3] cec: One Touch Record tests Deborah Brouwer 2021-06-24 4:06 ` [PATCH v4 1/3] cec-follower: use log_addr_type to get local device type Deborah Brouwer 2021-06-24 4:06 ` [PATCH v4 2/3] cec: expand One Touch Record tests Deborah Brouwer @ 2021-06-24 4:06 ` Deborah Brouwer 2 siblings, 0 replies; 5+ messages in thread From: Deborah Brouwer @ 2021-06-24 4:06 UTC (permalink / raw) To: linux-media; +Cc: hverkuil, jaffe1, Deborah Brouwer Check that the recording device ignores a Standby message while it is recording. When the recording is finished, check that the recording device enters standby unless the recording device is the active source. Signed-off-by: Deborah Brouwer <deborahbrouwer3563@gmail.com> --- utils/cec-compliance/cec-test-power.cpp | 63 +++++++++++++++++++++++++ utils/cec-follower/cec-follower.h | 2 + utils/cec-follower/cec-processing.cpp | 8 +++- utils/cec-follower/cec-tuner.cpp | 9 ++++ 4 files changed, 80 insertions(+), 2 deletions(-) diff --git a/utils/cec-compliance/cec-test-power.cpp b/utils/cec-compliance/cec-test-power.cpp index b675bfc4..c6bf7093 100644 --- a/utils/cec-compliance/cec-test-power.cpp +++ b/utils/cec-compliance/cec-test-power.cpp @@ -677,6 +677,67 @@ static int standby_resume_wakeup_deck_play(struct node *node, unsigned me, unsig return standby_resume_wakeup_deck(node, me, la, interactive, CEC_OP_PLAY_MODE_PLAY_FWD); } +static int standby_record(struct node *node, unsigned me, unsigned la, bool interactive, __u8 opcode) +{ + struct cec_msg msg; + __u8 rec_status; + + cec_msg_init(&msg, me, la); + cec_msg_record_on_own(&msg); + msg.reply = CEC_MSG_RECORD_STATUS; + fail_on_test(!transmit_timeout(node, &msg, 10000)); + if (timed_out_or_abort(&msg)) + return OK_NOT_SUPPORTED; + cec_ops_record_status(&msg, &rec_status); + fail_on_test(rec_status != CEC_OP_RECORD_STATUS_CUR_SRC && + rec_status != CEC_OP_RECORD_STATUS_ALREADY_RECORDING); + + cec_msg_init(&msg, me, la); + cec_msg_standby(&msg); + fail_on_test(!transmit_timeout(node, &msg)); + /* Standby should not interrupt the recording. */ + fail_on_test(!cec_msg_status_is_abort(&msg)); + + /* When the recording stops, the recorder should standby unless the recorder is the active source */ + cec_msg_init(&msg, me, la); + if (opcode == CEC_MSG_ACTIVE_SOURCE) + cec_msg_active_source(&msg, node->remote[la].phys_addr); + else + cec_msg_active_source(&msg, node->remote[la].phys_addr + 1); + fail_on_test(!transmit_timeout(node, &msg)); + + cec_msg_init(&msg, me, la); + cec_msg_record_off(&msg, false); + fail_on_test(!transmit_timeout(node, &msg)); + + unsigned unresponsive_time = 0; + + if (opcode == CEC_MSG_ACTIVE_SOURCE) { + fail_on_test(!poll_stable_power_status(node, me, la, CEC_OP_POWER_STATUS_ON, unresponsive_time)); + } else { + fail_on_test(!poll_stable_power_status(node, me, la, CEC_OP_POWER_STATUS_STANDBY, unresponsive_time)); + fail_on_test(interactive && !question("Is the device in standby?")); + node->remote[la].in_standby = true; + + int ret = standby_resume_wakeup(node, me, la, interactive); + if (ret) + return ret; + node->remote[la].in_standby = false; + } + + return OK; +} + +static int standby_record_active_source(struct node *node, unsigned me, unsigned la, bool interactive) +{ + return standby_record(node, me, la, interactive, CEC_MSG_ACTIVE_SOURCE); +} + +static int standby_record_inactive_source(struct node *node, unsigned me, unsigned la, bool interactive) +{ + return standby_record(node, me, la, interactive, CEC_MSG_INACTIVE_SOURCE); +} + const vec_remote_subtests standby_resume_subtests{ { "Standby", CEC_LOG_ADDR_MASK_ALL, standby_resume_standby }, { "Repeated Standby message does not wake up", CEC_LOG_ADDR_MASK_ALL, standby_resume_standby_toggle }, @@ -697,4 +758,6 @@ const vec_remote_subtests standby_resume_subtests{ { "Power State Transitions", CEC_LOG_ADDR_MASK_TV, power_state_transitions, false, true }, { "Deck Eject Standby Resume", CEC_LOG_ADDR_MASK_PLAYBACK | CEC_LOG_ADDR_MASK_RECORD, standby_resume_wakeup_deck_eject }, { "Deck Play Standby Resume", CEC_LOG_ADDR_MASK_PLAYBACK | CEC_LOG_ADDR_MASK_RECORD, standby_resume_wakeup_deck_play }, + { "Record Standby Active Source", CEC_LOG_ADDR_MASK_RECORD | CEC_LOG_ADDR_MASK_BACKUP, standby_record_active_source }, + { "Record Standby Inactive Source", CEC_LOG_ADDR_MASK_RECORD | CEC_LOG_ADDR_MASK_BACKUP, standby_record_inactive_source }, }; diff --git a/utils/cec-follower/cec-follower.h b/utils/cec-follower/cec-follower.h index 589ea6bf..b4d7563f 100644 --- a/utils/cec-follower/cec-follower.h +++ b/utils/cec-follower/cec-follower.h @@ -54,6 +54,7 @@ struct state { __u8 deck_state; __u64 deck_skip_start; bool one_touch_record_on; + bool one_touch_record_standby; time_t toggle_power_status; __u64 last_aud_rate_rx_ts; }; @@ -229,5 +230,6 @@ void process_tuner_record_timer_msgs(struct node *node, struct cec_msg &msg, uns void reply_feature_abort(struct node *node, struct cec_msg *msg, __u8 reason = CEC_OP_ABORT_UNRECOGNIZED_OP); void testProcessing(struct node *node, bool wallclock); +bool enter_standby(struct node *node); #endif diff --git a/utils/cec-follower/cec-processing.cpp b/utils/cec-follower/cec-processing.cpp index f985a841..43e03878 100644 --- a/utils/cec-follower/cec-processing.cpp +++ b/utils/cec-follower/cec-processing.cpp @@ -157,7 +157,7 @@ static bool exit_standby(struct node *node) return false; } -static bool enter_standby(struct node *node) +bool enter_standby(struct node *node) { if (node->state.power_status == CEC_OP_POWER_STATUS_ON || node->state.power_status == CEC_OP_POWER_STATUS_TO_ON) { @@ -320,10 +320,14 @@ static void processMsg(struct node *node, struct cec_msg &msg, unsigned me, __u8 /* Standby */ case CEC_MSG_STANDBY: + /* Standby should not interrupt a recording in progress. */ + if (node->state.one_touch_record_on) { + node->state.one_touch_record_standby = true; + break; + } enter_standby(node); return; - /* One Touch Play and Routing Control */ case CEC_MSG_ACTIVE_SOURCE: { diff --git a/utils/cec-follower/cec-tuner.cpp b/utils/cec-follower/cec-tuner.cpp index 4ecb62a6..80b126ac 100644 --- a/utils/cec-follower/cec-tuner.cpp +++ b/utils/cec-follower/cec-tuner.cpp @@ -802,6 +802,15 @@ void process_tuner_record_timer_msgs(struct node *node, struct cec_msg &msg, uns cec_msg_set_reply_to(&msg, &msg); cec_msg_record_status(&msg, CEC_OP_RECORD_STATUS_TERMINATED_OK); transmit(node, &msg); + /* + * If standby was received during recording, enter standby when the recording is finished + * unless the recording device is the currently the active source. + */ + if (node->state.one_touch_record_standby) { + if (node->phys_addr != node->state.active_source_pa) + enter_standby(node); + node->state.one_touch_record_standby = false; + } node->state.one_touch_record_on = false; return; case CEC_MSG_RECORD_STATUS: -- 2.25.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-06-24 7:57 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-06-24 4:06 [PATCH v4 0/3] cec: One Touch Record tests Deborah Brouwer 2021-06-24 4:06 ` [PATCH v4 1/3] cec-follower: use log_addr_type to get local device type Deborah Brouwer 2021-06-24 4:06 ` [PATCH v4 2/3] cec: expand One Touch Record tests Deborah Brouwer 2021-06-24 7:57 ` Hans Verkuil 2021-06-24 4:06 ` [PATCH v4 3/3] cec: add One Touch Record Standby tests Deborah Brouwer
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox