From: Gergo Koteles <soyer@irl.hu>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
John Bauer <johnebgood@securitylive.com>,
ribalda@chromium.org, linh.tp.vu@gmail.com
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Gergo Koteles <soyer@irl.hu>
Subject: [PATCH v4 0/1] media: uvcvideo: UVC minimum relative pan/tilt/zoom speed fix
Date: Thu, 20 Jun 2024 01:05:12 +0200 [thread overview]
Message-ID: <cover.1718835633.git.soyer@irl.hu> (raw)
Hello,
I applied Ricardo's suggestion.
And I found a few ways to improve the style.
I've also added Ricardo's reviewed-by tag as these are just style changes.
---
Changes in v4:
- Based on Ricardo's suggestion, only query the min value in uvc_ctrl_set
if necessary
- Rename is_relative_ptz_ctrl function to uvc_ctrl_is_relative_ptz for
consistency
- Rename 'relative speed implementation' to 'relative PTZ controls' in
comments
- Fix indentation of comments
- Reduce the length of the new lines to 80
- Link to v3: https://lore.kernel.org/all/cover.1718726777.git.soyer@irl.hu/
Changes in v3:
- Based on Ricardo's suggestion, I squashed the two patches.
- Link to v2: https://lore.kernel.org/all/20240405-uvc-fix-relative-ptz-speed-v1-0-c32cdb2a899d@securitylive.com/
Changes in v2:
- Made recommended changes, moved control check to helper function and removed dead code.
- Link to v1: https://lore.kernel.org/all/20240326-uvc-relative-ptz-speed-fix-v1-1-453fd5ccfd37@securitylive.com/
---
John Bauer (1):
media: uvcvideo: UVC minimum relative pan/tilt/zoom speed fix.
drivers/media/usb/uvc/uvc_ctrl.c | 42 ++++++++++++++++++++++++++------
1 file changed, 35 insertions(+), 7 deletions(-)
--
2.45.2
Best regards,
Gergo Koteles
next reply other threads:[~2024-06-19 23:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 23:05 Gergo Koteles [this message]
2024-06-19 23:05 ` [PATCH v4 1/1] media: uvcvideo: UVC minimum relative pan/tilt/zoom speed fix Gergo Koteles
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1718835633.git.soyer@irl.hu \
--to=soyer@irl.hu \
--cc=johnebgood@securitylive.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linh.tp.vu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ribalda@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).