From: Sean Young <sean@mess.org>
To: linux-media@vger.kernel.org
Cc: Rik van Riel <riel@surriel.com>, Sean Young <sean@mess.org>,
bpf@vger.kernel.org
Subject: [PATCH v5 00/20] media: Fix locking issues in rc core
Date: Tue, 15 Sep 2026 09:32:10 +0100 [thread overview]
Message-ID: <cover.1789460680.git.sean@mess.org> (raw)
Fix issues found by Sashiko and claude, and other cleanups.
Changes since v4:
- Split keymap locking into two commits: one for krealloc rewrite
and one for the locking
- Fixed meson-ir-tx: Validate carrier and duty_cycle to actually
fix divide by zero
- Improved commit messages
- imon calls usb_driver_claim_interface() before using it
- Ensure lirc_unregister() is always called with registered = false
else any polling fds never get triggered
Changes since v3:
- serial_ir: Fix race condition where timer can be re-armed
This introduced a new race condition; reworked
- rc: After rc_unregister_device() timers can be re-armed
Sashiko suggested a simpler implementation with
timer_shutdown_sync()
- Add meson-ir-tx: Validate carrier and duty_cycle
- Add ir_toy: Validate the maximum tx carrier
Changes since v2:
- Cosmetic changes in: Add missing locking for keymap
- Patch 7 to 17 are new issues found
Changes since v1:
- Fix issue where input device was still leaked
- Add: Fix race between bpf(BPG_PROG_ATTACH) and device unregister
- Add: Fix inconsistent locking of keylock
Sean Young (20):
media: rc: Ensure registered is cleared in error path
media: rc: Ensure that rc_unregister_device() does not free input
device
media: rc: Fix ABBA deadlock by making locks more fine grained
media: rc: Replace open coded krealloc() for keymap
media: rc: Add missing locking for keymap
media: rc: Fix race between bpf(BPG_PROG_ATTACH) and device unregister
media: rc: mce_kbd: Fix inconsistent locking of keylock
media: ene_ir: Ensure teardown is done in the correct order
media: rc: Use binary search for adding or updating a scancode
media: rc: imon: Bind both interfaces via usb_driver_claim_interface()
media: ir_toy: Remove unused struct field
media: nuvoton-cir: Remove unused struct field
media: ite-cir: Removed unused struct field
media: fintek-cir: Remove unused fields
media: mceusb: Remove unused field
media: serial_ir: Fix race condition where timer can be re-armed
media: rc: After rc_unregister_device() timers can be re-armed
media: rc: Validate carrier range in LIRC_SET_REC_CARRIER ioctl
media: ir_toy: Validate the maximum tx carrier
media: meson-ir-tx: Prevent divide by zero in
meson_irtx_prepare_pulse()
drivers/media/rc/ene_ir.c | 4 +-
drivers/media/rc/fintek-cir.c | 13 --
drivers/media/rc/fintek-cir.h | 22 ---
drivers/media/rc/imon.c | 164 ++++++++++-------------
drivers/media/rc/ir-mce_kbd-decoder.c | 5 +-
drivers/media/rc/ir_toy.c | 4 +-
drivers/media/rc/ite-cir.c | 1 -
drivers/media/rc/ite-cir.h | 1 -
drivers/media/rc/lirc_dev.c | 2 +
drivers/media/rc/mceusb.c | 1 -
drivers/media/rc/meson-ir-tx.c | 3 +
drivers/media/rc/nuvoton-cir.h | 3 -
drivers/media/rc/rc-ir-raw.c | 39 +++---
drivers/media/rc/rc-loopback.c | 5 -
drivers/media/rc/rc-main.c | 186 ++++++++++++++++----------
drivers/media/rc/serial_ir.c | 2 +-
include/media/rc-map.h | 2 -
17 files changed, 222 insertions(+), 235 deletions(-)
--
2.55.0
next reply other threads:[~2026-09-15 8:33 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 8:32 Sean Young [this message]
2026-09-15 8:32 ` [PATCH v5 01/20] media: rc: Ensure registered is cleared in error path Sean Young
2026-09-15 8:32 ` [PATCH v5 02/20] media: rc: Ensure that rc_unregister_device() does not free input device Sean Young
2026-09-15 8:32 ` [PATCH v5 03/20] media: rc: Fix ABBA deadlock by making locks more fine grained Sean Young
2026-09-15 8:32 ` [PATCH v5 04/20] media: rc: Replace open coded krealloc() for keymap Sean Young
2026-09-15 13:07 ` Hans Verkuil
2026-09-15 14:56 ` Sean Young
2026-09-15 15:43 ` Sean Young
2026-09-22 11:22 ` Hans Verkuil
2026-09-15 8:32 ` [PATCH v5 05/20] media: rc: Add missing locking " Sean Young
2026-09-15 8:32 ` [PATCH v5 06/20] media: rc: Fix race between bpf(BPG_PROG_ATTACH) and device unregister Sean Young
2026-09-15 8:32 ` [PATCH v5 07/20] media: rc: mce_kbd: Fix inconsistent locking of keylock Sean Young
2026-09-15 8:32 ` [PATCH v5 08/20] media: ene_ir: Ensure teardown is done in the correct order Sean Young
2026-09-15 8:32 ` [PATCH v5 09/20] media: rc: Use binary search for adding or updating a scancode Sean Young
2026-09-15 8:32 ` [PATCH v5 10/20] media: rc: imon: Bind both interfaces via usb_driver_claim_interface() Sean Young
2026-09-15 8:32 ` [PATCH v5 11/20] media: ir_toy: Remove unused struct field Sean Young
2026-09-15 8:32 ` [PATCH v5 12/20] media: nuvoton-cir: " Sean Young
2026-09-15 8:32 ` [PATCH v5 13/20] media: ite-cir: Removed " Sean Young
2026-09-15 8:32 ` [PATCH v5 14/20] media: fintek-cir: Remove unused fields Sean Young
2026-09-15 8:32 ` [PATCH v5 15/20] media: mceusb: Remove unused field Sean Young
2026-09-15 8:32 ` [PATCH v5 16/20] media: serial_ir: Fix race condition where timer can be re-armed Sean Young
2026-09-15 8:32 ` [PATCH v5 17/20] media: rc: After rc_unregister_device() timers " Sean Young
2026-09-15 8:32 ` [PATCH v5 18/20] media: rc: Validate carrier range in LIRC_SET_REC_CARRIER ioctl Sean Young
2026-09-15 8:32 ` [PATCH v5 19/20] media: ir_toy: Validate the maximum tx carrier Sean Young
2026-09-15 8:32 ` [PATCH v5 20/20] media: meson-ir-tx: Prevent divide by zero in meson_irtx_prepare_pulse() Sean Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1789460680.git.sean@mess.org \
--to=sean@mess.org \
--cc=bpf@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=riel@surriel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox