From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE695C433E6 for ; Tue, 5 Jan 2021 16:38:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF1E022CB2 for ; Tue, 5 Jan 2021 16:38:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728962AbhAEQiV (ORCPT ); Tue, 5 Jan 2021 11:38:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728034AbhAEQiU (ORCPT ); Tue, 5 Jan 2021 11:38:20 -0500 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0007CC061795 for ; Tue, 5 Jan 2021 08:37:39 -0800 (PST) Received: by mail-ej1-x62b.google.com with SMTP id b9so978593ejy.0 for ; Tue, 05 Jan 2021 08:37:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YxrqGOviXXENBMTFnQaNw0YzxNVkM3/Q1q4WXI0EYHQ=; b=KDOX1ep38qZ8dUWYYzLkezJm1eTo8soZXvjYzxLoKQvcovcdK3dxz5upLrFMocGNS5 mnJ9UrK5sduyaScQyBbbRM9MRzZqbfULvcMg12yojaltlo3XQB4LgJ5KeAf1Lk/J32MD 7S2wzxjBNqJjSrnD1bc8RHTZHqfN+DQAhico+D2AnJNIaqR7wVi+jxaPrSpyGZskabr4 x3PEP8fCL1WNbotp01PNRpEmyzjql0PFc8la5fPqX6V5rBZEAbn/0ozJttk2gqrLhOiE Qh5tWzUQAmup/EfxAxS3OmAeyYDkPiGErZfrSFabgpXuGKu3r+H5t07f3hITtEOEfcTu KHYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YxrqGOviXXENBMTFnQaNw0YzxNVkM3/Q1q4WXI0EYHQ=; b=I73XELM8R2lgJs/NPhRvzaBBSaHuAbitL4SIheeO0hTGQxfM44Vj8tqcWNhOT5/rAT WewzZDY8XqWBufq1vcxm4NMFMupxeziMiT9VAz91n8/6KHtK4iOliT1oxOGnZsozC2cD Ni5Ajt8MGG2ynYw3jw9sGTdf0nsVR7AW6myVo54GEGltJ1i6byD+x0lmMcDUyqdMsvHn BZze4jFqjrqM57zQoydrZaQR2IMPmBTlTk7uMdL1TkRM2a7JcmactgS8znsyJNulNQ+L AXllX/40xstXvWjjfZ6Kj6hP1fUvUh3fswp3CXA2nM90Acrd9zin8HhxMKgj4i6ZIvsR C6EQ== X-Gm-Message-State: AOAM532JV1MCDcVuBJQ0qtZUpn8HNIfjrcu88O3rL9XagZGbMBhBU/n+ wCJMXoUe54eREzc7yITWPJM= X-Google-Smtp-Source: ABdhPJwf38ITG2e5EFnGArYRqGstTOW8IPED8comLApyjPqc4rgVwU6GzeB2fGxUC+B7TxrKdVGXZw== X-Received: by 2002:a17:907:2071:: with SMTP id qp17mr42972ejb.110.1609864658619; Tue, 05 Jan 2021 08:37:38 -0800 (PST) Received: from kontron.lan (2001-1ae9-1e8-b200-9c26-b1f7-3f54-fb94.ip6.tmcz.cz. [2001:1ae9:1e8:b200:9c26:b1f7:3f54:fb94]) by smtp.gmail.com with ESMTPSA id z1sm7648edm.89.2021.01.05.08.37.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Jan 2021 08:37:38 -0800 (PST) Subject: Re: [PATCH 1/6] media: mach-pxa: Register the camera sensor fixed-rate clock To: Ezequiel Garcia , linux-media@vger.kernel.org, Hans Verkuil Cc: kernel@collabora.com, Arnd Bergmann , Robert Jarzmik , Janusz Krzysztofik , Sakari Ailus References: <20210104165739.116404-1-ezequiel@collabora.com> <20210104165739.116404-2-ezequiel@collabora.com> From: Petr Cvek Message-ID: Date: Tue, 5 Jan 2021 17:41:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210104165739.116404-2-ezequiel@collabora.com> Content-Type: text/plain; charset=iso-8859-2 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Dne 04. 01. 21 v 17:57 Ezequiel Garcia napsal(a): > The pxa-camera capture driver currently registers a v4l2-clk > clock, named "mclk", to represent the mt9m111 sensor clock. > > Register a proper fixed-rate clock using the generic clock framework, > which will allow to remove the v4l2-clk clock in the pxa-camera > driver in a follow-up commit. > BTW the mclk output to a sensor is actually a variable rate, divided from lcdclk (which can be changed too). PXA camera driver is using variable pcdev->mclk_divisor to generate the mclk from lcdclk. The rate change is done in pxa_camera_activate(): https://elixir.bootlin.com/linux/v5.11-rc2/source/drivers/media/platform/pxa_camera.c#L1136 __raw_writel(pcdev->mclk_divisor | cicr4, pcdev->base + CICR4); Would it be possible to register a correct clock type with possibility to change the divisor by the standard way? Petr > Cc: Arnd Bergmann > Cc: Robert Jarzmik > Signed-off-by: Ezequiel Garcia > --- > arch/arm/mach-pxa/devices.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/mach-pxa/devices.c b/arch/arm/mach-pxa/devices.c > index 524d6093e0c7..09b8495f3fd9 100644 > --- a/arch/arm/mach-pxa/devices.c > +++ b/arch/arm/mach-pxa/devices.c > @@ -4,6 +4,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -634,6 +635,13 @@ static struct platform_device pxa27x_device_camera = { > > void __init pxa_set_camera_info(struct pxacamera_platform_data *info) > { > + struct clk *mclk; > + > + /* Register a fixed-rate clock for camera sensors. */ > + mclk = clk_register_fixed_rate(NULL, "pxa_camera_clk", NULL, 0, > + info->mclk_10khz * 10000); > + if (!IS_ERR(mclk)) > + clkdev_create(mclk, "mclk", NULL); > pxa_register_device(&pxa27x_device_camera, info); > } > >