From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68DA1329E7A for ; Tue, 16 Dec 2025 17:55:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765907722; cv=none; b=TWi/fOL+EAnJ/B2FEXKS1PBo9zYdatTg13HRHL/3DxQSyyTLaLAKYOvJdPSWl23q39Ncx6/9WqeMEl1nepZ3UxkV4r/P2IvtWA4hmybaQB2tZXRxBKrJcPdP2CUmb5piRk98iJPNsF7Mnq7KH3MTyfw81YhYBwGJOHLeJPtt1Kg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765907722; c=relaxed/simple; bh=x4KWC+YXPPYlvG8nC4wNEtsh1nWoGAXx2WIIqmKIgrk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lRBDAf/RfnpfVGJJk3bmf+ygZlLv8dwWw9DbzQX5uzAYrGZXGkpM76BUs/wlqhJSSN65wakfNGKuRDgQ5IKTbFI15joI5o6iaHI4j+hlRgi2ob++kg/p5YarPDQWS+3FSlr59wfGjEw0iZ8tNs5NxirU6tsQ7dua/mMus0rY5ME= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ikvA4rXW; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OoL5HTvv; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ikvA4rXW"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OoL5HTvv" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BGGmpbd275328 for ; Tue, 16 Dec 2025 17:55:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3tfz6XIdyU+B9sBPkIM0l3VvZslEO+bMthgxfNqZ1cQ=; b=ikvA4rXW0TmrT/Ft 89ocD7O0j0rxcqORi/5ICFV32ofGMXxMfBZHuj8W0mnBP6smduHfdBuIl+UNTDTU oKRv2XxsbtL0u/WSlAYVxQpH1CgqC+EEgFOlu9tnS2MQkfFSPKJvIPGtiiTPtPAq gpjhp4OhCLdKaceQR2BKUGwLGw9TC4HUA3qkTrErIKjHj4OC4NPE8E62we9PZfcG k7gpaAsg2PFf+yk3MqRHryz2MBK2Vx1M+q9moXV41XcET1CdA97YWwLzPX5yCyo8 25Mil/zTdoWKf9HvfIJ12u/EmJZpD4nO5MoI1fXRAgtHK/udbm24phLAgQ0NXQYt +Spp/g== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b35se1ks8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 16 Dec 2025 17:55:18 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-b6ce1b57b9cso5585863a12.1 for ; Tue, 16 Dec 2025 09:55:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765907717; x=1766512517; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3tfz6XIdyU+B9sBPkIM0l3VvZslEO+bMthgxfNqZ1cQ=; b=OoL5HTvvemD0DHEDF+7pRxcgwugsXQHpGgYE9r8kcPnN4QydfGwr/SRhBUZhG47U8h J+xCdT3m43VdzVK8QWJKip4zm6xo9E5b99Rp4lfPi2Wto4yZLDK94s9mM36ECMBZ4tju tvIgY9j5oikIZbWVfd30oeGDdjXeJY8WjQ741e7UfUoX7Pi9f0CZPL8OQee59E8diILz feoRU3vPLzPvbNmZtOZZ69w5m+21KOAwLqBDklNx5G7sprAgw/bEiF7S372S2fK4uJDX TXYJ3eXe3D3525Wv2MO0wUKBMGC3A6EmTVSCGiFpJhwSQH1CkUl8C+khK4BaXPdrqtTu HCVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765907717; x=1766512517; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3tfz6XIdyU+B9sBPkIM0l3VvZslEO+bMthgxfNqZ1cQ=; b=sdLIrvCfLEoxHvF5vPbmLXJsOLOb6hICEdgeAWF8LSiFbaJBRDFTTjzrnRhNPhKBkR QvbUFPnAvEKxUKqeIR4Y1+Js+20+VQN2i2U6Y2IQ38UMtXXD1+ATtBUarr744Ap38UxT FfuDcBwmU3ljBgUYQIPRM/M+XprZhdkAQDVuY+0ltowtwsK6McIM4TXcJaPdyzpYPshG CmB5ZeewI0D7jGs+AU8R5HLbkvSJrqdQp4xMee8BmFsehP2btEFV8lekTu4n7U/VtjUv CcE44YQbzqBItH9C2Kq74eQwXIR/jkQfgTAQWnqR/awbFnveNrPx0eLsbSK1ZByOmOZ5 34Vg== X-Forwarded-Encrypted: i=1; AJvYcCXjw0YjlMj4ZNaT5PELMj18ozE9t08GkFdRMVpvUxc+X5Aw2dBS4hgITdnJx3BFxV3WlOHVOC3Mmq9uDg==@vger.kernel.org X-Gm-Message-State: AOJu0YyPNAR0hfMSP+mdXSpBOIkUbNGjGxpUKueQxPMgit3VOhvZA+zR 4i17mIBBMbz5EjvBg0Eq3dKLLEm3q53thIyQQRmgZ8hxzEiHUjpEYXmEeao+kQwLf7N0D98kTKA s07eg/wqeCZXnzlwWrx2xcPPcMn3WePU7Xqfz0+oHK9Ni1zowfEA54trTAO0/2+FYPA== X-Gm-Gg: AY/fxX6rK+W3X/8TlFt969kyu04NLX0KBjpEoUhVRywf0D4csfNUpKu4Ivryv4DCbxD 6xBcDxBWk5ctAAuNoi5S+iZFRmrDISnD3nzV/idxpFqlnBUu62IznOa0xL61udV3sfpzCBL28dr KhP/34F3Val+R0O0tPu/IHtru7vn7XClak+bM8DE4jYs318sQS7++9NGkk1KHmsI1jmCUPzEo+h r9u+gq2ymrXMlJUkw/W/BsTKmUM1aI16tRQ/kneIYdlKwKvYnvMITBCEpI6VaTvHM5PgUwmQ+T1 5w/WhEZl2rcTmxnOmHBFaXrW+UCwg4lPlPpi2pA8rwq7snv+QDu5Uxr6KvV+gRDvYUDoDG+SHVq 11/DzKEyuayp2A1USDFgxliheEG7IgUVDD2v8XXhOG9c= X-Received: by 2002:a05:693c:60c6:b0:2ab:ca55:89ac with SMTP id 5a478bee46e88-2ac3014dd6emr8017857eec.43.1765907716873; Tue, 16 Dec 2025 09:55:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IHPrkV21G3iPc3ojGgR8o4nFvFrt1frL/UDjVG4xlLNNyF1bO0gpZ8qMANWvbUOVTVbC6bDUw== X-Received: by 2002:a05:693c:60c6:b0:2ab:ca55:89ac with SMTP id 5a478bee46e88-2ac3014dd6emr8017823eec.43.1765907716228; Tue, 16 Dec 2025 09:55:16 -0800 (PST) Received: from [172.20.10.12] ([172.56.242.71]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ae4f0544f0sm1362847eec.11.2025.12.16.09.55.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Dec 2025 09:55:15 -0800 (PST) Message-ID: Date: Tue, 16 Dec 2025 09:55:09 -0800 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/5] media: dt-bindings: Add CAMSS device for Kaanapali To: Vladimir Zapolskiy , Konrad Dybcio , Bryan O'Donoghue , Hangxiang Ma , Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com, Jingyi Wang , Atiya Kailany References: <20251113-add-support-for-camss-on-kaanapali-v6-0-1e6038785a8e@oss.qualcomm.com> <20251113-add-support-for-camss-on-kaanapali-v6-1-1e6038785a8e@oss.qualcomm.com> <37d0f89f-69be-45a7-90fa-347d6a3800bf@oss.qualcomm.com> <2d7ac7e8-ab69-44a6-b732-3657abf3a5a6@oss.qualcomm.com> Content-Language: en-US From: Vijay Kumar Tumati In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: tBP-wGKDs728OVxzZWWUWZgPTrC50uFT X-Authority-Analysis: v=2.4 cv=ar2/yCZV c=1 sm=1 tr=0 ts=69419d07 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=muPXiAMrSX0Fknvgm18zRg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=B8gxV9zDd2KAh-v8T-4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-GUID: tBP-wGKDs728OVxzZWWUWZgPTrC50uFT X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE2MDE1NCBTYWx0ZWRfX7up/rfH6IiYf 8rhBS4CpBiQF10LlOcha5BjtM8AiYFEA7typUguS1yOurNH1NjZ96+tQ1Q1hovbGziCUMPJJigP EMhMIevBazalNye9hRv5LBWa6DIoXZFCOYFrfvSYKS1C/eORfwfq/bcJsNyS0ws9TgqOGbTGqKf WgIqqBTHGhVLasCxVBshyoJPWgWFOby5BYMQLRHqJ5l1Hz5OfL9tVlZ0z+76xzI8dA+IWFn+gbG 8xamaqtAZpi+4aegfPTWiW9UncKNE+WBdbxflab/xQhIoRTI3gMXDNMTGXunK6Yl4PuKFBYXOtz 62FOUXR6CGRXvggS3Xibd+HdOx5Xcqws1eOz90ktFbi/p8WtpynfLv2dAWqqjyli8dPRsTO8ohQ QQbk4mdpnw91E6vjLB98LivD7AYLXA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-16_02,2025-12-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 suspectscore=0 adultscore=0 bulkscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512160154 On 12/12/2025 4:49 AM, Vladimir Zapolskiy wrote: > On 11/18/25 20:44, Konrad Dybcio wrote: >> On 11/18/25 7:25 PM, Vijay Kumar Tumati wrote: >>> >>> On 11/18/2025 7:00 AM, Bryan O'Donoghue wrote: >>>> On 14/11/2025 03:29, Hangxiang Ma wrote: >>>>> +                  <0x0 0x0900e000 0x0 0x1000>, >>>> >>>> Why aren't you starting @ 0x0900e000 ? seems to be omitting some of >>>> the registers in the ICP block. Should start at +0xd000 not +0xe000 ? >>>> >>>>> +                  <0x0 0x0902e000 0x0 0x1000>, >>>> >>>> Same here. >>> Hi Bryan, HLOS does not have access to those registers. They are >>> configured by the Hyp. >> >> If that's hyp, please add them. We already have platforms without >> Gunyah. Remember, bindings are defined once and for good and I wouldn't >> call it impossible that someone would want to run that configuration on >> Kaanapali some day >> > > If the ICP register block is added now, then it will practically exclude > an option to run hardware demosaic on Kaanapali. There were notorious > and still unresolved problems with CSIPHY blocks, which shall be split > from CSID/VFE CAMSS on device tree level also, for similar reasons the > same should be done with ICP or other blocks. It makes exactly zero > sense to pile everything into a monolythic device tree node, and doing > so undermines any future advances in CAMSS support in the upstream > Linux, the hardware description in downstream is done thoughtfully > better, > and not for no reason. > Hi Vladimir, yes, this has been discussed in the past and the general consensus from everyone is for not blocking KNP series on this. But yes, there is an ongoing effort to modularize the bindings for future chipsets and when it's ready, we can review, discuss and take it forward. As for your ICP concern, if you are referring to the Demosaic in OFE, I believe we might still be able to do it either with direct OFE config from CPU or using the firmware (preferred), given that we properly establish the shared memory and SID IOVA ranges for ICP, assuming that the load and authenticate will be taken care by Hyp or TZ. Please share your thoughts if I missed something. Hi Bryan, please feel free to add your thoughts. Thanks, Vijay.