From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E1AD195FCE for ; Thu, 5 Sep 2024 15:20:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725549653; cv=none; b=ZL8o6W38vNP5KZIG93rG9iiNz/GjIWZJ1d78YLifFyHEhjJq+xYP3bBiPvo7xl4IaBUs3B1qYfqQXKSafyjPYs39xFxQK5PuvKa1XyP+wRC/Hmxea0FqQ/cZAl+tyV4mUkTV9svAZs+VFsJ/5Eg/gspgj9NJn0O6KQ1Qs2srZjM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725549653; c=relaxed/simple; bh=07EZ2R2cvNPxkqgvwKm3BBDwp9JFfmM1EZaGxb9jQmg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nUroStW5FqcEYY7lt2rfHfcdkPCur26pR/yKCqXlw1Jv8kKp7bmd3H5tbhB/tlMnykkw2mpSr5hRL+eCF9nG4Xr1ckmOPms7glPKG1/iwvS7tLuAov6j+YIE4fbtC9wOz3aWq1NiRImGvqTdacvFVS1U7xghgm+ESF1GUBp53mc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fGAlNNJy; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fGAlNNJy" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-5356a0a56f4so150847e87.3 for ; Thu, 05 Sep 2024 08:20:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1725549650; x=1726154450; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nL4wK+XGBbbQRznJUjfP4Y3RXCynR/eSS+8QDOZLKvg=; b=fGAlNNJyBJ1/+pJF8+DNgLSF3tjMhpyegkXn0+/QtWOONPyFt/Nk35pF5i0nvRuVNU MXHJkBDzAIoSEO/FT6dbFKQidVIAbMW+UKA5LBPLrj5L6XbjdeRNmXYb1NBUGKaRNFoo TuorlYOy1zoh7tLczcfJzD3cquTbXQDpcTnNh6jKI3s1yj1byILZjmhdoXZXOBmbfqvx U1iKmM79F4og2Zu8iNVgA/AwVQv4vvWKKvipCjoEv3AHCLI4OBIAwJ3XUYBVX1JEnIXO WHwErcWJ36pMppbDtA2Jzoam2TvBtSvYB7SBlsis213z+MuhVA0mOLTxMcTUJoreaoxk eRKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725549650; x=1726154450; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nL4wK+XGBbbQRznJUjfP4Y3RXCynR/eSS+8QDOZLKvg=; b=a+wW9ZUDiVNj6NaQB6E0en2e19dhVcvo1UfVyQVdYhK4KvDR/lFF+zKIvWiKBV47SC c5TdiEkBXzosZnXoVPbc8z6VludJmPlrmrnzIy1lXCjtzawlV1otbhKp+pfpSpNxTKb3 nSJHXzYIDg+nXboCmqszkHBzJsjuYWc7QUKqsNXYaKn1nZzifzlrqrtZ3lAi298axxEq zaRFIqcKf9PBGgOXV3vzFetcVPLsGTVmIplk6LryRcUoQerzGHUntrbkdYsWOQXgIHzI V4xgtVQsn4qucCgFptvORx8kOXzv5IEhea06w6/EcqNzXHoUjRcMJnMgvDeI+PF0tXrO BsuA== X-Forwarded-Encrypted: i=1; AJvYcCUsZVZONKtcUcEWEKxljDxMqJhkgJZLdtbXlCRqA4z2LI8g/pS+sji5sc5s4s1A8lbDd6WEmIedIKEX0A==@vger.kernel.org X-Gm-Message-State: AOJu0YyJoDR1LbCXkM0jwJliKlJvFCwguugzM1kv9pDV/eF0yxepyCwL TA39B/DOjGZWtUOOzIlOWFD69GmR1/HQf3Lkp/6rR6kTeRXybgQPTb8YeW9HT44= X-Google-Smtp-Source: AGHT+IHcOrCnX5lCAxr8SDKciOEJ578H4NZioD2TasiDK34x6BAeibOAKn1lBxBpfh8Bw5KmvFnibQ== X-Received: by 2002:a05:6512:124f:b0:52c:def2:d8af with SMTP id 2adb3069b0e04-53546afcdc8mr8446487e87.4.1725549650228; Thu, 05 Sep 2024 08:20:50 -0700 (PDT) Received: from [192.168.1.4] (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53540827b28sm2619062e87.140.2024.09.05.08.20.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Sep 2024 08:20:49 -0700 (PDT) Message-ID: Date: Thu, 5 Sep 2024 18:20:48 +0300 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 07/13] dt-bindings: media: camss: Add qcom,sm8550-camss binding Content-Language: en-US To: Depeng Shao , rfoss@kernel.org, todor.too@gmail.com, bryan.odonoghue@linaro.org, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@quicinc.com, Yongsheng Li References: <20240812144131.369378-1-quic_depengs@quicinc.com> <20240812144131.369378-8-quic_depengs@quicinc.com> From: Vladimir Zapolskiy In-Reply-To: <20240812144131.369378-8-quic_depengs@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello Depeng. On 8/12/24 17:41, Depeng Shao wrote: > Add bindings for qcom,sm8550-camss in order to support the camera > subsystem for sm8550. > > Co-developed-by: Yongsheng Li > Signed-off-by: Yongsheng Li > Signed-off-by: Depeng Shao > + > + interrupts = , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + ; Please change all interrupt types to IRQ_TYPE_EDGE_RISING, this will match the type set by the camss driver itself, and I believe a rising edge interrupt here is correct. A similar change would be needed in the dts file change. > + > + interrupt-names = "csid0", > + "csid1", > + "csid2", > + "csid_lite0", > + "csid_lite1", > + "csiphy0", > + "csiphy1", > + "csiphy2", > + "csiphy3", > + "csiphy4", > + "csiphy5", > + "csiphy6", > + "csiphy7", > + "vfe0", > + "vfe1", > + "vfe2", > + "vfe_lite0", > + "vfe_lite1"; -- Best wishes, Vladimir