From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A2031A7AF7 for ; Thu, 3 Oct 2024 18:28:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=85.214.62.61 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727980091; cv=none; b=KxleA+UX3YY0E7/oQVpcigleUd9HIIP3ESqbhH/8ZgZCZW2XbtvCQHyT5uKHXYb961nRhez5DTN5Mom192iUxqJanZ6uqDUwNJTP4HYIj4RZaJ2WjAhLKRvrxP89RoHTAYJ+VqLxtTXMnJe+OVgOtLg9Uz5u+z6TqwIRRtqRFu8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727980091; c=relaxed/simple; bh=FDRx/Hsgjjg8F2a5fUE1ZV8UCVSlPb2t1pC6sc6KDtA=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=caFQRm2kzuIfFxmZ3ph7TVuKtnfRSOpTSot8goQOLwx6sYZISANFDxNtM1gCCI05pNf6sbJAaIHQygJ9fqElKo7xPtBxIuHfbqqWm0ZvoNVpRs4ARWzli9Vy+jNcgQZY+JYJ2fUoKA6avLp5JmQanGaTpUoD5KmuVwWf8zMzcIU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=denx.de; spf=pass smtp.mailfrom=denx.de; dkim=pass (2048-bit key) header.d=denx.de header.i=@denx.de header.b=mriC0vtC; arc=none smtp.client-ip=85.214.62.61 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=denx.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=denx.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=denx.de header.i=@denx.de header.b="mriC0vtC" Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id AE1E188E6C; Thu, 3 Oct 2024 20:28:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1727980088; bh=SYJioxRwBWMIIoiiEGds8K69V07MoZDKpAXV5ReILRg=; h=Date:Subject:To:References:From:In-Reply-To:From; b=mriC0vtC/71MsMMtsNfpGi4KEFvxofWpUKe+kQF+9uPkyAt4XmNAURhtP+kxYYndQ dF9tNCaAf01n51c3idSj1M5RImZpJiEb4mn/97euUMk9ZYcNUUIDerjtszLErKUkTg qVrXRuVY8KBaH2hWi7mOFSoYmmBpPX3Hs4ApoN/aenkqzwk9ywXTiEwoBUFwHdB8F3 /2F3/9wT0KN4ykFkWksWVqhFO89AkWARR+DTGmvD9241lW2XJrjM8qX0dL++oNzNmB o820UsD84Zs+1qdn1dLzdww5CCAW6/LXTMkTVOMuMjszsCPOrg0kJggW453Eb415Qx haoIOzvAcVHmg== Message-ID: Date: Thu, 3 Oct 2024 18:03:45 +0200 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] media: i2c: isl7998x: Enable VACTIVE and HDELAY shadow registers To: Michael Tretter , linux-media@vger.kernel.org, Mauro Carvalho Chehab , Pengutronix Kernel Team References: <20240713154242.107903-1-marex@denx.de> Content-Language: en-US From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 10/1/24 4:56 PM, Michael Tretter wrote: > On Sat, 13 Jul 2024 17:41:54 +0200, Marek Vasut wrote: >> The VACTIVE and HDELAY shadow registers must be enabled for per channel >> NTSC/PAL detection to work, enable them. > > I think the description is wrong as the change doesn't affect the > VACTIVE and HDELAY registers. The change sets the standard selection > register to auto detection to always trigger a standard detection during > initialization instead of defaulting to NTSC. querystd explicitly > triggers this behavior. It does, commit message fixed. > If the driver always runs standard detection during init, the driver > should also wait for the detection to be finished and update > isl7998x->norm accordingly, because otherwise the standard will be reset > to NTSC. > > Maybe we can also get rid of this part from the init sequence and run > the standard detection during the initialization in code? Maybe the init sequence is OK as-is and this and the follow up patches should be discarded ? Users can run QUERYSTD to trigger the standard detection when needed ?