Re: [RFC v5 07/15] media: uapi: Add V4L2_CID_COLOUR_PATTERN for describing colour patterns

Sakari Ailus
2025-02-10T14:37:26Z

Hi Hans,

On Mon, Feb 10, 2025 at 09:57:08AM +0100, Hans Verkuil wrote:
> Hi Sakari,
>
> On 03/02/2025 09:58, Sakari Ailus wrote:
> > Add V4L2_CID_COLOUR_PATTERN to tell the camera sensor's native colour
> > pattern.
> >
> > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > ---
> > .../userspace-api/media/v4l/ext-ctrls-image-source.rst | 10 ++++++++++
> > drivers/media/v4l2-core/v4l2-ctrls-defs.c | 1 +
> > include/uapi/linux/v4l2-controls.h | 6 ++++++
> > 3 files changed, 17 insertions(+)
> >
> > diff --git a/Documentation/userspace-api/media/v4l/ext-ctrls-image-source.rst b/Documentation/userspace-api/media/v4l/ext-ctrls-image-source.rst
> > index 71f23f131f97..fca729512b6f 100644
> > --- a/Documentation/userspace-api/media/v4l/ext-ctrls-image-source.rst
> > +++ b/Documentation/userspace-api/media/v4l/ext-ctrls-image-source.rst
> > @@ -92,3 +92,13 @@ Image Source Control IDs
> > representing a gain of exactly 1.0. For example, if this default value
> > is reported as being (say) 128, then a value of 192 would represent
> > a gain of exactly 1.5.
> > +
> > +``V4L2_CID_COLOUR_PATTERN (integer)``
>
> Please use 'COLOR' instead of 'COLOUR' to be consistent with other color related
> control names. So do a search-and-replace for this in code and documentation.

Ack, I'll address this in v6.

--
Regards,

Sakari Ailus