From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C719C433EF for ; Thu, 18 Nov 2021 09:05:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 21B9161B3E for ; Thu, 18 Nov 2021 09:05:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245052AbhKRJIj (ORCPT ); Thu, 18 Nov 2021 04:08:39 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:54824 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245035AbhKRJHG (ORCPT ); Thu, 18 Nov 2021 04:07:06 -0500 Received: from [192.168.1.111] (91-158-153-130.elisa-laajakaista.fi [91.158.153.130]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9E65A3E5; Thu, 18 Nov 2021 10:04:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1637226243; bh=DptNEe2h55b55OdbxaqfAM8iSBD39sc6E1EE7axOZFE=; h=To:Cc:References:From:Subject:Date:In-Reply-To:From; b=vN8tsJJ2pk+QWHBv/Panw+l0xyZUatQI/IiNlUjrHzmVql4QSZMmGwDvniMkWEde4 1/1bY6pZ/Gu+99cKPe0SCG9vuZDx/cvcor8Hu06E8AwWkEHO0FzuN5fzn6atQLscg1 LNz0S3VmcaMZAWRQqjq/78vbGSvWlh4oHS/hWj8w= To: Ariel D'Alessandro , linux-media@vger.kernel.org Cc: hverkuil@xs4all.nl, sean@mess.org, p.zabel@pengutronix.de, laurent.pinchart@ideasonboard.com, ezequiel@collabora.com, nicolas@ndufresne.ca, kieran.bingham@ideasonboard.com, gjasny@googlemail.com, xavier.claessens@collabora.com, nicolas.dufresne@collabora.com, user.vdr@gmail.com, sakari.ailus@iki.fi, mchehab+huawei@kernel.org, rosenp@gmail.com References: <20210512184946.102863-1-ariel.dalessandro@collabora.com> From: Tomi Valkeinen Subject: Re: [v4l-utils v5 0/5] Add support for meson building Message-ID: Date: Thu, 18 Nov 2021 11:03:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20210512184946.102863-1-ariel.dalessandro@collabora.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi, On 12/05/2021 21:49, Ariel D'Alessandro wrote: > Hi all, > > Another attempt to support meson build, addressing comments/fixes from > reviewers. > > This patchset was developed on top of v4l-utils current master branch: > > commit f0c7e3d71eaf4182bae7eb3ee0e43b4eeb047ea9 > Author: Hans Verkuil > > v4l2-ctl: add '--set-edid type=list' support > > You can find the patchset pushed to the following branch: > > https://gitlab.collabora.com/adalessandro/v4l-utils/-/tree/v4l-utils-meson-v5 > > Feedback appreciated as always :-) I was testing this (well, I'm using it, as I can't get the autoconf work with cross-compilation..), and I see this problem if gconv is enabled when cross-compiling for arm (buildroot system): [1/2] Linking target contrib/gconv/EN300-468-TAB00.so FAILED: contrib/gconv/EN300-468-TAB00.so /home/tomba/work/buildroot/output32/host/bin/arm-buildroot-linux-gnueabihf-gcc -o contrib/gconv/EN300-468-TAB00.so contrib/gconv/EN300-468-TAB00.so.p/en300-468-tab00.c.o -Wl,--as-needed -Wl,--allow-shlib-undefined -shared -fPIC -Wl,-rpath,/usr/lib/x86_64-linux-gnu/gconv -Wl,-rpath-link,/usr/lib/x86_64-linux-gnu/gconv -Wl,--start-group /usr/lib/x86_64-linux-gnu/gconv/libJIS.so /usr/lib/x86_64-linux-gnu/gconv/libJISX0213.so -Wl,--end-group /usr/lib/x86_64-linux-gnu/gconv/libJIS.so: file not recognized: file format not recognized collect2: error: ld returned 1 exit status [2/2] Linking target contrib/gconv/ARIB-STD-B24.so FAILED: contrib/gconv/ARIB-STD-B24.so /home/tomba/work/buildroot/output32/host/bin/arm-buildroot-linux-gnueabihf-gcc -o contrib/gconv/ARIB-STD-B24.so contrib/gconv/ARIB-STD-B24.so.p/arib-std-b24.c.o -Wl,--as-needed -Wl,--allow-shlib-undefined -shared -fPIC -Wl,-rpath,/usr/lib/x86_64-linux-gnu/gconv -Wl,-rpath-link,/usr/lib/x86_64-linux-gnu/gconv -Wl,--start-group /usr/lib/x86_64-linux-gnu/gconv/libJIS.so /usr/lib/x86_64-linux-gnu/gconv/libJISX0213.so -Wl,--end-group /usr/lib/x86_64-linux-gnu/gconv/libJIS.so: file not recognized: file format not recognized Also, would this be better, to be a bit more explicit: - '-I.', # Needed for config.h + '-I' + meson.global_build_root(), # Needed for config.h I would do the same to other ".." paths too, but maybe that's just a personal preference: -Icontrib/test/v4l2gl.p -Icontrib/test -I../contrib/test -I../lib/include -I../include -I. I also wonder what the "-Icontrib/test" is for. I also see a problem when cross-compiling where a wrong config.h is included. When compiling with buildroot env, valgrind include dir is in the include paths. And valgrind has a "config.h" there... It would be safer to have the "-I." common flag before all the rest of the parameters, instead of being after all the others, but I didn't immediately find out how to do that with meson. Tomi