Linux Media Controller development
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Paweł Anikiel" <pan@semihalf.com>, "Conor Dooley" <conor@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-media@vger.kernel.org, dinguyen@kernel.org,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, mchehab@kernel.org, upstream@semihalf.com,
	amstan@chromium.org, ribalda@chromium.org
Subject: Re: [RFC PATCH 3/3] ARM: dts: Add Chameleon v3 video node
Date: Mon, 3 Jul 2023 14:33:10 +0200	[thread overview]
Message-ID: <df7440e2-58b0-9f12-8f37-4f0d9050f934@linaro.org> (raw)
In-Reply-To: <CAF9_jYT1Fz4hBQrNtgkM6mU-JVH=ZxsJnkaLDsa5uoEV_hTLVA@mail.gmail.com>

On 03/07/2023 13:44, Paweł Anikiel wrote:
>>> diff --git a/arch/arm/boot/dts/intel/socfpga/socfpga_arria10_chameleonv3.dts b/arch/arm/boot/dts/intel/socfpga/socfpga_arria10_chameleonv3.dts
>>> index 422d00cd4c74..5e66363d4ab5 100644
>>> --- a/arch/arm/boot/dts/intel/socfpga/socfpga_arria10_chameleonv3.dts
>>> +++ b/arch/arm/boot/dts/intel/socfpga/socfpga_arria10_chameleonv3.dts
>>> @@ -10,6 +10,60 @@ / {
>>>       compatible = "google,chameleon-v3", "enclustra,mercury-aa1",
>>>                    "altr,socfpga-arria10", "altr,socfpga";
>>>
>>> +     soc {
>>> +             video@c0060500 {
>>> +                     compatible = "google,chv3-video";
>>
>> This compatible does not seem to be documented & I did not see a comment
>> about the lack of a binding in the cover letter. What am I missing?
> 
> Yes, the compatible is not documented for now (I'll do that in a later
> patchset), sorry for not mentioning that in the cover letter.

You cannot add undocumented compatible. This cannot be fixed in "a later
patchset".

Best regards,
Krzysztof


  reply	other threads:[~2023-07-03 12:33 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-30 14:40 [RFC PATCH 0/3] Google Chameleon v3 video driver Paweł Anikiel
2023-06-30 14:40 ` [RFC PATCH 1/3] media: Add 10, 12, and 16 bit RGB formats Paweł Anikiel
2023-07-07 18:34   ` Nicolas Dufresne
2023-09-06 10:37   ` Hans Verkuil
2023-06-30 14:40 ` [RFC PATCH 2/3] media: Add Google Chameleon v3 video driver Paweł Anikiel
2023-09-06 11:14   ` Hans Verkuil
2023-09-06 16:27     ` Paweł Anikiel
2023-09-07  7:47       ` Hans Verkuil
2023-06-30 14:40 ` [RFC PATCH 3/3] ARM: dts: Add Chameleon v3 video node Paweł Anikiel
2023-06-30 18:25   ` Conor Dooley
2023-07-03 11:44     ` Paweł Anikiel
2023-07-03 12:33       ` Krzysztof Kozlowski [this message]
2023-07-04 16:16         ` Paweł Anikiel
2023-07-04 16:23           ` Krzysztof Kozlowski
2023-07-04 16:27             ` Conor Dooley
2023-07-05 14:45 ` [RFC PATCH 0/3] Google Chameleon v3 video driver Alexandru M Stan
2023-09-06 11:15 ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df7440e2-58b0-9f12-8f37-4f0d9050f934@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=amstan@chromium.org \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dinguyen@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=pan@semihalf.com \
    --cc=ribalda@chromium.org \
    --cc=robh+dt@kernel.org \
    --cc=upstream@semihalf.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox