From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FB2122F77F for ; Mon, 23 Jun 2025 09:26:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750670795; cv=none; b=AnUve8YIIao2bjXWOV6Bf4G7HngoEDZx2Q4Hz/x9X7DNDiqd/k38Wn0vYKyIR+CY3IHOzTK326eokMB9RgT1BWBU/LNgmOhbCvezDCdqX3U7m42YtFn5xD3jSkuFc1+50CgsdKrJ1EGk8OnXuwqCkeatlQiODdLKJDg0iw2qB6U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750670795; c=relaxed/simple; bh=xtUyqMFV83fTFQBF+WMWiz2UvH3RGoxUAJ5qhkmGkgU=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=kT9tbcZruTcXUnIP9WzxWWDgBmO6JSeoOVsjru476lRUZ9MsGdSNuYQVDAJAadIwBClvns7Jw9WpEeliyDiEfhll413wG2461Ox0rXp8IA3KicIqA3qeV9+KbCC5Sr2hrAM7WtFPuSXhiC2N04kRceKaMvcYakP9AnVUYj4qX7M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=P6Nklvny; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="P6Nklvny" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-450ce3a2dd5so37643585e9.3 for ; Mon, 23 Jun 2025 02:26:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750670792; x=1751275592; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=X21lnlJPbDK4NppSEK68ujExR0n2cpS3qgLeA8C+iTg=; b=P6NklvnyCcnF0xy4FOxNUmG0Ifzgnd72NlU/WM3sp3u+Klh7W6Ksz8MGQgsnc5iCPK aINuti2SqsZDffvDx5uBlAE8raAsLWONX8NYVhi3AqQXXk9qBbDk4HGtEYCmKmoUcjDG lq6lUsc2+pWC6/UnP6f1Lcspd3e7ZToTlNiCHMtpLqB7gtYfTUg44Us0Ny7t38JBVnh8 LaQ1kZgBO9z5GuFIq8GU4TsJtvL0LkWbTcZ9+i8QL7VYTJI8kbwzexB86UXu/FYHR7VA YA+bd0KT/XCsqf1XJQrKa3GJ+P7XH8DCgIo9nRZ4/x3ELFMcrnfoUP7cqdjHmnzfKYQv Swog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750670792; x=1751275592; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=X21lnlJPbDK4NppSEK68ujExR0n2cpS3qgLeA8C+iTg=; b=DzBb819mOC1eikOFA76WiZjVbhUcXhnDtggzuC8ccIsGIizycodalp0rSAEpNg71QX QJrVhvAe/e8Pf6833A07VF0Uug2Tra77JyPYmwKj99Z73sKk9Tp5xbwdn9ofMYkyFD7k E7VHwuCA5zJv38zit76N/YwsVwIsg3SLIfX2d+8UyLyL+BSQJLLudXmKi+t/qCcjsZW7 n6JNNNoelmUsGgDbt1rPfHahGMSQFme9U3wmHsfecLlAy6jqtsS2cW8kl/+ZA+ZXUnfU GtrF+Zr1ejIP5uBsAzy/rAkjOHpF3nxUe/s7s5BwS0+FcfSgK/fveysUUPjXBlLsnakc 6yow== X-Gm-Message-State: AOJu0YyqDaS1sRTwV3DExHyaZPlFtiLxq36Kl1snc3ki3Kx8fB+meaUe 0RQFC5yV5L2YSc7lA5Na4e+bv6IZbOaMMSxFbmEMtYaO2Uh//jJeDGBD1sg/bseIK8E1fdaUG+B OgW3phjQ= X-Gm-Gg: ASbGncu5/4gu5YO0zALXlJf7+X48MfKEnBajICkiEETsgb8w1lxQhKCZOwKUGiiasjD gOsfDqlkY+9DH3KbgQTbTBAf1ywrHZsrM5j3ZdvU0ll9fEiCJV5VPnxH7M0bbaFvr0S4/EQU2ny r0TIMP8URnGutMyyUzv5jz/Nf/6d/9H8xDyWj81kBc32V4QbZ5LOpm4wwF2MxoPxHnwp9+GJpI0 /v1lQ0WOrUMRBrLY/vvYY6OuxLARzqNzrSS2lQ/TrmIikd4CxJMo6c0vCbFp4UpynyF2J+f6ddQ vt/obxlvLnJ3l42Tj0FYRQ2/1v6mEAx7Fz+bH0DzJ2WtssB1w3nnxAVeVyc8mBiKwHfWsoCDxSr HefAoW5mfRvtmfTRAC6dBMA1QdCp8xNaTqHtcDW2nV9UxbOVTgw== X-Google-Smtp-Source: AGHT+IGMCQ2ZGbiUxUdbBOCEAWG6EmdQjuiVRNOyZjUlYiahyPCL5XapfPJY1qYD9YRtPLuo9lXxWA== X-Received: by 2002:a05:600c:c10b:b0:453:483b:626c with SMTP id 5b1f17b1804b1-453660bf3f8mr68932685e9.23.1750670791982; Mon, 23 Jun 2025 02:26:31 -0700 (PDT) Received: from ?IPV6:2a01:e0a:3d9:2080:8c08:7c51:bbb1:5a2d? ([2a01:e0a:3d9:2080:8c08:7c51:bbb1:5a2d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6d0f1012bsm8972255f8f.5.2025.06.23.02.26.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jun 2025 02:26:31 -0700 (PDT) Message-ID: Date: Mon, 23 Jun 2025 11:26:31 +0200 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Reply-To: Neil Armstrong Subject: Re: [PATCH 5/9] media: qcom: camss: unconditionally set async notifier of subdevices To: Vladimir Zapolskiy , Robert Foss , Todor Tomov , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> <20250513142353.2572563-6-vladimir.zapolskiy@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20250513142353.2572563-6-vladimir.zapolskiy@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13/05/2025 16:23, Vladimir Zapolskiy wrote: > For sake of simplicity it makes sense to register async notifier > for all type of subdevices, both CAMSS components and sensors. > > The case of sensors not connected to CAMSS is extraordinary and > degenerate, it does not deserve any specific optimization. Could you describe the difference on behavior in this case ? and how it's still valid ? Neil > > Signed-off-by: Vladimir Zapolskiy > --- > drivers/media/platform/qcom/camss/camss.c | 30 ++++++----------------- > 1 file changed, 8 insertions(+), 22 deletions(-) > > diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c > index 976b70cc6d6a..4e91e4b6ef52 100644 > --- a/drivers/media/platform/qcom/camss/camss.c > +++ b/drivers/media/platform/qcom/camss/camss.c > @@ -3556,7 +3556,6 @@ static int camss_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > struct camss *camss; > - int num_subdevs; > int ret; > > camss = devm_kzalloc(dev, sizeof(*camss), GFP_KERNEL); > @@ -3627,11 +3626,9 @@ static int camss_probe(struct platform_device *pdev) > > pm_runtime_enable(dev); > > - num_subdevs = camss_of_parse_ports(camss); > - if (num_subdevs < 0) { > - ret = num_subdevs; > + ret = camss_of_parse_ports(camss); > + if (ret < 0) > goto err_v4l2_device_unregister; > - } > > ret = camss_register_entities(camss); > if (ret < 0) > @@ -3647,23 +3644,12 @@ static int camss_probe(struct platform_device *pdev) > goto err_register_subdevs; > } > > - if (num_subdevs) { > - camss->notifier.ops = &camss_subdev_notifier_ops; > - > - ret = v4l2_async_nf_register(&camss->notifier); > - if (ret) { > - dev_err(dev, > - "Failed to register async subdev nodes: %d\n", > - ret); > - goto err_media_device_unregister; > - } > - } else { > - ret = v4l2_device_register_subdev_nodes(&camss->v4l2_dev); > - if (ret < 0) { > - dev_err(dev, "Failed to register subdev nodes: %d\n", > - ret); > - goto err_media_device_unregister; > - } > + camss->notifier.ops = &camss_subdev_notifier_ops; > + ret = v4l2_async_nf_register(&camss->notifier); > + if (ret) { > + dev_err(dev, > + "Failed to register async subdev nodes: %d\n", ret); > + goto err_media_device_unregister; > } > > return 0;