linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dikshita Agarwal <quic_dikshita@quicinc.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Vikash Garodia <quic_vgarodia@quicinc.com>,
	Abhinav Kumar <abhinav.kumar@linux.dev>,
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] media: dt-bindings: qcom,sm8550-iris: Add SM8750 video codec
Date: Tue, 12 Aug 2025 10:04:48 +0200	[thread overview]
Message-ID: <e33a22ba-f82a-412a-b1fd-d1cd50f6b21d@kernel.org> (raw)
In-Reply-To: <8d8dcaef-eb96-4e7b-9a0a-8b3836cb284c@kernel.org>

On 12/08/2025 10:00, Krzysztof Kozlowski wrote:
> On 12/08/2025 09:54, Dikshita Agarwal wrote:
>>
>>
>> On 8/4/2025 7:07 PM, Krzysztof Kozlowski wrote:
>>> Add binding for Qualcom SM8750 Iris video codec, which comes with
>>> significantly different powering up sequence than previous SM8650, thus
>>> different clocks and resets.  For consistency keep existing clock and
>>> clock-names naming, so the list shares common part.
>>>
>>> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> ---
>>>  .../bindings/media/qcom,sm8750-iris.yaml           | 186 +++++++++++++++++++++
>>>  1 file changed, 186 insertions(+)
>>>
>>
>> Query:
>> Can the additional reset and clocks be accommodated in existing 8550-iris
> 
> No, different hardware. Although it is hardware from your domain and
> your company, so I would assume you know the answer.
I guess I misread - I thought you want to re-use existing properties or
something like that, but you just want to create one huge binding?

No. Don't grow these unmaintainable patterns. We have been changing this
for some time already :/

Best regards,
Krzysztof

  reply	other threads:[~2025-08-12  8:04 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-04 13:37 [PATCH v2 0/3] media: iris: Add support for SM8750 (VPU v3.5) Krzysztof Kozlowski
2025-08-04 13:37 ` [PATCH v2 1/3] media: dt-bindings: qcom,sm8550-iris: Add SM8750 video codec Krzysztof Kozlowski
2025-08-12  7:54   ` Dikshita Agarwal
2025-08-12  8:00     ` Krzysztof Kozlowski
2025-08-12  8:04       ` Krzysztof Kozlowski [this message]
2025-08-13 21:15         ` Bryan O'Donoghue
2025-08-14  4:26           ` Dikshita Agarwal
2025-08-14  5:58           ` Krzysztof Kozlowski
2025-08-04 13:37 ` [PATCH v2 2/3] media: iris: Split power on per variants Krzysztof Kozlowski
2025-08-12  7:55   ` Dikshita Agarwal
2025-08-04 13:37 ` [PATCH v2 3/3] media: iris: Add support for SM8750 (VPU v3.5) Krzysztof Kozlowski
2025-08-12  8:05   ` Dikshita Agarwal
2025-08-12  8:16     ` Krzysztof Kozlowski
2025-08-28 13:18       ` Krzysztof Kozlowski
2025-08-12  7:52 ` [PATCH v2 0/3] " Dikshita Agarwal
2025-08-12  7:59   ` Krzysztof Kozlowski
2025-08-12  9:28     ` Dikshita Agarwal
2025-08-12  9:36       ` Krzysztof Kozlowski
2025-08-12  9:40         ` Dikshita Agarwal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e33a22ba-f82a-412a-b1fd-d1cd50f6b21d@kernel.org \
    --to=krzk@kernel.org \
    --cc=abhinav.kumar@linux.dev \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=quic_dikshita@quicinc.com \
    --cc=quic_vgarodia@quicinc.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).