From: Markus Elfring <Markus.Elfring@web.de>
To: Wenyuan Li <2063309626@qq.com>,
linux-media@vger.kernel.org, Andy Walls <awalls@md.metrocast.net>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
gszhai@bjtu.edu.cn, 23120469@bjtu.edu.cn, 25125332@bjtu.edu.cn,
25125283@bjtu.edu.cn
Subject: Re: [PATCH] media: ir-i2c: add error handling for I2C send in get_key_adaptec()
Date: Tue, 24 Mar 2026 13:21:42 +0100 [thread overview]
Message-ID: <e3b57c7f-67d8-4d35-bdd7-3d1b05a1f31b@web.de> (raw)
In-Reply-To: <tencent_FF07F161B5E002ECD9C7E2A9E2BD08B51B05@qq.com>
> In get_key_adaptec(), a command byte (0x00) is sent to the IR chip via
> i2c_master_send() to initiate a key read. However, the return value of
> i2c_master_send() is not checked.
How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
See also:
* https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.0-rc5#n145
* https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/stable-kernel-rules.rst?h=v7.0-rc5#n34
…
> If the send fails, return 0 to maintain the existing behavior (no key
> detected), but log the error for debugging purposes.
Will such a technical aspect be reconsidered in more detail?
Regards,
Markus
prev parent reply other threads:[~2026-03-24 12:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 10:43 [PATCH] media: ir-i2c: add error handling for I2C send in get_key_adaptec() Wenyuan Li
2026-03-24 12:21 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3b57c7f-67d8-4d35-bdd7-3d1b05a1f31b@web.de \
--to=markus.elfring@web.de \
--cc=2063309626@qq.com \
--cc=23120469@bjtu.edu.cn \
--cc=25125283@bjtu.edu.cn \
--cc=25125332@bjtu.edu.cn \
--cc=awalls@md.metrocast.net \
--cc=gszhai@bjtu.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox