From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49562C47257 for ; Mon, 4 May 2020 18:01:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3423620707 for ; Mon, 4 May 2020 18:01:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731198AbgEDSBk (ORCPT ); Mon, 4 May 2020 14:01:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1731196AbgEDSBk (ORCPT ); Mon, 4 May 2020 14:01:40 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2274C061A0E; Mon, 4 May 2020 11:01:39 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: nicolas) with ESMTPSA id 73E842A0458 Message-ID: Subject: Re: [PATCH v2 2/3] media: uapi: Add VP9 stateless decoder controls From: Nicolas Dufresne Reply-To: Nicolas Dufresne To: Ezequiel Garcia , Boris Brezillon Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Tomasz Figa , kernel@collabora.com, Jonas Karlman , Heiko Stuebner , Alexandre Courbot , Jeffrey Kardatzke Date: Mon, 04 May 2020 14:01:32 -0400 In-Reply-To: References: <20200410115113.31728-1-ezequiel@collabora.com> <20200410115113.31728-3-ezequiel@collabora.com> <9126475c-275d-71ab-0308-6ae85e22446b@xs4all.nl> <20200502203707.402ea3cd@collabora.com> Organization: Collabora Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-OSiYpnCOHGwM5bzGy/T7" User-Agent: Evolution 3.36.1 (3.36.1-1.fc32) MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org --=-OSiYpnCOHGwM5bzGy/T7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Le samedi 02 mai 2020 =C3=A0 19:55 -0300, Ezequiel Garcia a =C3=A9crit : > +Nicolas >=20 > On Sat, 2020-05-02 at 20:37 +0200, Boris Brezillon wrote: > > On Fri, 01 May 2020 13:57:49 -0300 > > Ezequiel Garcia wrote: > >=20 > > > > > + > > > > > +.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}| > > > > > + > > > > > +.. flat-table:: enum v4l2_vp9_reset_frame_context > > > > > + :header-rows: 0 > > > > > + :stub-columns: 0 > > > > > + :widths: 1 2 > > > > > + > > > > > + * - ``V4L2_VP9_RESET_FRAME_CTX_NONE`` > > > > > + - Do not reset any frame context. > > > > > + * - ``V4L2_VP9_RESET_FRAME_CTX_NONE_ALT`` > > > > > + - Do not reset any frame context. This is an alternative v= alue for > > > > > + V4L2_VP9_RESET_FRAME_CTX_NONE. =20 > > > >=20 > > > > Add `` around V4L2_VP9_RESET_FRAME_CTX_NONE. > > > > =20 > > >=20 > > > Hm, now that I look closer, what's the point > > > of having the NONE_ALT in our uAPI if it > > > has same meaning as NONE? > > >=20 > > > I think it can be removed. > >=20 > > The intent was to match the spec so that one can pass the value > > extracted from the bitstream directly. reset_frame_contextspecifies whether the frame context should be reset to default values: =E2=88=92 0 or 1 means do not reset any frame context =E2=88=92 2 resets just the context specified in the frame header =E2=88=92 3 resets all cont But aren't we going too far by making this an emum ? In Microsfot DXVA, we pass that value without interpreting it in userspace. For the following RKVDEC, it is (suspiciously ?) ignored. Maybe just passing over the value would make more sense, less work ? > >=20 > > > > I got several smatch warnings: > > > >=20 > > > > smatch: ERRORS > > > > drivers/media/v4l2-core/v4l2-ctrls.c:1880 validate_vp9_frame_decode= _params() warn: was && intended here instead of ||? > > > >=20 > > > > (Commented on this ^^^ one above) > > > >=20 > > > > drivers/staging/media/rkvdec/rkvdec-vp9.c:426 init_intra_only_probs= () error: buffer overflow 'ptr' 9 <=3D 69 > > > > drivers/staging/media/rkvdec/rkvdec-vp9.c:1478 rkvdec_vp9_done() er= ror: potentially dereferencing uninitialized 'ctrl'. > > > > drivers/staging/media/rkvdec/rkvdec-vp9.c:1483 rkvdec_vp9_done() er= ror: uninitialized symbol 'dec_dst_buf'. > > > > drivers/staging/media/rkvdec/rkvdec-vp9.c:941:6: warning: variable = 'ret' set but not used [-Wunused-but-set-variable] > > > > drivers/staging/media/rkvdec/rkvdec-vp9.c:1466:40: warning: variabl= e 'fctx' set but not used [-Wunused-but-set-variable] > > > > =20 > > >=20 > > > Oh, I'll run smatch and fix them all. > >=20 > > Oops! >=20 >=20 --=-OSiYpnCOHGwM5bzGy/T7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQSScpfJiL+hb5vvd45xUwItrAaoHAUCXrBYfAAKCRBxUwItrAao HEl0AKCsffGNkgR8IRMvRvpqEdfuIJofVACgwecGH6S4+u9ily9wRCE4jpdn++E= =ONvy -----END PGP SIGNATURE----- --=-OSiYpnCOHGwM5bzGy/T7--