Re: [PATCH 1/3] media: dt-bindings: Add description of OmniVision OG01A1B image sensor

[Krzysztof Kozlowski <krzk@kernel.org>]

On 20/06/2024 14:47, Vladimir Zapolskiy wrote:
> Add device tree bindings documentation for OmniVision OG01A1B image
> sensor.
> 
> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>


> +
> +maintainers:
> +  - Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
> +
> +description: |-

Do not need '|-' unless you need to preserve formatting.


> +  The OmniVision OG01A1B is black and white CMOS 1.3 Megapixel (1280x1024)
> +  image sensor controlled over an I2C-compatible SCCB bus.
> +  The sensor transmits images on a MIPI CSI-2 output interface with one or
> +  two data lanes.
> +
> +allOf:
> +  - $ref: /schemas/media/video-interface-devices.yaml#
> +
> +properties:
> +  compatible:
> +    const: ovti,og01a1b
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    description: External clock connected to the sensor system clock.

Drop description, obvious.

> +    maxItems: 1
> +
> +  clock-frequency:
> +    description: Frequency of the external clock to the sensor in Hz.

Drop property. Frequency comes from clock.

> +
> +  reset-gpios:
> +    description: Active low signal GPIO to control sensor.
> +    maxItems: 1
> +
> +  strobe-gpios:
> +    description: GPIO connected to the sensor strobe pad.
> +    maxItems: 1
> +
> +  avdd-supply:
> +    description: Analogue circuit voltage supply.
> +
> +  dovdd-supply:
> +    description: I/O circuit voltage supply.
> +
> +  dvdd-supply:
> +    description: Digital circuit voltage supply.
> +
> +  port:
> +    $ref: /schemas/graph.yaml#/$defs/port-base
> +    additionalProperties: false
> +    description:
> +      Output port node, single endpoint describing the CSI-2 transmitter.
> +
> +    properties:
> +      endpoint:
> +        $ref: /schemas/media/video-interfaces.yaml#
> +        unevaluatedProperties: false
> +
> +        properties:
> +          data-lanes:
> +            minItems: 1
> +            maxItems: 2
> +
> +          link-frequencies: true

This should not be needed.

> +
> +        required:
> +          - data-lanes
> +


Best regards,
Krzysztof