From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AAAD31AF14 for ; Mon, 20 Oct 2025 13:39:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760967542; cv=none; b=dNiQZKVThtmJWWr4m0MJwioIOvPg8aeT7nkE9kuydfWWgj9TpaJm22uOvyGWY0xG9jNlt2oFPQLi6npHc/F912v26e9K8sbU3MPhjN/Ph4IvU0DUtkqYRBjS9QTN4wv6pSEMHqpI8FFVKKJA7YJxE4wD/zU1QnM6odW9O7CNjio= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760967542; c=relaxed/simple; bh=hwv1YfCnFLJpiuuZikVWZGq9I06wdk0G95/RZY/REng=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Sk2yWPuJmaZaMJcIsmTCKCsUr4sXWlNEn3pwhvz5Z+W11JIKA30eduOppCK0ZrRlmADEXgySgBI6eJmClbKTQyaztDROIL3Bwgs9dPeWWwsbC+CMr9+qSutpquEzJ/ap/0dMeGlJT0G33foARWu9WgRxIm5pw9/2/nmximzLoVI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NRK+lxCE; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NRK+lxCE" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59KBE89b012360 for ; Mon, 20 Oct 2025 13:38:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Rw+jplN5LBufA5sJ53Ja3QfxZgNTjgPwrhBg8ayk9cc=; b=NRK+lxCEXOnGVjaR Bdkq+7+VYBbQ6v5mKKjTffuGlZJlV+EwDIo21orJK9DVLqaG7SXZY1fb4mGvsKkE eoLJVxTH2tNdox2QLsPaKlEu5kdcJbpwWv3KK9LxAJdknjDZ8P2SSo6fGE4NXRzO ZZQ9RzJ+V2pz6AXzFgHuQXMWBp/8YerJVUGgb6soOtNT1Zfp9Vwnab7mTHguNESt 8vLgNJrEDENfZPDaWVPQr9+E6xr5nzhhdPoH5qNIa937ikVD2eqfXruEpIRV4jy8 KPpaXU7J6NRz2JHX0aMfGYlTZpcoLISQfH53sHmZoVfqoz0Pqb8I533BCoqJ6nVT zhFzEA== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49v2gdvwhh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 20 Oct 2025 13:38:59 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-28a5b8b12bbso110337315ad.2 for ; Mon, 20 Oct 2025 06:38:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760967538; x=1761572338; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Rw+jplN5LBufA5sJ53Ja3QfxZgNTjgPwrhBg8ayk9cc=; b=kH1BvuhbA+RnL24rM25go2fIEz3569KHXDNZDzqXHqF8guYhYwSyRrJyYipTmuyHbj CjKQ9QVUt6RS/B9UIyGZH+PFzYRSde5S4URmfImhVIRCG0tz/MFdT7elYP7TzaL9M7Eu FE5Lg1WIJk5SrcO3NVl2ViJsFSqcV7x1nosdt6ChYcl30Rl1QddSMarTmAY40nmCGZ2U /emCgD2+rx711l8vorFGete6IpTwEdcafX//tSpvT4EDiU+O8brlI1tmJIdUgLcJxzPN FOVadmUecJKWakYh4yg3h57x88VQRbPHAyprVPtoUjCJ8z5VzIORrLa7KxGbP3uX0U7g YfSg== X-Forwarded-Encrypted: i=1; AJvYcCV0P/JTxYVCC0aNNnFUwIbAfdBh3BqxHgXp+OOC8orV+ACLA+XkgwNF2Et5P5/xMx/laZ5YZ3axVT6r+g==@vger.kernel.org X-Gm-Message-State: AOJu0YxGCl9yXv3EYWTFRROkjpnWvufiFuWJFuQoDFtlIwXAB23AkYu0 IwvjgGcysvR35nVCnzlPG5298466PRd5KdrrK9JmNu5xXjCZgZndOwmbl8SLIyAH8QoM4bIlFQl fpoGOq0RlyKYIlgSN3NZcxXfRmTY5KEB3qRce2rAUDwBp4KXQ+aa5F5YBmN9q/8+IqQ== X-Gm-Gg: ASbGncsLJrLYlfFLh1RqAk6V/qLUdj64s7yKJMdKWOzgNYx/KoyLQ3DfqU9wdmKVFqO SQxSHDWbJjhv0z0OR8Fsmlq7p460cMeG7JgJhhB5jbnSgOReu5nC3a1SnxEC1oMnZ5uYEUhF3Rh cM0+Xarqd5R8ottauMZ+0PAs6oBN8TOkkPM0VPKLylz2R/4f2TzwPSgHY7WJneGPcQndz7JwvAK Q8lfiezbx3u8xpGVew2JICthgvXFmVrxc1YrGwF2UXGcarJa113tegtVAuK7w926gXF9ysARGL+ S1YUQx8Tj3bstWF2xlqvP86oHzLc3dtw1BK7mEP2S0qWI0qTw8UZtH/SiMqfvue+o9uMfat940J g7/TKAL1ObXQEiW2MK6QI8TdcoeNzf28m24JUWnEjyRoi6RrR2lwq0DJSbiSX193zpqo= X-Received: by 2002:a17:903:98f:b0:277:3488:787e with SMTP id d9443c01a7336-290c9cf8e7fmr165399145ad.12.1760967537853; Mon, 20 Oct 2025 06:38:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHRNEXbflozLjWkDnbjGXkqNc04PBYLwxX4FkeZGUAQM1MSVdWu/MYBIBj3FuVvicz/eZI0Kg== X-Received: by 2002:a17:903:98f:b0:277:3488:787e with SMTP id d9443c01a7336-290c9cf8e7fmr165398655ad.12.1760967537285; Mon, 20 Oct 2025 06:38:57 -0700 (PDT) Received: from ?IPV6:2603:8001:8403:ab62:4d1e:2cd3:d939:feed? ([2603:8001:8403:ab62:4d1e:2cd3:d939:feed]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-33d5df9351fsm8007642a91.16.2025.10.20.06.38.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Oct 2025 06:38:56 -0700 (PDT) Message-ID: Date: Mon, 20 Oct 2025 06:38:50 -0700 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/6] media: qcom: camss: Add Kaanapali compatible camss driver To: Hangxiang Ma , Bryan O'Donoghue , Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab Cc: linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com, Jingyi Wang , Atiya Kailany References: <20251014-add-support-for-camss-on-kaanapali-v2-0-f5745ba2dff9@oss.qualcomm.com> <20251014-add-support-for-camss-on-kaanapali-v2-3-f5745ba2dff9@oss.qualcomm.com> <0fe25ca8-8dd4-42c7-a818-a803a256f42f@linaro.org> <8ba56bfe-d0cc-4f9a-93c8-0c361d5c59c8@oss.qualcomm.com> Content-Language: en-US From: Vijay Kumar Tumati In-Reply-To: <8ba56bfe-d0cc-4f9a-93c8-0c361d5c59c8@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDE4MDAyMCBTYWx0ZWRfXwinZ2/WHt1zp YgPvFuooMq2e05h4e48vnq6ViW7fqXw72Nn/c4VKcyjKs/nrjtS/Uw+Tvda41Dg1ijL52+V7jYJ lG/T+ewSWIsPZhUwzAFPTApRxM1/3gekSDkpLAGn+VP6l0SqMQ0t0eWrY2yqFSuKVPHJYcIrwQS 2Tm5JVVI883eA0K+7OYo7FkyiSJmo1lu/3nbKue5gYyHoZS0LisVYxDSJ980xeuQaaf1FR1RdkC 0EzmNWjV6XRTjNrgnx5mMT5miR2ISdm7KRMc2GzbcBpsj3YYz697/y/OjYGm9+Vz6PYOGtdEI+3 uQqhWgagtBgbTtttv1/7RkQ7ZC1pfBd/ybyIxHaR8YFyhkgxLwAZBDn3V0R6vOGVZbB0MIPObfl DyMeXUlWKqLWzS7dCxTiwWMPpQfu0w== X-Authority-Analysis: v=2.4 cv=KqFAGGWN c=1 sm=1 tr=0 ts=68f63b73 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=6xprqeDdnALSCdrIqMcA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-GUID: umGI88oepyBkBSlOtioMnT819pjnJce- X-Proofpoint-ORIG-GUID: umGI88oepyBkBSlOtioMnT819pjnJce- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-20_04,2025-10-13_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 phishscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510180020 On 10/19/2025 11:45 PM, Hangxiang Ma wrote: > On 10/16/2025 4:55 PM, Bryan O'Donoghue wrote: >> On 15/10/2025 03:56, Hangxiang Ma wrote: >>> +static const struct resources_icc icc_res_kaanapali[] = { >>> +    /* Based on 4096 x 3072 30 FPS 2496 Mbps mode */ >>> +    { >>> +        .name = "ahb", >>> +        .icc_bw_tbl.avg = 925857, >>> +        .icc_bw_tbl.peak = 925857, >>> +    }, >> >> Looking at other implementations I realise we've been adding avg and >> peak without too much review however, wouldn't 925857 / 2 => 462928 >> be a better value for the average ? >> >> --- >> bod > > Ack. Thanks. Just adding my thoughts on this, as you know the peak/avg bandwidth should primarily depends on the sensor data rate and additionally, the average BW vote should depend on the buffer sizes in the NIUs/NOCs and (although irrelevant here) whether it's an RT or NRT module (file system reads/writes from the NRT modules can be averaged and controlled better). Fundamentally, the votes from all modules go into the calculation of the DDR clock. The current driver does not take into account anything. So either way, it is not ideal I think. We can discuss and come up with a cleaner approach in a different patch series covering all chip sets. Thanks. > > --- > Hangxiang >