From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF22C2D94B5; Fri, 13 Feb 2026 09:32:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770975173; cv=none; b=Cxltdnadrs8UapVPbWF9culSjYjZUxcdmIQ2Zht/8L9l2HthitqNvxUN0hYMCICAJnhxH5kkJo1+3i9j0fjj4rjb+gxC1+SdRfxn8vR3bfA9KDJM5db8CN0kWtmGzGJ6dX9cX+O3XUht4Iy61hK633MwgRmPrVbS0K3G1lJ2rMI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770975173; c=relaxed/simple; bh=xsNmS3sMFINv6sJaT4EuuEnJmzEKekP8MtmtfTiiI+E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nlaEY4wAOunTTHXE/aruRd771c1v4Kash+cwz1GrvN3WewsXl23+eiaC7XBn0ddpc5E4RcneQMvRv/Z5tx8Zu34iJsBrK8Kk73O0Pv8bCSuvcHqt/ZSs0mvC+Lcn025DhANrCKo9TmoYoIyb6+acRVjUyEP4VhuXiYnKSYaMBCA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mH6gkC/J; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mH6gkC/J" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 157A5C116C6; Fri, 13 Feb 2026 09:32:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770975172; bh=xsNmS3sMFINv6sJaT4EuuEnJmzEKekP8MtmtfTiiI+E=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=mH6gkC/JTizLJvfX6jl9NgswUC9kmfkZ9mi6DLpDS4mVuQ3M7VyNSzAP+nkzF7mon pLHb6qQR3Dfbuxmr0OeFO85yFfJw9kO267jk69Hhv7ZSD/40H7ijM3VhcAzds/EBhe SP1dhV6m0uwTRzmDxKiMTJBCV/4y6w55RRdeXUY0Mgp9jIxg+LzV+pWOvuTyeSC4Bb /J8PfcTYBRxWbsJCJgGvyYFuaV671vuiR2S+gfV0Z4xTyDtn0XSs6uKnaKGZX6t+1Z e0ys6YPuMUcu89CAkyEEVlnEy7ScG/k99N6jWMmAo/EBCgqDFUWTZkFNraWv3bOGXJ ZCYC8HO/93T2w== Message-ID: Date: Fri, 13 Feb 2026 10:32:46 +0100 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 5/6] dt-bindings: media: mediatek,vcodec-encoder: Add MT8196 with VCP support To: =?UTF-8?B?SXJ1aSBXYW5nICjnjovnkZ4p?= Cc: "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , =?UTF-8?B?TG9uZ2ZlaSBXYW5nICjnjovpvpnpo54p?= , =?UTF-8?B?VGlmZmFueSBMaW4gKOael+aFp+ePiik=?= , "wenst@chromium.org" , "linux-media@vger.kernel.org" , "devicetree@vger.kernel.org" , =?UTF-8?B?TWFvZ3VhbmcgTWVuZyAo5a2f5q+b5bm/KQ==?= , "linux-mediatek@lists.infradead.org" , "nicolas.dufresne@collabora.com" , "mchehab@kernel.org" , =?UTF-8?B?S3lyaWUgV3UgKOWQtOaZlyk=?= , =?UTF-8?B?WXVuZmVpIERvbmcgKOiRo+S6kemjnik=?= , Project_Global_Chrome_Upstream_Group , "hverkuil-cisco@xs4all.nl" , "sebastian.fricke@collabora.com" , "linux-arm-kernel@lists.infradead.org" , "matthias.bgg@gmail.com" , "krzk+dt@kernel.org" , AngeloGioacchino Del Regno References: <20260212100104.11863-1-irui.wang@mediatek.com> <20260212100104.11863-6-irui.wang@mediatek.com> <20260213-didactic-whispering-impala-ea9e64@quoll> <13bf9b8673c6d47e07dee4a233945ed542e9b4f3.camel@mediatek.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <13bf9b8673c6d47e07dee4a233945ed542e9b4f3.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 13/02/2026 10:27, Irui Wang (王瑞) wrote: > Dear Krzysztof, > > I sincerely apologize for taking up your time to review and respond to > this patch. The maintainers' review comments are very important to us, > so we will never ignore them, there must be some misunderstanding in > this process. > > On Fri, 2026-02-13 at 08:52 +0100, Krzysztof Kozlowski wrote: >> On Thu, Feb 12, 2026 at 06:01:02PM +0800, Irui Wang wrote: >>> Add support for MT8196 video encoder which uses VCP (Video Co- >>> Processor) >>> for firmware management. Unlike previous platforms that use >>> SCP/VPU, MT8196 >>> requires VCP to load and execute the video encoding firmware, with >>> the >>> encoder communicating through VCP to perform encoding operations. >> >> Again, read review from v2. Subject is still wrong. Here "read review from v2" > > From the reviews of v2 and v3, my understanding is that the patch lacks > details, so we add more description for current modification, for 'VCP' > usage. So we are very grateful if you could provide a `correct Subject > ` example for us, thanks a lot. You received one at v2. > > >>> >>> Add the "mediatek,mt8196-vcodec-enc" compatible string and >>> introduce >>> the "mediatek,vcp" property to reference the VCP device, which is >>> required for MT8196 encoder operation. >>> >>> Signed-off-by: Irui Wang >>> --- >>> .../media/mediatek,vcodec-encoder.yaml | 19 >>> +++++++++++++++++++ >>> 1 file changed, 19 insertions(+) >>> >>> diff --git >>> a/Documentation/devicetree/bindings/media/mediatek,vcodec- >>> encoder.yaml >>> b/Documentation/devicetree/bindings/media/mediatek,vcodec- >>> encoder.yaml >>> index ebc615584f92..4c8acebeb9d3 100644 >>> --- a/Documentation/devicetree/bindings/media/mediatek,vcodec- >>> encoder.yaml >>> +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec- >>> encoder.yaml >>> @@ -24,6 +24,7 @@ properties: >>> - mediatek,mt8188-vcodec-enc >>> - mediatek,mt8192-vcodec-enc >>> - mediatek,mt8195-vcodec-enc >>> + - mediatek,mt8196-vcodec-enc >>> - items: >>> - const: mediatek,mt8186-vcodec-enc >>> - const: mediatek,mt8183-vcodec-enc >>> @@ -58,6 +59,13 @@ properties: >>> description: >>> Describes point to scp. >>> >>> + mediatek,vcp: >>> + $ref: /schemas/types.yaml#/definitions/phandle >>> + description: >>> + Reference to the VCP (Video Co-Processor) device that loads >>> and executes >>> + the video encoding firmware. The encoder communicates with >>> the firmware >>> + through VCP to perform encoding operations. >>> + >>> power-domains: >>> maxItems: 1 >>> >>> @@ -76,6 +84,17 @@ required: >>> - iommus >>> >>> allOf: >>> + - if: >>> + properties: >>> + compatible: >>> + contains: >>> + enum: >>> + - mediatek,mt8196-vcodec-enc >>> + >>> + then: >>> + required: >>> + - mediatek,vcp >> >> And here still did not implement the comment. So basically you did >> not >> implement fully v2 and v3. > > If you are mean about the `else statement`, I left a comments and want > to get an explanation from you, if you feel that my reply is > unsatisfactory or incorrect, please let me know. > > The key point is that our patch can satisfy you and get a Reviewed-by > from you. > Neither your answer, nor commit description here are actually ANSWERING to my comment at v3. If you answer with irrelevant/unrelated comment, the reviewer's feedback stays. OR explain please with different words why other devices have vcp but your commit msg says they do not have vcp. Best regards, Krzysztof