From: Vincent Knecht <vincent.knecht@mailoo.org>
To: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Todor Tomov <todor.too@gmail.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
"André Apitzsch" <git@apitzsch.eu>,
phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v4 2/4] media: qcom: camss: Add support for MSM8939
Date: Sat, 07 Jun 2025 23:43:26 +0200 [thread overview]
Message-ID: <e73d676ba1901437d471a2a633e94a07b19a3e05.camel@mailoo.org> (raw)
In-Reply-To: <877a72fa-cdae-4a66-9991-5ea86ef76aac@linaro.org>
Le vendredi 06 juin 2025 à 13:59 +0300, Vladimir Zapolskiy a écrit :
> Hello Vincent.
>
> On 6/2/25 20:27, Vincent Knecht via B4 Relay wrote:
> > From: Vincent Knecht <vincent.knecht@mailoo.org>
> >
> > The camera subsystem for the MSM8939 is the same as MSM8916 except with
> > 3 CSID instead of 2, and some higher clock rates.
> >
> > As a quirk, this SoC needs writing values to 2 VFE VBIF registers
> > (see downstream msm8939-camera.dtsi vbif-{regs,settings} properties).
> > This fixes black stripes across sensor and garbage in CSID TPG outputs.
> >
> > Add support for the MSM8939 camera subsystem.
> >
> > Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> > Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org>
>
> There was a preceding and partially reviewed changeset published on
> linux-media [1] before v1 of the MSM8939 platform support in CAMSS,
> due to a merge conflict this platform changeset should be rebased IMHO.
>
> [1] https://lore.kernel.org/all/20250513142353.2572563-4-vladimir.zapolskiy@linaro.org/
>
> --
> Best wishes,
> Vladimir
Thank you, I'll look into it
next prev parent reply other threads:[~2025-06-07 21:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-02 17:27 [PATCH v4 0/4] CAMSS support for MSM8939 Vincent Knecht via B4 Relay
2025-06-02 17:27 ` [PATCH v4 1/4] media: qcom: camss: vfe: Add VBIF setting support Vincent Knecht via B4 Relay
2025-06-02 17:27 ` [PATCH v4 2/4] media: qcom: camss: Add support for MSM8939 Vincent Knecht via B4 Relay
2025-06-06 10:59 ` Vladimir Zapolskiy
2025-06-07 21:43 ` Vincent Knecht [this message]
2025-06-13 8:06 ` Bryan O'Donoghue
2025-06-13 8:28 ` Vincent Knecht
2025-06-13 8:29 ` Bryan O'Donoghue
2025-06-02 17:27 ` [PATCH v4 3/4] media: dt-bindings: Add qcom,msm8939-camss Vincent Knecht via B4 Relay
2025-06-06 10:46 ` Vladimir Zapolskiy
[not found] ` <379f7434dadc22053afbf79734e8d96551b9e4e3.camel@mailoo.org>
2025-06-09 10:11 ` Vladimir Zapolskiy
2025-06-26 10:01 ` Krzysztof Kozlowski
2025-06-02 17:27 ` [PATCH v4 4/4] arm64: dts: qcom: msm8939: Add camss and cci Vincent Knecht via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e73d676ba1901437d471a2a633e94a07b19a3e05.camel@mailoo.org \
--to=vincent.knecht@mailoo.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@apitzsch.eu \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=todor.too@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).