public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>, linux-media@vger.kernel.org
Cc: laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH 1/6] media: v4l: cci: Include linux/bits.h
Date: Fri, 10 Nov 2023 12:11:28 +0100	[thread overview]
Message-ID: <e8ca9be0-dc79-4b0b-8173-e3cdf41b883a@redhat.com> (raw)
In-Reply-To: <20231110094705.1367083-2-sakari.ailus@linux.intel.com>

Hi,

On 11/10/23 10:47, Sakari Ailus wrote:
> linux/bits.h is needed for GENMASK(). Include it.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
>  include/media/v4l2-cci.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/media/v4l2-cci.h b/include/media/v4l2-cci.h
> index 0f6803e4b17e..f2c2962e936b 100644
> --- a/include/media/v4l2-cci.h
> +++ b/include/media/v4l2-cci.h
> @@ -7,6 +7,7 @@
>  #ifndef _V4L2_CCI_H
>  #define _V4L2_CCI_H
>  
> +#include <linux/bits.h>
>  #include <linux/types.h>
>  
>  struct i2c_client;

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans



  reply	other threads:[~2023-11-10 17:45 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-10  9:46 [PATCH 0/6] Use V4L2 CCI in CCS driver Sakari Ailus
2023-11-10  9:47 ` [PATCH 1/6] media: v4l: cci: Include linux/bits.h Sakari Ailus
2023-11-10 11:11   ` Hans de Goede [this message]
2023-11-10 14:44   ` Laurent Pinchart
2023-11-10  9:47 ` [PATCH 2/6] media: v4l: cci: Add driver-private bit definitions Sakari Ailus
2023-11-10 11:11   ` Hans de Goede
2023-11-10 14:44   ` Laurent Pinchart
2023-11-10 21:21     ` Sakari Ailus
2023-11-10  9:47 ` [PATCH 3/6] media: v4l: cci: Add macros to obtain register width Sakari Ailus
2023-11-10 11:14   ` Hans de Goede
2023-11-10 11:17     ` Sakari Ailus
2023-11-10 14:44       ` Laurent Pinchart
2023-11-10 14:49         ` Laurent Pinchart
2023-11-10 14:52           ` Hans de Goede
2023-11-10 21:21             ` Sakari Ailus
2023-11-10  9:47 ` [PATCH 4/6] media: ccs: Generate V4L2 CCI compliant register definitions Sakari Ailus
2023-11-10  9:47 ` [PATCH 5/6] media: ccs: Better separate CCS static data access Sakari Ailus
2023-11-10 14:46   ` Laurent Pinchart
2023-11-10 21:24     ` Sakari Ailus
2023-11-10  9:47 ` [PATCH 6/6] media: ccs: Use V4L2 CCI for accessing sensor registers Sakari Ailus
2023-11-10 15:21   ` Laurent Pinchart
2023-11-10 21:38     ` Sakari Ailus
2023-11-10 22:53       ` Laurent Pinchart
2023-11-10 23:03         ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e8ca9be0-dc79-4b0b-8173-e3cdf41b883a@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox