From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E89832D0C6C for ; Thu, 9 Oct 2025 13:53:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760018009; cv=none; b=I/oz18/kKCyb40MavqXCfC+K2jUoehjxxI7Wy2Y1GshtxLf1UiJzTAiWifvyqCNBT7fd6zjGMwmOuxtqkn5YIuKpTeQyjSoTeF1qSOJZUGSh34TmqYdh9GOES3ihZz7x0crmjomJdVoVXX/w2DvElwPYXsdAEynwKDC5/YQ0wAA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760018009; c=relaxed/simple; bh=iIw1YS7FRzuqX/b7vQs43cPHzleNifKAIIPkz1lng6I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uHvDCvgF4yUmVzTeRbJxbxI12NDJaoYSymFG+JPHyj2Ov0cGIKaK+WiaDwNgfbrVgtHxSIcK1UBCSWVSxpAyZdT+KvJICpdKAuquA/3rvC9cwULtFETkV+ik2/PjIr46sA4VpM99PZcJdRbvFrOIel/C06c7eHctiCsukJnRDKM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=d+SFdL/T; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="d+SFdL/T" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5996EHNP029247 for ; Thu, 9 Oct 2025 13:53:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kuuZDigaf9RBnx4G6sw5Ulge8sPDtaQLp412MRxS0FM=; b=d+SFdL/T6zA9cB86 RK8cDWqG2mNhGBSC41SFjWKXylVfHXYfSBoMwXvQC/K1bkjb1ov99JbIbPzX7v46 YrAN0tI4F0eCR+v8XOx4/zy+bEcF5w4zD3nJgqUHA7wjdc6Rwz7SQs6ThzMDuGtq Gpgky+blaXEq7G+G0r89LOlwPSSynd8Hgyi2JXkrhR79PkACWA5ieqLZslgafF3+ ieWtm0to1Big1kZQ89jQSaOFWNB0P1qGgmaWBjai+K+YZzamiFUooe4K7FJOLyOv 80Vf2rTUQXPi4lt4RzkPIsB3F42y6bq87shRNjLgwTACdd9JG0CQrqY2AguSJGaj RFn/Bw== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49nv4nk1bb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 09 Oct 2025 13:53:26 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-26983c4d708so11754115ad.3 for ; Thu, 09 Oct 2025 06:53:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760018005; x=1760622805; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kuuZDigaf9RBnx4G6sw5Ulge8sPDtaQLp412MRxS0FM=; b=SJepo9cdFuEAlA8SRwV87YzG0RehRlotDUJ0YZjMhQe9SJwoeZX1Bt7umBxhu1jO82 xxfNkPrNIHIUb5Xp/NnaoENE7S411u3ERpqAxe/TBoB6JUGJZFqKF3pAari6cbM89mLu bn2AP0OWgPgtN2hHmGXL8p8kw02Lx+mNuYlypHMHpSNjfKHCoUr24m2/j+9PLHnN9vKj s9GIJSbgDXZBwJ7vrtO8ZQ1SqeAgLUtMi/z3VPpYbLYc3QOV/KI/xr8M1F/SmAO1LCi2 dRos8ojI/G5/filfgxPPS7AkHoleQ6nTYXqGV99zkXK3mP3ohToWHfgv1pHLvuhO8WGh gtqw== X-Forwarded-Encrypted: i=1; AJvYcCX6E/9b1cDMeocO/tWRsw9puS6U/Yii+p2IUlWWFXnaPR6CNTwtcGjBvwtfgQCkUVxRdgsTfDzNPovQbw==@vger.kernel.org X-Gm-Message-State: AOJu0Yx00QuDL8HDrbyVYeuQ0VYP1sExNS9wYk0dr487j9CB8XcIy4JZ oNxbj1VeC4eZIAU/mTXpMYDstPq0EufQGmUs5UTORtbPmoQvsVarGglpzl5BEvnNMu2h7ItFxJ/ Zwikt6rQUlg1iJnq+8LUGlbzsnzY8vyX3V41MZ/Cy1GQLsKqv2xD7rt81XTXaiyYy6Q== X-Gm-Gg: ASbGncsuRrjq1hYOxcoRtvQMbd7oyzNsO0yCVcgWd+mtsDAjkgLUs0SxepSLaIWRxIm 1F7/gQHWk4z+SHtHRkejpGU+XMP3gQINXb0BPGE9EMHMhKR4oqZd3JJVv6RhUgOgtdkOFpD7Sgk /2zAZPZpZT/2QldbbgbF297AblUbW3PU5hqKgWAdk6XqkSUuo4EmnV+0LKhBk0F6O5fekCEDpbL KplTa4vdupRAVppwnCOb+KMDjPP940M8jpitqUG3pgSqV5IaZ68Xv59HJuL4v1EJpqeBzGaO1Wb w9A5CqMk7XtULq16/xzvgAVksu+PkGwHMjdZhFwDFZ6bW0ewTnBfvQ440kbLsvDpm9QLGDMEm8L YEw== X-Received: by 2002:a17:903:3d0e:b0:25c:46cd:1dc1 with SMTP id d9443c01a7336-2902734491dmr99554635ad.33.1760018005414; Thu, 09 Oct 2025 06:53:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE6HcauBvRWZI0Kn+0ktenPuR1vVtsIpDUIB5D3Em9yQLlvyjz3pjpSZ/KfzXun9PXoWkHbCA== X-Received: by 2002:a17:903:3d0e:b0:25c:46cd:1dc1 with SMTP id d9443c01a7336-2902734491dmr99554055ad.33.1760018004872; Thu, 09 Oct 2025 06:53:24 -0700 (PDT) Received: from [10.0.0.3] ([106.222.229.252]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29034f36116sm29906145ad.93.2025.10.09.06.53.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Oct 2025 06:53:24 -0700 (PDT) Message-ID: Date: Thu, 9 Oct 2025 19:23:20 +0530 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 15/25] media: qcom: iris: Drop unneeded v4l2_m2m_get_vq() NULL check To: Laurent Pinchart , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org Cc: Nicolas Dufresne , Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue References: <20251008175052.19925-1-laurent.pinchart@ideasonboard.com> <20251008175052.19925-16-laurent.pinchart@ideasonboard.com> Content-Language: en-US From: Dikshita Agarwal In-Reply-To: <20251008175052.19925-16-laurent.pinchart@ideasonboard.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDA4MDEyMSBTYWx0ZWRfXxV7HpIgcDZBo jB8ZiLF6cDCHcaD0WZuZ6YKjQ/SvAbDELpBBq5A8qIUGS7m0KziZbVTHTbrIagQYQcuwAKDS1SH CODMk5GguAv2i17nVPR4TdtJeqsieTDhN/WE9vzBiecf8oTyF5JUq6O5rf6CcHVoHhdO8ngzuN9 TBzFmovrsnSSoSPUUbzX2GYolObqUK2rOzWeBFzLX31TlzrvpcV+yc7rNtMnKuP4gIlFTIpIAC8 lVK2HClodsrx6fao+WNzRoEka/eqvKKNYBk2oXor6cvKmIsIh547+N1aPNuC/dJESTi7zacSSSt Jl5WPQJ1Tuj/s1WRBz3ZxHeKoCuCrYh38875LuV9WK0dy0iMlaWxt2mKmwI2CcJpcxNXhHWFHcJ Chg8loGvwwuzWFVr0uyGq9sypXhf6A== X-Proofpoint-ORIG-GUID: GHr4YgqzQ8jfx0e5DgUXnFZDiOegDNsU X-Proofpoint-GUID: GHr4YgqzQ8jfx0e5DgUXnFZDiOegDNsU X-Authority-Analysis: v=2.4 cv=VK3QXtPX c=1 sm=1 tr=0 ts=68e7be56 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=L4UNg9I9cQSOxNpRiiGXlA==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VwQbUJbxAAAA:8 a=P1BnusSwAAAA:8 a=d3DCbir4PBIb6Zx2eVkA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-09_04,2025-10-06_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 phishscore=0 clxscore=1015 impostorscore=0 bulkscore=0 spamscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510080121 On 10/8/2025 11:20 PM, Laurent Pinchart wrote: > The v4l2_m2m_get_vq() function never returns NULL. The check may have > been intended to catch invalid format types, but that's not needed as > the V4L2 core picks the appropriate VIDIOC_S_FMT ioctl handler based on > the format type, so the type can't be incorrect. Drop the unneeded > return value check. > > Signed-off-by: Laurent Pinchart > --- > drivers/media/platform/qcom/iris/iris_vdec.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_vdec.c b/drivers/media/platform/qcom/iris/iris_vdec.c > index d670b51c5839..1e9ffdbb6e18 100644 > --- a/drivers/media/platform/qcom/iris/iris_vdec.c > +++ b/drivers/media/platform/qcom/iris/iris_vdec.c > @@ -191,8 +191,6 @@ int iris_vdec_s_fmt(struct iris_inst *inst, struct v4l2_format *f) > u32 codec_align; > > q = v4l2_m2m_get_vq(inst->m2m_ctx, f->type); > - if (!q) > - return -EINVAL; > > if (vb2_is_busy(q)) > return -EBUSY; The same change would be required for iris_venc.c as well which is part of linux-next[1] [1]: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/media/platform/qcom/iris/iris_venc.c#n271 Thanks, Dikshita