From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 281A534A796 for ; Mon, 6 Apr 2026 06:01:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775455316; cv=none; b=NXl3XQt7GhHARa2HhQ5fENi4eOhrTI86cZubJ+1KSpi4IVt7a6eIvKHbSEAbeorV4lPjdZi1StrTtA8W+2CKPgMtdZDWJDBnIVfw5v39IMlxVe62eU1OEXijkp2uf0GA+IDhQypF34EjBmqEvMhurg7IwidAsj2Xz/uACYiQ/e4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775455316; c=relaxed/simple; bh=0tImFS4ABMDg9bJyqwyS5dBemqFPhTSKTOcbFhI6icA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=S1/o8BGU1LXVnarYULc0HYvsN7wqrdkJBMjroUiNQMos7Pl0FTh+TvzUuUJQr9aTu4siL2pTaFFAYhVa55r16c1lCHP2JAty7CNt/ywtCbJYmoeXdmPFbDZBvxsI0PlmpckjhLlx3t6P7ASeBreNpZw6o+8Q3pww9bBLz/hUrkM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fsce4Q5t; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZvlqS2NR; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fsce4Q5t"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZvlqS2NR" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 635MPv6T2816235 for ; Mon, 6 Apr 2026 06:01:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kXO6apHJ4oRf8IXdVY4OkSBbhjDR55c7WnY4JLVkPxQ=; b=fsce4Q5tG49yqG7y tT2kgE+WMS72dokdL8Vn9mYRlZWJxBrWtODm2ogZUV9auAEO8sZnc7b7szti2H66 952bgz7roJnRwuX0nPxkpmUdL1Q1Sl/CczZlWuCLFXaxH0VdtlYkk0hNfqaEUVVL /m/obU7dnA7dh+f5bq0PY/NjlXHMX8fYvwKYs0hk2RFrrDU0M55VaOfyZRRSpU9L HnXHF5CK07s2kzn96JtCml7nPcoGOKAw0wfMhqgUjcPykO6clNF1d+riIIDDk7z0 uOFhG/dzIRlMc5FDDcqE5nLluv+F4aNsWanM2kGJHYJgzsoVW6OT4AWCt2eEegSG V7IsrA== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4datv1by4m-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Apr 2026 06:01:54 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-82a6c70f1f8so2380561b3a.0 for ; Sun, 05 Apr 2026 23:01:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775455314; x=1776060114; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kXO6apHJ4oRf8IXdVY4OkSBbhjDR55c7WnY4JLVkPxQ=; b=ZvlqS2NRdj3Q68ICLZhfUp+RhGB0jb9E2/xitXJfYdadPufmBCPgjnRFNAc3rOVuvh wZBN+ffIqIoKkfGfsN/Lmy7zAwUbPKN9jQ5FIO1h53cQxa9DD0J6ZZqUdW7Bcoe7uyzJ SVcKTCRn9ftlT/KBBERyriOyJffI9pSyb1Z4q3H8hJbjD5i3Q0GdzNLpVGZqCK7zj8PJ Vt5rypTB5n4FaIy5BT51hfndzSWn/8dZwhsXitDibkMq2QC2IE0p2Jxk4n5ojVhZ7Yzx +jLh2K55dFQQzDIr3RQbuRGjKy6e+Upa9a4JatH7YeZKpWks8yTpZmJ9u1KwNcko0PaC tYwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775455314; x=1776060114; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kXO6apHJ4oRf8IXdVY4OkSBbhjDR55c7WnY4JLVkPxQ=; b=JczMaRJ+ng4samxEPfZ2Z5TOG3gzUfxw4JG+PXtETf5qWSOEQpIfzDvtonPMraptd9 epNCEnSGkPvfWzZsuXSXAg5UmvFYblE4eVhDkPDh2MD+JURv/Z4HfhUv6Wj5UcEG+INv eCU/5YsspOeBmicED0D2FqbYWwG/qShXhWBVlWmlrg+qfdVuwQ7qqeriQRNiQp3v55UO A7PvlDr7VyrPNGUgORqW9XXO/YgJKnFQ0wxVbUs8vLPv4emuecFvTx1Lh0VAILt4YRUG T+T+2vpIZm24NI9sDNwE2VqEXCxMaaAu1cgL5B4esG3+6TWZvK4n3IT8QuN7Mz8Nj9CR 2FJA== X-Forwarded-Encrypted: i=1; AJvYcCWoE3+JOZwE+zEa/I/rskpAoB9ejXTR9LZak7tp4SkEF2lT3gHasK/ClrWTCPh5RYBt4RVdtlBYNqm68A==@vger.kernel.org X-Gm-Message-State: AOJu0Yw7azVvlC3H3R3vXFAsLqOMyM8+zM0xos6bf5gX1ueQQicbgvNT RiGOrkzER6CWYsTmUX2CyLhDeao8c30OaTZiCdovjn6dze8V1CugxPQdgkhSjGM0JSs2a2GPHGQ 8xVPcTixDDEPA7FUXLvasY7BxtAN5Q5pKLcmUk0Is2+zjCvU+Rhv2BHaGXsADjqytbQ== X-Gm-Gg: AeBDievQQZlACukBzrm06LQ46YVBm1nUa3EU0dvlo5fVtbYc8cKnH+zKhB1xPX3n9UB x/WpOFv8PrFJ1is7b4pxmTbWxQp/dEZaOxNOiQBZ/NHhebvMcFnyjqrbdCZ4ogRg+0jvj0Glhn7 WpDWktVRfsguLYn6Orw+u4bllYvUFnk+rkRI+W0E26R+eo0p7wbCot13KuFrUXTkJqcGLFKxYF5 +ucl5u3jG8GXe2CNvBZWxPpQ0qFcYakfOCfoXSOj1PD42kzIKq/85S28QmleTGBPuKXTIjHzSqY 9bh7tG4j9dNCnE8ROAmwdN8oFDFVQ7CEcgb1gbrAUQM0Ap1MXQuGQmWEsOhk26VaKGXWlk5J0xC Rio/jS3Yh5kRZZJQS6MyZ7+gPiQZittPGmRPu/Y5cQF+K79rBEBPwmw== X-Received: by 2002:a05:6a00:8008:b0:82c:6c90:c76d with SMTP id d2e1a72fcca58-82d0dbac80amr10511220b3a.46.1775455313686; Sun, 05 Apr 2026 23:01:53 -0700 (PDT) X-Received: by 2002:a05:6a00:8008:b0:82c:6c90:c76d with SMTP id d2e1a72fcca58-82d0dbac80amr10511196b3a.46.1775455313181; Sun, 05 Apr 2026 23:01:53 -0700 (PDT) Received: from [10.0.0.3] ([106.222.228.245]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82cf9c706f7sm12902550b3a.47.2026.04.05.23.01.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Apr 2026 23:01:52 -0700 (PDT) Message-ID: Date: Mon, 6 Apr 2026 11:31:47 +0530 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 3/3] media: qcom: venus: relax encoder frame/blur step size on v6 Content-Language: en-US To: Renjiang Han , Vikash Garodia , Bryan O'Donoghue , Mauro Carvalho Chehab , Alexandre Courbot , Tomasz Figa , Hans Verkuil Cc: Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Mauro Carvalho Chehab References: <20260331-fix_venus_bug_issue-v1-0-e4ae7a1d8db2@oss.qualcomm.com> <20260331-fix_venus_bug_issue-v1-3-e4ae7a1d8db2@oss.qualcomm.com> From: Dikshita Agarwal In-Reply-To: <20260331-fix_venus_bug_issue-v1-3-e4ae7a1d8db2@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: hCLW5oDY_UgGema6xcolJK4ZuFBxdvYG X-Authority-Analysis: v=2.4 cv=GLEF0+NK c=1 sm=1 tr=0 ts=69d34c52 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=AZq5V9zQ+e7Vr/IEUKe0sw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=UhZ1D2OpQGTyPwmj0QMA:9 a=+jEqtf1s3R9VXZ0wqowq2kgwd+I=:19 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-ORIG-GUID: hCLW5oDY_UgGema6xcolJK4ZuFBxdvYG X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA2MDA1NSBTYWx0ZWRfXyTLl4toMK3Tt qMSvjCmTCSxHA6ShN1wIPF3c7PqpzZAgQfChsp9jxIy5ytQzQrl8dF6Vf7eFzp3t2Sc5VWxOxHl KpjCwqiMvtD3sliXNGlejBfKZNPJUryfS3Y0xnaJf+4QqkfJ0IBwuCOicQsFax3a2KI2/VUR1Fp JXjT6cgXQ+cZsp/CPztXOxF5wVYMXyCcHGhB2eF2d7TswsiZ0yf+YK5IhGf6+5avFkIR8p+pzrh faCg5IYHGIm5uHYWFe7mSoOjh2AXCKkfXYlsQt6+BoSR1RB9ZXrKYfi4haZyljjtl3guM3uwkvC bh41KZ+sS/c/FVPGJAJLPTXJe18KQwe1w5EqNeZKOpjaWKgEft6pp4AHdB2cAOxcodumv4eYQQ7 tR1iuOvbrKevbqeEGJVYQxU4HXEdskocLPBiKXxFKii4fGkFGWAT/GCmLtxPj0hA0gsRgjFlvek 8z7iVss954nO2kMAlDg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-06_01,2026-04-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 spamscore=0 suspectscore=0 adultscore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604060055 On 3/31/2026 10:07 AM, Renjiang Han wrote: > Encoder HFI capabilities on v6 enforce a 16-pixel step for frame and blur > dimensions, which does not reflect actual hardware requirements and can > reject valid userspace configurations. > > Relax the step size to 1 while leaving min/max limits unchanged. > > Fixes: 869d77e706290 ("media: venus: hfi_plat_v6: Populate capabilities for v6") > Signed-off-by: Renjiang Han > --- > drivers/media/platform/qcom/venus/hfi_platform_v6.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/media/platform/qcom/venus/hfi_platform_v6.c b/drivers/media/platform/qcom/venus/hfi_platform_v6.c > index d8568c08cc3612a0024d36f65c741151a23459c3..fb8d10ab34043ee676bd7adcf9420d4274ce9d78 100644 > --- a/drivers/media/platform/qcom/venus/hfi_platform_v6.c > +++ b/drivers/media/platform/qcom/venus/hfi_platform_v6.c > @@ -173,8 +173,8 @@ static const struct hfi_plat_caps caps[] = { > .codec = HFI_VIDEO_CODEC_HEVC, > .domain = VIDC_SESSION_TYPE_ENC, > .cap_bufs_mode_dynamic = true, > - .caps[0] = {HFI_CAPABILITY_FRAME_WIDTH, 128, 8192, 16}, > - .caps[1] = {HFI_CAPABILITY_FRAME_HEIGHT, 128, 8192, 16}, > + .caps[0] = {HFI_CAPABILITY_FRAME_WIDTH, 128, 8192, 1}, > + .caps[1] = {HFI_CAPABILITY_FRAME_HEIGHT, 128, 8192, 1}, > .caps[2] = {HFI_CAPABILITY_MBS_PER_FRAME, 64, 138240, 1}, > .caps[3] = {HFI_CAPABILITY_BITRATE, 1, 160000000, 1}, > .caps[4] = {HFI_CAPABILITY_SCALE_X, 8192, 65536, 1}, > @@ -195,8 +195,8 @@ static const struct hfi_plat_caps caps[] = { > .caps[19] = {HFI_CAPABILITY_RATE_CONTROL_MODES, 0x1000001, 0x1000005, 1}, > .caps[20] = {HFI_CAPABILITY_COLOR_SPACE_CONVERSION, 0, 2, 1}, > .caps[21] = {HFI_CAPABILITY_ROTATION, 1, 4, 90}, > - .caps[22] = {HFI_CAPABILITY_BLUR_WIDTH, 96, 4096, 16}, > - .caps[23] = {HFI_CAPABILITY_BLUR_HEIGHT, 96, 4096, 16}, > + .caps[22] = {HFI_CAPABILITY_BLUR_WIDTH, 96, 4096, 1}, > + .caps[23] = {HFI_CAPABILITY_BLUR_HEIGHT, 96, 4096, 1}, > .num_caps = 24, > .pl[0] = {HFI_HEVC_PROFILE_MAIN, HFI_HEVC_LEVEL_6 | HFI_HEVC_TIER_HIGH0}, > .pl[1] = {HFI_HEVC_PROFILE_MAIN10, HFI_HEVC_LEVEL_6 | HFI_HEVC_TIER_HIGH0}, > @@ -210,8 +210,8 @@ static const struct hfi_plat_caps caps[] = { > .codec = HFI_VIDEO_CODEC_VP8, > .domain = VIDC_SESSION_TYPE_ENC, > .cap_bufs_mode_dynamic = true, > - .caps[0] = {HFI_CAPABILITY_FRAME_WIDTH, 128, 4096, 16}, > - .caps[1] = {HFI_CAPABILITY_FRAME_HEIGHT, 128, 4096, 16}, > + .caps[0] = {HFI_CAPABILITY_FRAME_WIDTH, 128, 4096, 1}, > + .caps[1] = {HFI_CAPABILITY_FRAME_HEIGHT, 128, 4096, 1}, > .caps[2] = {HFI_CAPABILITY_MBS_PER_FRAME, 64, 36864, 1}, > .caps[3] = {HFI_CAPABILITY_BITRATE, 1, 74000000, 1}, > .caps[4] = {HFI_CAPABILITY_SCALE_X, 8192, 65536, 1}, > @@ -229,8 +229,8 @@ static const struct hfi_plat_caps caps[] = { > .caps[16] = {HFI_CAPABILITY_P_FRAME_QP, 0, 127, 1}, > .caps[17] = {HFI_CAPABILITY_MAX_WORKMODES, 1, 2, 1}, > .caps[18] = {HFI_CAPABILITY_RATE_CONTROL_MODES, 0x1000001, 0x1000005, 1}, > - .caps[19] = {HFI_CAPABILITY_BLUR_WIDTH, 96, 4096, 16}, > - .caps[20] = {HFI_CAPABILITY_BLUR_HEIGHT, 96, 4096, 16}, > + .caps[19] = {HFI_CAPABILITY_BLUR_WIDTH, 96, 4096, 1}, > + .caps[20] = {HFI_CAPABILITY_BLUR_HEIGHT, 96, 4096, 1}, > .caps[21] = {HFI_CAPABILITY_COLOR_SPACE_CONVERSION, 0, 2, 1}, > .caps[22] = {HFI_CAPABILITY_ROTATION, 1, 4, 90}, > .num_caps = 23, > Reviewed-by: Dikshita Agarwal Thanks, Dikshita