Re: [PATCH v1 1/2] platform/x86: int3472: add hpd pin support

Andy Shevchenko
2025-04-14T08:11:12Z

On Mon, Apr 14, 2025 at 03:52:50PM +0800, Yan, Dongcheng wrote:
> On 4/11/2025 4:33 PM, Hans de Goede wrote:
> > On 11-Apr-25 10:23 AM, Dongcheng Yan wrote:

...

> >> + case INT3472_GPIO_TYPE_HOTPLUG_DETECT:
> >> + *con_id = "hpd";
> >> + *gpio_flags = GPIO_LOOKUP_FLAGS_DEFAULT;
> >
> > This looks wrong, we really need to clearly provide a polarity
> > here since the ACPI GPIO resources do not provide one.
> >
> I tested gpio_flags=GPIO_LOOKUP_FLAGS_DEFAULT/HIGH/LOW, the lt6911uxe
> driver can pass the test and work normally.

I doubt you tested that correctly. It's impossible to have level triggered
event to work with either polarity. It might be also a bug in the code lurking
somewhere, but it would be unlikely (taking into account amount of systems
relying on this).

Is it edge triggered event?

--
With Best Regards,
Andy Shevchenko