From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Irui Wang (王瑞)" <Irui.Wang@mediatek.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"Longfei Wang (王龙飞)" <Longfei.Wang@mediatek.com>,
"Tiffany Lin (林慧珊)" <tiffany.lin@mediatek.com>,
"wenst@chromium.org" <wenst@chromium.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Maoguang Meng (孟毛广)" <Maoguang.Meng@mediatek.com>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"nicolas.dufresne@collabora.com" <nicolas.dufresne@collabora.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"Kyrie Wu (吴晗)" <Kyrie.Wu@mediatek.com>,
"Yunfei Dong (董云飞)" <Yunfei.Dong@mediatek.com>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
"hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>,
"sebastian.fricke@collabora.com" <sebastian.fricke@collabora.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH v4 5/6] dt-bindings: media: mediatek,vcodec-encoder: Add MT8196 with VCP support
Date: Fri, 13 Feb 2026 10:51:47 +0100 [thread overview]
Message-ID: <ece3f7ee-8ecc-4528-a6ce-da4eeb24b236@kernel.org> (raw)
In-Reply-To: <dad64d23d0e9588979005f5770806105eb32a831.camel@mediatek.com>
On 13/02/2026 10:47, Irui Wang (王瑞) wrote:
>>>>
>>>> And here still did not implement the comment. So basically you
>>>> did
>>>> not
>>>> implement fully v2 and v3.
>>>
>>> If you are mean about the `else statement`, I left a comments and
>>> want
>>> to get an explanation from you, if you feel that my reply is
>>> unsatisfactory or incorrect, please let me know.
>>>
>>> The key point is that our patch can satisfy you and get a Reviewed-
>>> by
>>> from you.
>>>
>>
>> Neither your answer, nor commit description here are actually
>> ANSWERING
>> to my comment at v3. If you answer with irrelevant/unrelated comment,
>> the reviewer's feedback stays. OR explain please with different words
>> why other devices have vcp but your commit msg says they do not have
>> vcp.
>
> Why other devices have vcp? because I didn't write 'mediatek,vcp:false'
> in else statement?
Yes
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-02-13 9:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-12 10:00 [PATCH v4 0/6] Add support for MT8196 video encoder Irui Wang
2026-02-12 10:00 ` [PATCH v4 1/6] media: mediatek: encoder: Add a new encoder driver interface Irui Wang
2026-02-12 10:00 ` [PATCH v4 2/6] media: mediatek: encoder: Add support for common firmware interface Irui Wang
2026-02-12 10:01 ` [PATCH v4 3/6] media: mediatek: encoder: Add support for VCP encode process Irui Wang
2026-02-12 10:01 ` [PATCH v4 4/6] media: mediatek: encoder: Add a new platform data member Irui Wang
2026-02-12 10:01 ` [PATCH v4 5/6] dt-bindings: media: mediatek,vcodec-encoder: Add MT8196 with VCP support Irui Wang
2026-02-13 7:52 ` Krzysztof Kozlowski
2026-02-13 9:27 ` Irui Wang (王瑞)
2026-02-13 9:32 ` Krzysztof Kozlowski
2026-02-13 9:47 ` Irui Wang (王瑞)
2026-02-13 9:51 ` Krzysztof Kozlowski [this message]
2026-02-13 10:00 ` Irui Wang (王瑞)
2026-02-12 10:01 ` [PATCH v4 6/6] media: mediatek: encoder: Add MT8196 encoder compatible data Irui Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ece3f7ee-8ecc-4528-a6ce-da4eeb24b236@kernel.org \
--to=krzk@kernel.org \
--cc=Irui.Wang@mediatek.com \
--cc=Kyrie.Wu@mediatek.com \
--cc=Longfei.Wang@mediatek.com \
--cc=Maoguang.Meng@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=Yunfei.Dong@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=nicolas.dufresne@collabora.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.fricke@collabora.com \
--cc=tiffany.lin@mediatek.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox