Re: [PATCH v4 1/5] dt-bindings: media: qcom,sm8550-iris: Add X1P42100 compatible

Krzysztof Kozlowski
2026-04-02T07:05:39Z

On Wed, Apr 01, 2026 at 06:24:38PM +0800, Wangao Wang wrote:
> Document the new compatible string "qcom,x1p42100-iris".
>
> The x1p42100 SoC integrates the same IRIS video hardware block as SM8550,
> but represents a distinct hardware instance.

Full stop, as I asked last time.

> and therefore uses its own
> compatible string.

Drop, redundant. X1P42100 is not the same soc as SM8550, thus you cannot
have the same compatible. This is explicitly written in bindings. Each
different device needs own compatible string.

Adding obvious explanation from documentation to commit msg is
redundant.

Explain why devices are not compatible.

>
> The x1p42100 variant includes an additional Bitstream Engine (BSE) clock
> that is not present on SM8550.

Presence of additional clock does not indicate that devices are
compatible. Look at other qcom bindings - many are compatible even
though they have different clocks.

So say that you need to do something with that clock differently.

> This clock is described explicitly in the
> binding.

Last sentence - again, redundant. Write concise but informative
messages.

Best regards,
Krzysztof