From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4930C64EC4 for ; Wed, 8 Mar 2023 10:34:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231199AbjCHKed (ORCPT ); Wed, 8 Mar 2023 05:34:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230461AbjCHKdk (ORCPT ); Wed, 8 Mar 2023 05:33:40 -0500 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5A177BA06 for ; Wed, 8 Mar 2023 02:33:27 -0800 (PST) Received: by mail-ed1-x535.google.com with SMTP id j11so44215482edq.4 for ; Wed, 08 Mar 2023 02:33:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678271606; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7iR9ZZTK/rVOSQ9FgkPLyd+GiiOH43I/y6nWqPVeCUA=; b=sSH/DKMtEmhNsmHwdtFv+I70ArkkRbSVJiTNetRHfCqPsFOazlA2p/HjjQpMWsn4h4 CXB8Eel8JoAiOQWdOAAKmiXIYSYjs/56J2Wo5cp7Dg+V72F1SrhyDQD1D7h/LnbiQ7bj G0x6rHLzcANSoee87ijmfDUTA8ckWE2knAJYnGUurxdyZ3nr+sV3bgmz4D2EaJtSlKHn idl9WofsdAKch5xAS0grSK7gnQi0SWnj1bOlX/ho76JcldGZkwr1zVfoyE8JDxd+yxEK Sg8nes52tbQDTm8eqgrzYSgPbxAQNCJ9Sux7vSHYHZ6aZ0eiAEkuZ/T0pUESoD12l1Ir 6sbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678271606; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7iR9ZZTK/rVOSQ9FgkPLyd+GiiOH43I/y6nWqPVeCUA=; b=C3xwoveMTfA+OndyBgftOrnAdkOK43SmYDHAOKexrfk/z842/S1uuggP+ctVRgxHbZ gpArx5WsyOkUKL4JQJ9KnCjf1y5Tgw1/vZJEjwX15iC5c/xT+L6/BOhQ6bH7RNP14PYA kQX5FJEbUCNT5w9sNI3YG0YWjnj+Pvh5HWJ9+hAWfF5y06JcIE03Yboamw2bGyHap968 GWz/iJc48zJdSGS/qhpQwMAt9ZPcasRGW6N+6NMEdPujzP6K+uZAzdIhWDyC6rIZ49gV 6aPsg6BKyBrAM6GoQloZW3aUZLAQHoxbtS34STqTvk2ieUL6LKwObePt9KHZwVlI/z7e BX8A== X-Gm-Message-State: AO0yUKUCDsCJdym4yih1VGmCAWaDBcWvKk4Bk/Ue+x5pvKMusEW+Dh/z s57JPwHvGt9YGgatc/yzKKYrpQ== X-Google-Smtp-Source: AK7set8jPEuIAK54meSYftxPzkeOLlgD1AFufEs0U+ChwKL3GmHTKRlCjZqKCKGWnvv8IbOPRdMasg== X-Received: by 2002:aa7:dccb:0:b0:4ae:eae1:946a with SMTP id w11-20020aa7dccb000000b004aeeae1946amr20494081edu.13.1678271606164; Wed, 08 Mar 2023 02:33:26 -0800 (PST) Received: from ?IPV6:2a02:810d:15c0:828:ff33:9b14:bdd2:a3da? ([2a02:810d:15c0:828:ff33:9b14:bdd2:a3da]) by smtp.gmail.com with ESMTPSA id u25-20020a50a419000000b004bd6e3ed196sm7955780edb.86.2023.03.08.02.33.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Mar 2023 02:33:25 -0800 (PST) Message-ID: Date: Wed, 8 Mar 2023 11:33:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v1 11/11] media: starfive: enable building Content-Language: en-US To: Jack Zhu , Mauro Carvalho Chehab , Robert Foss , Todor Tomov , Rob Herring , Krzysztof Kozlowski , Maxime Ripard , Philipp Zabel Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, changhuang.liang@starfivetech.com References: <20230302091921.43309-1-jack.zhu@starfivetech.com> <20230302091921.43309-12-jack.zhu@starfivetech.com> <15b29a5b-29a1-8440-2b46-0c201c20defd@starfivetech.com> From: Krzysztof Kozlowski In-Reply-To: <15b29a5b-29a1-8440-2b46-0c201c20defd@starfivetech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On 07/03/2023 10:46, Jack Zhu wrote: > > > On 2023/3/3 16:43, Krzysztof Kozlowski wrote: >> On 02/03/2023 10:19, jack.zhu wrote: >>> Add Kconfig and Makefie, update platform/Kconfig and platform/Makefile >>> to enable building of the Starfive Camera subsystem driver. >>> >>> Signed-off-by: jack.zhu >>> --- >>> drivers/media/platform/Kconfig | 1 + >>> drivers/media/platform/Makefile | 1 + >>> drivers/media/platform/starfive/Kconfig | 18 ++++++++++++++++++ >>> drivers/media/platform/starfive/Makefile | 14 ++++++++++++++ >> >> This is not a separate commit. If it were, it would mean you just added >> dead code in previous commits, so why adding dead code in first place? >> > > The previous patches are made according to the module function.I think > it is helpful to explain the composition of the code file. > > stf_camss[patch 9] as a platform device manages all resources including > ISP and VIN. ISP/VIN [patch 7/8]as a sub-device needs to access other > resources managed by stf_camss.There is mutual reference between them. > Therefore, this patch is used for the overall compilation of the starfive > directory. So previous code is dead? Again, what is the reason for adding dead code? Mutual reference is not the answer. Best regards, Krzysztof