Re: [PATCH v19 2/6] soc: mediatek: mutex: add 8183 MUTEX MOD settings for MDP

CK Hu
2022-06-07T09:15:34Z

Hi, Moudy:

On Tue, 2022-05-31 at 13:52 +0800, Moudy Ho wrote:
> For the purpose of module independence, related settings should be
> moved
> from MDP to the corresponding driver.
> This patch adds 8183 MUTEX MOD settings for MDP.

Reviewed-by: CK Hu <ck.hu@mediatek.com>

>
> Signed-off-by: Moudy Ho <moudy.ho@mediatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>
> Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> ---
> drivers/soc/mediatek/mtk-mutex.c | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/drivers/soc/mediatek/mtk-mutex.c
> b/drivers/soc/mediatek/mtk-mutex.c
> index a3b054b33826..23009445adb4 100644
> --- a/drivers/soc/mediatek/mtk-mutex.c
> +++ b/drivers/soc/mediatek/mtk-mutex.c
> @@ -80,6 +80,15 @@
> #define MT8183_MUTEX_MOD_DISP_GAMMA0 16
> #define MT8183_MUTEX_MOD_DISP_DITHER0 17
>
> +#define MT8183_MUTEX_MOD_MDP_RDMA0 2
> +#define MT8183_MUTEX_MOD_MDP_RSZ0 4
> +#define MT8183_MUTEX_MOD_MDP_RSZ1 5
> +#define MT8183_MUTEX_MOD_MDP_TDSHP0 6
> +#define MT8183_MUTEX_MOD_MDP_WROT0 7
> +#define MT8183_MUTEX_MOD_MDP_WDMA 8
> +#define MT8183_MUTEX_MOD_MDP_AAL0 23
> +#define MT8183_MUTEX_MOD_MDP_CCORR0 24
> +
> #define MT8173_MUTEX_MOD_DISP_OVL0 11
> #define MT8173_MUTEX_MOD_DISP_OVL1 12
> #define MT8173_MUTEX_MOD_DISP_RDMA0 13
> @@ -273,6 +282,17 @@ static const unsigned int
> mt8183_mutex_mod[DDP_COMPONENT_ID_MAX] = {
> [DDP_COMPONENT_WDMA0] = MT8183_MUTEX_MOD_DISP_WDMA0,
> };
>
> +static const unsigned int mt8183_mutex_table_mod[MUTEX_MOD_IDX_MAX]
> = {
> + [MUTEX_MOD_IDX_MDP_RDMA0] = MT8183_MUTEX_MOD_MDP_RDMA0,
> + [MUTEX_MOD_IDX_MDP_RSZ0] = MT8183_MUTEX_MOD_MDP_RSZ0,
> + [MUTEX_MOD_IDX_MDP_RSZ1] = MT8183_MUTEX_MOD_MDP_RSZ1,
> + [MUTEX_MOD_IDX_MDP_TDSHP0] = MT8183_MUTEX_MOD_MDP_TDSHP0,
> + [MUTEX_MOD_IDX_MDP_WROT0] = MT8183_MUTEX_MOD_MDP_WROT0,
> + [MUTEX_MOD_IDX_MDP_WDMA] = MT8183_MUTEX_MOD_MDP_WDMA,
> + [MUTEX_MOD_IDX_MDP_AAL0] = MT8183_MUTEX_MOD_MDP_AAL0,
> + [MUTEX_MOD_IDX_MDP_CCORR0] = MT8183_MUTEX_MOD_MDP_CCORR0,
> +};
> +
> static const unsigned int mt8186_mutex_mod[DDP_COMPONENT_ID_MAX] = {
> [DDP_COMPONENT_AAL0] = MT8186_MUTEX_MOD_DISP_AAL0,
> [DDP_COMPONENT_CCORR] = MT8186_MUTEX_MOD_DISP_CCORR0,
> @@ -400,6 +420,7 @@ static const struct mtk_mutex_data
> mt8183_mutex_driver_data = {
> .mutex_sof = mt8183_mutex_sof,
> .mutex_mod_reg = MT8183_MUTEX0_MOD0,
> .mutex_sof_reg = MT8183_MUTEX0_SOF0,
> + .mutex_table_mod = mt8183_mutex_table_mod,
> .no_clk = true,
> };
>