From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1691B264A9E for ; Mon, 28 Jul 2025 13:48:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753710521; cv=none; b=NCVDrlPZcVlff8NaX+nJEYyXi29sC76/LHJwH9LPUxAtwU6+BNm4M4nzoRETLTMgE8EibfWQHanOvRgDGklqSMAFKK6x1PgPzuHAKjtSdbH86NxPiHByrHUu9JzscLHlwtFOIPW7xQQ/jNsQW7mMVXyqyCNbMvoffJoM82I9gbE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753710521; c=relaxed/simple; bh=7xYiPiwMPmCKG3Rb8ODYtqdcgFby8L44/hiz+sqse64=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bBSTy8UEGS1lB7sWCfc/4TGT/BVFlTVTxMn+r8p4/YgD8WqC+cQ+ZdNYMFYsnAH1PzauL4sqkYDHUuyH75cGMXUoeOYAFk3IhNNRSFHsZYFowLol5KO1z+8PgssEFGbcEiuQU1Go7vgYN14+fIfXLJXues1VLrZXjm/C+JuTKz4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=FBpsdSPC; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FBpsdSPC" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4561607166aso31108125e9.2 for ; Mon, 28 Jul 2025 06:48:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1753710518; x=1754315318; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GySiiFaaabiZQ4Il8d89HhZwj5V40q8muWzbkZdlYfk=; b=FBpsdSPChJxvCI0Q9iJdpiZQRbt1FGfCORhgABTx4FdGViq5ydA1VsG0HZWRxbOzVB MDVR5O2STGFzMFHa5urCAb42dbl2qJ4IAeoK89XVFkKNOFoNPb+BPSGyCKzttDC/SVoY sD2+FdFLFR5fhXPl8xywviBGdXI2QYc/FLfypsQl91l5m2ieEzjIqe3TPGCDA1MvIGbN dYFvRX0IR/vKbfuhw1WbEX4t82Jo4WepVAiXEPFkwcrwtBjAsFrHVkYsiGRue7tWuDzG JS/4dZo3O4saAoWTyZ0Ocwlp5UXeb//nJ2hi271raIF6oiKvRQJ7vBTrtrnWgOXJdP1W 3KhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753710518; x=1754315318; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GySiiFaaabiZQ4Il8d89HhZwj5V40q8muWzbkZdlYfk=; b=KQakb/QaoZJrcs14vnDPqM4KithFt1o+hJaBTj4/O7DJtXAet0otOHuhkavgnyAKo6 oHmyj4F85jMrfhTCCsvLJoBoOChxkI3YwJ8OSd3n6V+FE6YzlfjS+QqZn+9b8F67ufgN TEb5fp8AKJiNQBAa1pNgsid1dta8n7bvm0aII4+63qnYU7kvtbfMIuQ2DwtgkfuB98fk 8Cyxudj6KLQtxkTM3iMqZn51hRpXJTu/+MH0hcp3bE6XHkAjch5XldOTuAW6hVeFCwE2 DIblAuMoIEm0gI7pMER88ibIJrtQWVsKMP9tjgPKkRQlP1u5enxuRThUt6K8TYG8qbHc VneA== X-Forwarded-Encrypted: i=1; AJvYcCWjJvn7RZcQGv7cifYewBPvXb4m+t7kCUr0BUaJcHLnbPbzbXGATUp5BbUr6VMYM8GoXwV2TYBIWgRCTw==@vger.kernel.org X-Gm-Message-State: AOJu0Yw8SkG8HkEdOdSEH4AHVxwotNN3lRGa3smBKaL4SSOxdhcPDpWY BeWtz1t87CX5ikJbnUel/Yz1BJ6rA8jKXa3b+qIAdOPkd318dVcZ566+rOpGF8enW7A= X-Gm-Gg: ASbGncuRGGnlpJoFX6xomTb6CY+GkraNG98D0q7F3vKJ5t70EKPLpDlBxEcN6W4lHg4 SdE5UoCRkOUM/Bm1XO32irdZ17+nK30AGntjx8MWsQBClwbS8OdQdZxyRj9WK7D4cjOFXstIEgb YfgJqb9fs2dqUAqGLJiWK5btpTh1DqJIJUA1UoRf5VdxaoW5Z+0jO5XwogBPAlABkgM9Jj93jg9 oqZxWa6zgHPiNgUYHMZlcpoivUqPXQs2y99V1CV/vqu98RAh1aI72xmYftWf1gJQHVQEZiQMYXo 3pqmOnTtvSzl4TuKjDQUcw4WvRQ3GcO3gst14fnn5e3DFpvHmCBKCawyUAV1E3fVPVSMUN3o/XS IDVLzz6tHp10iXskXz5f23QvArekerQ0xAh/RJ3pqFN8t9ZBXZ4cvsrETFGigTpU= X-Google-Smtp-Source: AGHT+IFc0a/dVlHIMLVOyP9kKSGycnWL7vZKmINSvzq5X/lptb5FMCqb9vFSczBjeGl5NDbg5XFrqQ== X-Received: by 2002:a05:600c:4f14:b0:453:5c30:a1fd with SMTP id 5b1f17b1804b1-4587a6ab65cmr76381245e9.8.1753710518174; Mon, 28 Jul 2025 06:48:38 -0700 (PDT) Received: from [192.168.0.35] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4587ac66ed6sm100843815e9.28.2025.07.28.06.48.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Jul 2025 06:48:37 -0700 (PDT) Message-ID: Date: Mon, 28 Jul 2025 14:48:36 +0100 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/9] arm64: dts: qcom: sa8775p: Add support for camss To: Vikram Sharma , rfoss@kernel.org, todor.too@gmail.com, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, hverkuil-cisco@xs4all.nl, cros-qcom-dts-watchers@chromium.org, catalin.marinas@arm.com, will@kernel.org Cc: linux-arm-kernel@lists.infradead.org, quic_svankada@quicinc.com, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio References: <20250703171938.3606998-1-quic_vikramsa@quicinc.com> <20250703171938.3606998-5-quic_vikramsa@quicinc.com> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20250703171938.3606998-5-quic_vikramsa@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 03/07/2025 18:19, Vikram Sharma wrote: > Add changes to support the camera subsystem on the SA8775P. > > Co-developed-by: Suresh Vankadara > Signed-off-by: Suresh Vankadara > Signed-off-by: Vikram Sharma > Reviewed-by: Konrad Dybcio > --- > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 185 ++++++++++++++++++++++++++ > 1 file changed, 185 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > index fed34717460f..38ac33b082c8 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi > +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -4345,6 +4346,190 @@ videocc: clock-controller@abf0000 { > #power-domain-cells = <1>; > }; > > + camss: isp@ac7a000 { > + compatible = "qcom,sa8775p-camss"; > + > + reg = <0x0 0xac7a000 0x0 0x0f00>, > + <0x0 0xac7c000 0x0 0x0f00>, > + <0x0 0xac84000 0x0 0x0f00>, > + <0x0 0xac88000 0x0 0x0f00>, > + <0x0 0xac8c000 0x0 0x0f00>, > + <0x0 0xac90000 0x0 0x0f00>, > + <0x0 0xac94000 0x0 0x0f00>, > + <0x0 0xac78000 0x0 0x1000>, > + <0x0 0xac9c000 0x0 0x2000>, > + <0x0 0xac9e000 0x0 0x2000>, > + <0x0 0xaca0000 0x0 0x2000>, > + <0x0 0xaca2000 0x0 0x2000>, > + <0x0 0xacac000 0x0 0x0400>, > + <0x0 0xacad000 0x0 0x0400>, > + <0x0 0xacae000 0x0 0x0400>, > + <0x0 0xac4d000 0x0 0xd000>, > + <0x0 0xac5a000 0x0 0xd000>, > + <0x0 0xac85000 0x0 0x0d00>, > + <0x0 0xac89000 0x0 0x0d00>, > + <0x0 0xac8d000 0x0 0x0d00>, > + <0x0 0xac91000 0x0 0x0d00>, > + <0x0 0xac95000 0x0 0x0d00>; > + reg-names = "csid0", > + "csid1", > + "csid_lite0", > + "csid_lite1", > + "csid_lite2", > + "csid_lite3", > + "csid_lite4", > + "csid_wrapper", You can add my RB here with csid_wrapper as the first register bank. The reason for this is CSID wrapper contains a mux for the CSID register banks and so its the "boss" so to speak. Please update and then add my. Reviewed-by: Bryan O'Donoghue