From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8204EC7618A for ; Sat, 18 Mar 2023 23:28:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229579AbjCRX2C (ORCPT ); Sat, 18 Mar 2023 19:28:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229504AbjCRX2B (ORCPT ); Sat, 18 Mar 2023 19:28:01 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EFF41F4B3 for ; Sat, 18 Mar 2023 16:28:00 -0700 (PDT) Received: from [192.168.2.157] (109-252-120-116.nat.spd-mgts.ru [109.252.120.116]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dmitry.osipenko) by madras.collabora.co.uk (Postfix) with ESMTPSA id 4B6C86602FCA; Sat, 18 Mar 2023 23:27:58 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1679182079; bh=QDpYTfP5Nl+tyhNy705vCQcvMrV8hZy9oCjs9iAWG4g=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=AJSq8BJo0bfS84aE/ePOKY3WPloP1KpgI3DbNp4npS9TUBvG2yWswcOh+hx6tHnL0 NUU4d0ttF4Yquqabn8OuN6QFk9HL6axhJJm41ddatXql8y9/y/rV//GWSGWR+29GV2 KsDLOBR6w02KAr8/kumgm0j4tUuHgKntyQrLFVBkKzvpC+lV6KwTfo+IfCAXGE3jvY XBJT1e40dzVMq2AWZI2QJu6FVOuOdpxiJCMzAIm3zbrBOiLRoLA9qDyGS/E7ivfynH TBDP8mqDDiYcFReX7PYZ1vqbtAbfvpcJwSAq545RBCaxNwSBqG2znYgLxPxcyHh5D5 GgUFkyb56Oobg== Message-ID: Date: Sun, 19 Mar 2023 02:27:55 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [RFC 2/2] media: rkvdec: Add VP8 encoder Content-Language: en-US To: Daniel Almeida , Andrzej Pietrasiewicz , linux-media@vger.kernel.org Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Mauro Carvalho Chehab , Ezequiel Garcia , Philipp Zabel , Heiko Stuebner , kernel@collabora.com References: <20230309125651.23911-1-andrzej.p@collabora.com> <20230309125651.23911-3-andrzej.p@collabora.com> From: Dmitry Osipenko In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On 3/19/23 02:23, Daniel Almeida wrote: > Hi Andrzej, one thing I noticed while looking at this: > >> +struct hantro_vp8_entropy { >> + /* TODO: int32_t? */ >> + int32_t coeff_prob[4][8][3][11]; >> + int32_t coeff_prob_old[4][8][3][11]; >> + int32_t mv_prob[2][19]; >> + int32_t mv_prob_old[2][19]; >> + int32_t y_mode_prob[4]; >> + int32_t uv_mode_prob[3]; >> +}; >> > > > In VP9, probabilities are coded in the 0..255 range, so if you want to > save space here, you can go with uint8_t. BTW, there is a mix of int32_t and s32 in the code, the s32 is a correct choice. Similar for u8. Checkpatch --strict should warn about it all. -- Best regards, Dmitry