From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9ED4C678D5 for ; Wed, 8 Mar 2023 11:08:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229970AbjCHLII (ORCPT ); Wed, 8 Mar 2023 06:08:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229911AbjCHLIE (ORCPT ); Wed, 8 Mar 2023 06:08:04 -0500 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C55496600 for ; Wed, 8 Mar 2023 03:07:52 -0800 (PST) Received: by mail-ed1-x535.google.com with SMTP id da10so64225122edb.3 for ; Wed, 08 Mar 2023 03:07:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678273671; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XOXj33xYRyvRjw0tjSabpMsq8BekV0jE87PdwF1hf5k=; b=R8OvhGfCpynLB7ACnBVVELznEJTehRf3eH6xSvQMhNSO7ynQXFj1HJBIWnHY02ngwt d7zcal82tjKt7B5VOkXiJdfp7a/AexmxSwsSfeU4zeYiBA7mE0R7FAIBLOoSvQVPIGuU 0BYLAiL3beIxf1Rq8vmy/1/8pItinZi2PYjRM1fF1bi9xJ62zOztFv/IhmbP5cPh1PmF z1VIndGxokZGS6IGxu8sz4L8kz9ouy2fVEQfyysb0zi802LeCIWA2Ck7EpEshvoCPlmG e3YcyeOyfTULKvos6GONhx5NCAxcT77WFp/fzm0VN+xtvTtc5kEoF+dj6IcY+5YteS3K Z3Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678273671; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XOXj33xYRyvRjw0tjSabpMsq8BekV0jE87PdwF1hf5k=; b=zC0GwEz5QIhixnz4S4rRymp54yPAGB4g9tCkAmVsOyG7NyXxtpkG/uRZ8vi+ytRA5o X37/uGyqMsCytEaf6dLrbblE4KJUdbkNrtQ06Tlx0DbSe5ygdDrhCB/dTJno4j2VJ6+G 2mgvLyNHMKpGJ8779LcnyJkaq/YdbbsZUceBJ3U93wbEPRRFmGlfU21PyFZdgVkcv4Ft OqgstRDyM+qjSuSRrz//GpH45Z02Wi2DqSXK77hXswVVo5K6Fel4WHkeTrr0v4OCFCEX ZHohEMpfuKLQ+Lu5vsom4VqwbxaXb5670eu1VOrh1WkTp+FiWKFODLOZ4WfRRWaD7hwI KkaQ== X-Gm-Message-State: AO0yUKWad8bB60GrUeO+5Hv9nB6Ndi4Wajtpn4SIOTcddMMmDa0upmuo 0uz2MB4g8U8L1CXOnJk9Kmss3A== X-Google-Smtp-Source: AK7set/T6NXfefI3apYBnuhuHeGcGhWicxbthX9S5jDU/7gI1DQeiNmrE+SAWinienxvlJrfawpOtw== X-Received: by 2002:a17:906:3c56:b0:8ae:f19f:609e with SMTP id i22-20020a1709063c5600b008aef19f609emr18979469ejg.66.1678273671087; Wed, 08 Mar 2023 03:07:51 -0800 (PST) Received: from ?IPV6:2a02:810d:15c0:828:ff33:9b14:bdd2:a3da? ([2a02:810d:15c0:828:ff33:9b14:bdd2:a3da]) by smtp.gmail.com with ESMTPSA id p20-20020a17090653d400b008e97fdd6c7csm7283796ejo.129.2023.03.08.03.07.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Mar 2023 03:07:50 -0800 (PST) Message-ID: Date: Wed, 8 Mar 2023 12:07:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v1 11/11] media: starfive: enable building Content-Language: en-US To: Jack Zhu , Mauro Carvalho Chehab , Robert Foss , Todor Tomov , Rob Herring , Krzysztof Kozlowski , Maxime Ripard , Philipp Zabel Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, changhuang.liang@starfivetech.com References: <20230302091921.43309-1-jack.zhu@starfivetech.com> <20230302091921.43309-12-jack.zhu@starfivetech.com> <15b29a5b-29a1-8440-2b46-0c201c20defd@starfivetech.com> <05465184-5976-6cee-9925-e3712a1ea650@starfivetech.com> From: Krzysztof Kozlowski In-Reply-To: <05465184-5976-6cee-9925-e3712a1ea650@starfivetech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On 08/03/2023 12:03, Jack Zhu wrote: > > > On 2023/3/8 18:33, Krzysztof Kozlowski wrote: >> On 07/03/2023 10:46, Jack Zhu wrote: >>> >>> >>> On 2023/3/3 16:43, Krzysztof Kozlowski wrote: >>>> On 02/03/2023 10:19, jack.zhu wrote: >>>>> Add Kconfig and Makefie, update platform/Kconfig and platform/Makefile >>>>> to enable building of the Starfive Camera subsystem driver. >>>>> >>>>> Signed-off-by: jack.zhu >>>>> --- >>>>> drivers/media/platform/Kconfig | 1 + >>>>> drivers/media/platform/Makefile | 1 + >>>>> drivers/media/platform/starfive/Kconfig | 18 ++++++++++++++++++ >>>>> drivers/media/platform/starfive/Makefile | 14 ++++++++++++++ >>>> >>>> This is not a separate commit. If it were, it would mean you just added >>>> dead code in previous commits, so why adding dead code in first place? >>>> >>> >>> The previous patches are made according to the module function.I think >>> it is helpful to explain the composition of the code file. >>> >>> stf_camss[patch 9] as a platform device manages all resources including >>> ISP and VIN. ISP/VIN [patch 7/8]as a sub-device needs to access other >>> resources managed by stf_camss.There is mutual reference between them. >>> Therefore, this patch is used for the overall compilation of the starfive >>> directory. >> >> So previous code is dead? Again, what is the reason for adding dead >> code? Mutual reference is not the answer. >> > > Maybe I need to merge the previous patches[6-11] into one patch to submit? I gave you the recommendation in my first reply. What's wrong with it? Best regards, Krzysztof