From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28B83C2D0CE for ; Tue, 21 Jan 2020 11:51:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 08A312253D for ; Tue, 21 Jan 2020 11:51:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729384AbgAULvb (ORCPT ); Tue, 21 Jan 2020 06:51:31 -0500 Received: from outgoing6.flk.host-h.net ([188.40.0.77]:49631 "EHLO outgoing6.flk.host-h.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726052AbgAULva (ORCPT ); Tue, 21 Jan 2020 06:51:30 -0500 Received: from www31.flk1.host-h.net ([188.40.1.173]) by antispam2-flk1.host-h.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1its43-0002cm-Jb; Tue, 21 Jan 2020 13:51:25 +0200 Received: from roundcubeweb1.flk1.host-h.net ([138.201.244.33] helo=webmail9.konsoleh.co.za) by www31.flk1.host-h.net with esmtpa (Exim 4.89) (envelope-from ) id 1its3v-0002hz-ED; Tue, 21 Jan 2020 13:51:15 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 21 Jan 2020 13:51:14 +0200 From: Justin Swartz To: Ezequiel Garcia Cc: Jacob Chen , Mauro Carvalho Chehab , Heiko Stuebner , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] media: rockchip/rga: add rk3228-rga to rockchip_rga_match[] Organization: Rising Edge Consulting (Pty) Ltd. In-Reply-To: <241033bf82fc7e955dd20c0084bfd4f6fc9fc75b.camel@collabora.com> References: <20200120194158.25357-1-justin.swartz@risingedge.co.za> <241033bf82fc7e955dd20c0084bfd4f6fc9fc75b.camel@collabora.com> Message-ID: X-Sender: justin.swartz@risingedge.co.za User-Agent: Roundcube Webmail/1.2.3 X-Authenticated-Sender: justin.swartz@risingedge.co.za X-Virus-Scanned: Clear X-Originating-IP: 188.40.1.173 X-SpamExperts-Domain: risingedge.co.za X-SpamExperts-Username: Authentication-Results: host-h.net; auth=pass (login) smtp.auth=@risingedge.co.za X-SpamExperts-Outgoing-Class: ham X-SpamExperts-Outgoing-Evidence: Combined (0.02) X-Recommended-Action: accept X-Filter-ID: Mvzo4OR0dZXEDF/gcnlw0Xm17NJf4el5vffImWwWrhCpSDasLI4SayDByyq9LIhVmXu3SDcz3sFo J0gu11cVyETNWdUk1Ol2OGx3IfrIJKyP9eGNFz9TW9u+Jt8z2T3K7uDjV/sFUXQr+CDrNQuIHgQg mAX8Bxy/iUu0ThNZg0h/RxVysY5Ye6+GGw0VqdJD7ren9RtRNyYim5e3GD8LGfWrcbYvelpuN/Pk qhBpvAyWwieZyauFYqHkIbFa+ipFflSrcyn7M3A1M8P7YyCISF7Ax1jp5415hfbnHhmkWKwQ798N tjgwOHRNrKlsLSLsR2phe2H+VQ5drqtLHIQXdB2sPQC/ZXf7OFUBPjBV0jlmSIpVkQ8AaVZZyclT jN5hBEBytmRO9E6AWc5pLuLpWQAKNOWaeaRaLa7FmrJWQzsgLgGrRTwS6j1hXmKLDYUs37FOZ6yX Sqr+ov8uUflH8QTJsjWw5+0eZIpQIcK9yrSpnIazZEQP7rhBhxNqNx7Ljd12v0hRQV2TuWFKPYIZ hSoXjZRXPZeF/ozRyNShALRVmsv8saqL9IWYZ/7McakodiFVwaP90eVaqnDphEW4xGx2bCpzxgBv RJlZffR315YiXq0P29rzRb3/fujGPSO0ZjPN6GBtX9ob7G66M73K7lEBopH59S/bhUmo0Kkx+QUC X/JlYVPK+a5jKpRW4VkG9koSZx4AE7ErDJQIhG9sWvIZWUifSNHSdOCLRQ7jpnXnmAJSLoHk+mB7 rvqdepOw2titfOjo27VsmUXl5Dlu0Ez4hiPVrwbHSJw7Xp/7OsyH8g27Tr7mENICHJaR53upNsj0 ZNx9ROADUXTdQZTyOamR3KMXZiZ/EdUuc9x8TOdIW6qv7Prfdfuh2V6P2IH+fu/1ze9XG6SFbqNq ARXGm2iH1Wgh6RAenBR+licROGZLSOPJ7pouDn/lmAaZNciLnfvtO1PVtIUXLeqBTDtSvZT+XhI4 nesBJg1eKG706Wf90NysgdUUHBaOGnMZ3fVqqKS4K27k8O0AKLf9g2axxclWHXeuOCUCSaU4vgJw yjPlnmxH7Pd4xT6MyYGIdovMjseuwUIt8Ke1zYmTdImommOsTx6n1Q+SG7OG2yVRVB0+/K1/SK/q 4gW8qcSdMq7QhSk55ObUg7TpMbFmZ6g5Ky+1Stg9rJ7bhjXv2caQWgXrjuU3A3io6xJmD59iFVkb kXGPzFwfHhKt2wjdkKIWbyf+T8iepkOFBDDkCgKb9Tgwyo3k9+KsRmFMu5VQ9KBOovIJzflUDtG9 b8caIarEvU/OX3xYChUDPsYuWEJtniNfuGO37qWHEu6DA1YYHSc7 X-Report-Abuse-To: spam@antispammaster.host-h.net Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Ezequiel, On 2020-01-21 12:45, Ezequiel Garcia wrote: > On Mon, 2020-01-20 at 19:41 +0000, Justin Swartz wrote: > >> Add an entry to the rockchip_rga_match array for "rockchip,rk3228-rga" >> >> Signed-off-by: Justin Swartz >> --- >> drivers/media/platform/rockchip/rga/rga.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/media/platform/rockchip/rga/rga.c >> b/drivers/media/platform/rockchip/rga/rga.c >> index e9ff12b6b..268116cd5 100644 >> --- a/drivers/media/platform/rockchip/rga/rga.c >> +++ b/drivers/media/platform/rockchip/rga/rga.c >> @@ -956,6 +956,9 @@ static const struct dev_pm_ops rga_pm = { >> >> static const struct of_device_id rockchip_rga_match[] = { >> { >> + .compatible = "rockchip,rk3228-rga", >> + }, > > Unless you need to tune something in the driver > specifically for rk3228, then you don't need a > new compatible string. > > As the name implies, it's just a "compatible", > so you may simply declare your rga dts node as > compatible to "rockchip,rk3288-rga". > > (Of course, this means we shouldn't have added > the rk3399 compatible string.) Thank you for the clarification.