From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 546CE3A4517 for ; Thu, 2 Apr 2026 12:00:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775131228; cv=none; b=YtB0yQP6Mmf038ZIIaGn6fuSW0Au+y4YPy0Z0+0LRcei2LHtaZ6UYKkfoQPgfOacbPXW+f5tOhDrwfu3WFopT2M+xxHbbV0H3T6/yg2IwjInza/HWKiMYboafLJKhqbavM+g8WKwTyB8jg7d9Du/h6iiXPR8x8ZpqePQHNa9488= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775131228; c=relaxed/simple; bh=YQTNOWULEKJu7QXVb7cw5H0wOpBwIYQa4Pbqcfq12MA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DPHHH9Te570wbNhqmCdUqgcAVm+b3ftsF5ah2swsK7UrDEzn5QLRBNnC4RsNxDqI6xzArj1cgXudGBkss7j5u2cwEG5Z0QzuJWM5qNaMgptJDjfdWeqBxaLm72/zmhVAlXGSvU3B9Isz9blxiAfBwtFNuzXyysTprycVcIWtN9c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=eOt7mu+6; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="eOt7mu+6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1775131218; bh=YQTNOWULEKJu7QXVb7cw5H0wOpBwIYQa4Pbqcfq12MA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=eOt7mu+6YauexdjkZRLuk/FP/kcs9OSYwHGl5zvMUBfnmpXTZWYBzDOv6YBwp2ssq PSpzGYjIy4MiWujlmmMeha1SuO3KkzcXshxiIK3Ev76tIgy4ypkBH1S1N4L/6LSkEa Hr1XtVi2YY7NeHHKbbK2YUknUxyMtoQl0cw18Zci659c6HGxP5TJigGIoxWC2qugKA J2SuITgqvMm0HaX3YqPD1bMFQQ04CVMZIObJWHwmmqgCas8egptveQhJcp5rlJ2hkk KtjeXdEJcKRYS7eIVtVHAw9jrkJF1osmb+htmenUq2B90Z8yuUSZaipvXRYA3mtyIy z81p2ZQ08DWXg== Received: from [10.40.0.100] (185-67-175-126.lampert.tv [185.67.175.126]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: mriesch) by bali.collaboradmins.com (Postfix) with ESMTPSA id ABA0617E66B7; Thu, 2 Apr 2026 14:00:17 +0200 (CEST) Message-ID: Date: Thu, 2 Apr 2026 14:00:17 +0200 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 11/22] media: v4l2-subdev: Allow accessing routes with STREAMS client capability To: Sakari Ailus , linux-media@vger.kernel.org Cc: hans@jjverkuil.nl, laurent.pinchart@ideasonboard.com, Prabhakar , Kate Hsuan , Dave Stevenson , Tommaso Merciai , Benjamin Mugnier , Sylvain Petinot , Christophe JAILLET , Julien Massot , Naushir Patuck , "Yan, Dongcheng" , "Cao, Bingbu" , "Qiu, Tian Shu" , Stefan Klug , Mirela Rabulea , =?UTF-8?Q?Andr=C3=A9_Apitzsch?= , Heimir Thor Sverrisson , Kieran Bingham , Mehdi Djait , Ricardo Ribalda Delgado , Hans de Goede , Jacopo Mondi , Tomi Valkeinen , David Plowman , "Yu, Ong Hock" , "Ng, Khai Wen" , Jai Luthra References: <20260325105818.1176816-1-sakari.ailus@linux.intel.com> <20260325105818.1176816-12-sakari.ailus@linux.intel.com> Content-Language: en-US From: Michael Riesch In-Reply-To: <20260325105818.1176816-12-sakari.ailus@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Sakari, On 3/25/26 11:58, Sakari Ailus wrote: > Disable access to routes when the STREAMS client capability bit isn't set. > Routes aren't relevant otherwise anyway. > > Signed-off-by: Sakari Ailus > Reviewed-by: Jacopo Mondi > Reviewed-by Reviewed-by: Michael Riesch Thanks and best regards, Michael > --- > drivers/media/v4l2-core/v4l2-subdev.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c > index f8fde395a53a..647587c0499a 100644 > --- a/drivers/media/v4l2-core/v4l2-subdev.c > +++ b/drivers/media/v4l2-core/v4l2-subdev.c > @@ -1020,6 +1020,9 @@ static long subdev_do_ioctl(struct file *file, unsigned int cmd, void *arg, > if (!(sd->flags & V4L2_SUBDEV_FL_STREAMS)) > return -ENOIOCTLCMD; > > + if (!client_supports_streams) > + return -EINVAL; > + > memset(routing->reserved, 0, sizeof(routing->reserved)); > > copy_routes_state_to_routing(routing, state); > @@ -1041,6 +1044,9 @@ static long subdev_do_ioctl(struct file *file, unsigned int cmd, void *arg, > if (!(sd->flags & V4L2_SUBDEV_FL_STREAMS)) > return -ENOIOCTLCMD; > > + if (!client_supports_streams) > + return -EINVAL; > + > if (routing->which != V4L2_SUBDEV_FORMAT_TRY && ro_subdev) > return -EPERM; >