linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 4/4] media: i2c: og0ve1b: Add support for OmniVision OG0VA1B
Date: Thu, 10 Sep 2026 16:16:41 +0800	[thread overview]
Message-ID: <f2116a5a-5144-4f82-9b9a-ea343cb2ff1e@oss.qualcomm.com> (raw)
In-Reply-To: <ap_vVZ_Z7tJNcAYY@kekkonen.localdomain>

Hi Sakari,

On 9/8/2026 7:19 PM, Sakari Ailus wrote:
> Hi Wenmeng,
> 
> On Tue, Sep 01, 2026 at 03:40:07PM +0800, Wenmeng Liu wrote:
>> The OmniVision OG0VA1B is a monochrome image sensor closely related to
>> the OG0VE1B. It shares the SCCB control interface, power supplies and
>> the single-lane MIPI D-PHY description, and differs in its chip id, the
>> test pattern register, the register programming and the output format
>> (10-bit RAW instead of 8-bit).
>>
>> Add an og0ve1b_sensor_data entry describing the OG0VA1B together with
>> its 640x480 60fps register sequence.
>>
>> Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
>> Tested-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> # og0ve1b
>> Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
>> ---
>>   drivers/media/i2c/og0ve1b.c | 278 ++++++++++++++++++++++++++++++++++++++++++--
>>   1 file changed, 266 insertions(+), 12 deletions(-)
>>
>> diff --git a/drivers/media/i2c/og0ve1b.c b/drivers/media/i2c/og0ve1b.c
>> index f560d5d90fda94abf4bc622c5e4f861b078b811f..7b8555a833c255652204d5f4c87c8d701c3008e6 100644
>> --- a/drivers/media/i2c/og0ve1b.c
>> +++ b/drivers/media/i2c/og0ve1b.c
>> @@ -15,10 +15,14 @@
>>   #include <media/v4l2-device.h>
>>   #include <media/v4l2-fwnode.h>
>>   
>> +#define OG0VA1B_LINK_FREQ_480MHZ	(480 * HZ_PER_MHZ)
>> +#define OG0VA1B_MCLK_FREQ_19_2MHZ	(19200 * HZ_PER_KHZ)
>> +
>>   #define OG0VE1B_LINK_FREQ_500MHZ	(500 * HZ_PER_MHZ)
>>   #define OG0VE1B_MCLK_FREQ_24MHZ		(24 * HZ_PER_MHZ)
>>   
>> -#define OG0VE1B_REG_CHIP_ID		CCI_REG24(0x300a)
>> +#define OG0V_REG_CHIP_ID		CCI_REG24(0x300a)
>> +#define OG0VA1B_CHIP_ID			0xc75641
>>   #define OG0VE1B_CHIP_ID			0xc75645
>>   
>>   #define OG0VE1B_REG_MODE_SELECT		CCI_REG8(0x0100)
>> @@ -46,12 +50,18 @@
>>   #define OG0VE1B_REG_VTS			CCI_REG16(0x380e)
> 
> What about this register? Is it the same for both? If so, shouldn't you
> rename this one as well?
> 

Yes, it is shared by both sensors as well.I'll rename it.

>>   #define OG0VE1B_VTS_MAX			0xffff
>>   
>> -/* Test pattern */
>> +/* Test pattern - OG0VA1B uses 0x5100, OG0VE1B uses 0x5e00 */
>> +#define OG0VA1B_REG_TEST_PATTERN	CCI_REG8(0x5100)
>> +#define OG0VA1B_TEST_PATTERN_BAR_SHIFT	2
>>   #define OG0VE1B_REG_PRE_ISP		CCI_REG8(0x5e00)
>>   #define OG0VE1B_TEST_PATTERN_ENABLE	BIT(7)
>>   
>>   #define to_og0ve1b(_sd)			container_of(_sd, struct og0ve1b, sd)
>>   
>> +static const s64 og0va1b_link_freq_menu[] = {
>> +	OG0VA1B_LINK_FREQ_480MHZ,
>> +};
>> +
>>   static const s64 og0ve1b_link_freq_menu[] = {
>>   	OG0VE1B_LINK_FREQ_500MHZ,
>>   };
>> @@ -74,15 +84,31 @@ struct og0ve1b_mode {
>>   struct og0ve1b;
>>   
>>   struct og0ve1b_sensor_data {
>> +	const char *name;
>>   	u64 chip_id;
>>   	unsigned long mclk_freq;
>>   	int (*enable_test_pattern)(struct og0ve1b *og0ve1b, u32 pattern);
>> +	const char * const *test_pattern_menu;
>> +	int num_test_patterns;
>> +	bool cache_test_pattern_reg;
>> +	/* Exposure register unit: OG0VE1B 1/16 line (4), OG0VA1B whole lines (0). */
>> +	unsigned int exposure_shift;
>> +	/* Pixel rate multiplier: OG0VA1B uses CSI-2 DDR (2), OG0VE1B keeps 1. */
>> +	unsigned int pixel_rate_mul;
>>   	const s64 *link_freq_menu;
>>   	int num_link_freqs;
> 
> Rearranging these (in a previous patch probably) would save some memory.
> 

ACK. Thanks for you review.

Wenmeng

>>   	const struct og0ve1b_mode *modes;
>>   	int num_modes;
>>   };
>>   
>> +static const char * const og0va1b_test_pattern_menu[] = {
>> +	"Disabled",
>> +	"Standard Test Bar",
>> +	"Top-Bottom Darker Test Bar",
>> +	"Right-Left Darker Test Bar",
>> +	"Bottom-Top Darker Test Bar",
>> +};
>> +
>>   static const char * const og0ve1b_test_pattern_menu[] = {
>>   	"Disabled",
>>   	"Standard Test Bar",
>> @@ -116,6 +142,196 @@ struct og0ve1b {
>>   	const struct og0ve1b_sensor_data *data;
>>   };
>>   
>> +static const struct cci_reg_sequence og0va1b_640x480_60fps_mode[] = {
>> +	{ CCI_REG8(0x0302), 0x31 },
>> +	{ CCI_REG8(0x0303), 0x02 },
>> +	{ CCI_REG8(0x0304), 0x01 },
>> +	{ CCI_REG8(0x0305), 0x90 },
>> +	{ CCI_REG8(0x0306), 0x00 },
>> +	{ CCI_REG8(0x0323), 0x02 },
>> +	{ CCI_REG8(0x0325), 0x68 },
>> +	{ CCI_REG8(0x0326), 0xd8 },
>> +	{ CCI_REG8(0x3006), 0x0e },
>> +	{ CCI_REG8(0x300d), 0x08 },
>> +	{ CCI_REG8(0x3018), 0xf0 },
>> +	{ CCI_REG8(0x301c), 0xf0 },
>> +	{ CCI_REG8(0x3020), 0x20 },
>> +	{ CCI_REG8(0x3040), 0x0f },
>> +	{ CCI_REG8(0x3022), 0x01 },
>> +	{ CCI_REG8(0x3107), 0x40 },
>> +	{ CCI_REG8(0x3216), 0x01 },
>> +	{ CCI_REG8(0x3217), 0x00 },
>> +	{ CCI_REG8(0x3218), 0xc0 },
>> +	{ CCI_REG8(0x3219), 0x55 },
>> +	{ CCI_REG8(0x3506), 0x01 },
>> +	{ CCI_REG8(0x3507), 0x50 },
>> +	{ CCI_REG8(0x3508), 0x01 },
>> +	{ CCI_REG8(0x3509), 0x00 },
>> +	{ CCI_REG8(0x350a), 0x01 },
>> +	{ CCI_REG8(0x350b), 0x00 },
>> +	{ CCI_REG8(0x350c), 0x00 },
>> +	{ CCI_REG8(0x3541), 0x00 },
>> +	{ CCI_REG8(0x3542), 0x40 },
>> +	{ CCI_REG8(0x3605), 0x90 },
>> +	{ CCI_REG8(0x3606), 0x41 },
>> +	{ CCI_REG8(0x3612), 0x00 },
>> +	{ CCI_REG8(0x3620), 0x08 },
>> +	{ CCI_REG8(0x3630), 0x17 },
>> +	{ CCI_REG8(0x3631), 0x99 },
>> +	{ CCI_REG8(0x3639), 0x88 },
>> +	{ CCI_REG8(0x3668), 0x00 },
>> +	{ CCI_REG8(0x3674), 0x00 },
>> +	{ CCI_REG8(0x3677), 0x3f },
>> +	{ CCI_REG8(0x368f), 0x06 },
>> +	{ CCI_REG8(0x36a2), 0x19 },
>> +	{ CCI_REG8(0x36a4), 0xf1 },
>> +	{ CCI_REG8(0x36a5), 0x2d },
>> +	{ CCI_REG8(0x3706), 0x30 },
>> +	{ CCI_REG8(0x370d), 0x72 },
>> +	{ CCI_REG8(0x3713), 0x86 },
>> +	{ CCI_REG8(0x3715), 0x03 },
>> +	{ CCI_REG8(0x3716), 0x00 },
>> +	{ CCI_REG8(0x376d), 0x24 },
>> +	{ CCI_REG8(0x3770), 0x3a },
>> +	{ CCI_REG8(0x3778), 0x00 },
>> +	{ CCI_REG8(0x37a8), 0x03 },
>> +	{ CCI_REG8(0x37a9), 0x00 },
>> +	{ CCI_REG8(0x37df), 0x7d },
>> +	{ CCI_REG8(0x3800), 0x00 },
>> +	{ CCI_REG8(0x3801), 0x00 },
>> +	{ CCI_REG8(0x3802), 0x00 },
>> +	{ CCI_REG8(0x3803), 0x00 },
>> +	{ CCI_REG8(0x3804), 0x02 },
>> +	{ CCI_REG8(0x3805), 0x8f },
>> +	{ CCI_REG8(0x3806), 0x01 },
>> +	{ CCI_REG8(0x3807), 0xef },
>> +	{ CCI_REG8(0x3808), 0x02 },
>> +	{ CCI_REG8(0x3809), 0x80 },
>> +	{ CCI_REG8(0x380a), 0x01 },
>> +	{ CCI_REG8(0x380b), 0xe0 },
>> +	{ CCI_REG8(0x380c), 0x01 },
>> +	{ CCI_REG8(0x380d), 0x78 },
>> +	{ CCI_REG8(0x380e), 0x08 },
>> +	{ CCI_REG8(0x380f), 0x30 },
>> +	{ CCI_REG8(0x3810), 0x00 },
>> +	{ CCI_REG8(0x3811), 0x08 },
>> +	{ CCI_REG8(0x3812), 0x00 },
>> +	{ CCI_REG8(0x3813), 0x08 },
>> +	{ CCI_REG8(0x3814), 0x11 },
>> +	{ CCI_REG8(0x3815), 0x11 },
>> +	{ CCI_REG8(0x3816), 0x00 },
>> +	{ CCI_REG8(0x3817), 0x01 },
>> +	{ CCI_REG8(0x3818), 0x00 },
>> +	{ CCI_REG8(0x3819), 0x05 },
>> +	{ CCI_REG8(0x3820), 0x40 },
>> +	{ CCI_REG8(0x3821), 0x04 },
>> +	{ CCI_REG8(0x3823), 0x00 },
>> +	{ CCI_REG8(0x3826), 0x00 },
>> +	{ CCI_REG8(0x3827), 0x00 },
>> +	{ CCI_REG8(0x382b), 0x52 },
>> +	{ CCI_REG8(0x384a), 0xa2 },
>> +	{ CCI_REG8(0x3858), 0x00 },
>> +	{ CCI_REG8(0x3859), 0x00 },
>> +	{ CCI_REG8(0x3860), 0x00 },
>> +	{ CCI_REG8(0x3861), 0x00 },
>> +	{ CCI_REG8(0x3866), 0x0c },
>> +	{ CCI_REG8(0x3867), 0x07 },
>> +	{ CCI_REG8(0x3884), 0x00 },
>> +	{ CCI_REG8(0x3885), 0x08 },
>> +	{ CCI_REG8(0x3888), 0x50 },
>> +	{ CCI_REG8(0x3893), 0x6c },
>> +	{ CCI_REG8(0x3898), 0x00 },
>> +	{ CCI_REG8(0x389a), 0x04 },
>> +	{ CCI_REG8(0x389b), 0x01 },
>> +	{ CCI_REG8(0x389c), 0x0b },
>> +	{ CCI_REG8(0x389d), 0xdc },
>> +	{ CCI_REG8(0x38b1), 0x04 },
>> +	{ CCI_REG8(0x38b2), 0x00 },
>> +	{ CCI_REG8(0x38b3), 0x08 },
>> +	{ CCI_REG8(0x38c1), 0x46 },
>> +	{ CCI_REG8(0x38c9), 0x02 },
>> +	{ CCI_REG8(0x38d4), 0x06 },
>> +	{ CCI_REG8(0x38d5), 0x5a },
>> +	{ CCI_REG8(0x38d6), 0x08 },
>> +	{ CCI_REG8(0x38d7), 0x3a },
>> +	{ CCI_REG8(0x391f), 0x00 },
>> +	{ CCI_REG8(0x3920), 0xaa },
>> +	{ CCI_REG8(0x3921), 0x00 },
>> +	{ CCI_REG8(0x3922), 0x00 },
>> +	{ CCI_REG8(0x3923), 0x00 },
>> +	{ CCI_REG8(0x3924), 0x00 },
>> +	{ CCI_REG8(0x3925), 0x00 },
>> +	{ CCI_REG8(0x3926), 0x00 },
>> +	{ CCI_REG8(0x3927), 0x00 },
>> +	{ CCI_REG8(0x3928), 0x10 },
>> +	{ CCI_REG8(0x3929), 0x01 },
>> +	{ CCI_REG8(0x392a), 0xb4 },
>> +	{ CCI_REG8(0x392b), 0x00 },
>> +	{ CCI_REG8(0x392c), 0x10 },
>> +	{ CCI_REG8(0x392d), 0x01 },
>> +	{ CCI_REG8(0x392e), 0x78 },
>> +	{ CCI_REG8(0x392f), 0x4a },
>> +	{ CCI_REG8(0x391e), 0x01 },
>> +	{ CCI_REG8(0x389f), 0x08 },
>> +	{ CCI_REG8(0x38a0), 0x00 },
>> +	{ CCI_REG8(0x38a1), 0x00 },
>> +	{ CCI_REG8(0x3a06), 0x06 },
>> +	{ CCI_REG8(0x3a07), 0x78 },
>> +	{ CCI_REG8(0x3a08), 0x08 },
>> +	{ CCI_REG8(0x3a09), 0x80 },
>> +	{ CCI_REG8(0x3a52), 0x00 },
>> +	{ CCI_REG8(0x3a53), 0x01 },
>> +	{ CCI_REG8(0x3a54), 0x0c },
>> +	{ CCI_REG8(0x3a55), 0x04 },
>> +	{ CCI_REG8(0x3a58), 0x0c },
>> +	{ CCI_REG8(0x3a59), 0x04 },
>> +	{ CCI_REG8(0x4000), 0xcf },
>> +	{ CCI_REG8(0x4003), 0x40 },
>> +	{ CCI_REG8(0x4008), 0x04 },
>> +	{ CCI_REG8(0x4009), 0x13 },
>> +	{ CCI_REG8(0x400a), 0x02 },
>> +	{ CCI_REG8(0x400b), 0x34 },
>> +	{ CCI_REG8(0x4010), 0x71 },
>> +	{ CCI_REG8(0x4042), 0xc3 },
>> +	{ CCI_REG8(0x4306), 0x04 },
>> +	{ CCI_REG8(0x4307), 0x12 },
>> +	{ CCI_REG8(0x4500), 0x70 },
>> +	{ CCI_REG8(0x4509), 0x00 },
>> +	{ CCI_REG8(0x450b), 0x83 },
>> +	{ CCI_REG8(0x4604), 0x68 },
>> +	{ CCI_REG8(0x481b), 0x44 },
>> +	{ CCI_REG8(0x481f), 0x30 },
>> +	{ CCI_REG8(0x4823), 0x44 },
>> +	{ CCI_REG8(0x4825), 0x35 },
>> +	{ CCI_REG8(0x4837), 0x11 },
>> +	{ CCI_REG8(0x4f00), 0x04 },
>> +	{ CCI_REG8(0x4f10), 0x04 },
>> +	{ CCI_REG8(0x4f21), 0x01 },
>> +	{ CCI_REG8(0x4f22), 0x00 },
>> +	{ CCI_REG8(0x4f23), 0x54 },
>> +	{ CCI_REG8(0x4f24), 0x51 },
>> +	{ CCI_REG8(0x4f25), 0x41 },
>> +	{ CCI_REG8(0x5000), 0x3f },
>> +	{ CCI_REG8(0x5001), 0x80 },
>> +	{ CCI_REG8(0x500a), 0x00 },
>> +	{ CCI_REG8(0x5100), 0x00 },
>> +	{ CCI_REG8(0x5111), 0x20 },
>> +};
>> +
>> +static const struct og0ve1b_mode og0va1b_supported_modes[] = {
>> +	{
>> +		.width = 640,
>> +		.height = 480,
>> +		.hts = 752,
>> +		.vts = 2096,
>> +		.code = MEDIA_BUS_FMT_Y10_1X10,
>> +		.reg_list = {
>> +			.regs = og0va1b_640x480_60fps_mode,
>> +			.num_regs = ARRAY_SIZE(og0va1b_640x480_60fps_mode),
>> +		},
>> +	},
>> +};
>> +
>>   static const struct cci_reg_sequence og0ve1b_640x480_120fps_mode[] = {
>>   	{ CCI_REG8(0x30a0), 0x02 },
>>   	{ CCI_REG8(0x30a1), 0x00 },
>> @@ -276,6 +492,17 @@ static const struct og0ve1b_mode og0ve1b_supported_modes[] = {
>>   	},
>>   };
>>   
>> +static int og0va1b_enable_test_pattern(struct og0ve1b *og0ve1b, u32 pattern)
>> +{
>> +	u64 val = 0;
>> +
>> +	if (pattern)
>> +		val = ((pattern - 1) << OG0VA1B_TEST_PATTERN_BAR_SHIFT) |
>> +		      OG0VE1B_TEST_PATTERN_ENABLE;
>> +
>> +	return cci_write(og0ve1b->regmap, OG0VA1B_REG_TEST_PATTERN, val, NULL);
>> +}
>> +
>>   static int og0ve1b_enable_test_pattern(struct og0ve1b *og0ve1b, u32 pattern)
>>   {
>>   	u64 val = og0ve1b->pre_isp;
>> @@ -288,10 +515,31 @@ static int og0ve1b_enable_test_pattern(struct og0ve1b *og0ve1b, u32 pattern)
>>   	return cci_write(og0ve1b->regmap, OG0VE1B_REG_PRE_ISP, val, NULL);
>>   }
>>   
>> +static const struct og0ve1b_sensor_data og0va1b_data = {
>> +	.name = "og0va1b",
>> +	.chip_id = OG0VA1B_CHIP_ID,
>> +	.mclk_freq = OG0VA1B_MCLK_FREQ_19_2MHZ,
>> +	.enable_test_pattern = og0va1b_enable_test_pattern,
>> +	.test_pattern_menu = og0va1b_test_pattern_menu,
>> +	.num_test_patterns = ARRAY_SIZE(og0va1b_test_pattern_menu),
>> +	.exposure_shift = 0,
>> +	.pixel_rate_mul = 2,
>> +	.link_freq_menu = og0va1b_link_freq_menu,
>> +	.num_link_freqs = ARRAY_SIZE(og0va1b_link_freq_menu),
>> +	.modes = og0va1b_supported_modes,
>> +	.num_modes = ARRAY_SIZE(og0va1b_supported_modes),
>> +};
>> +
>>   static const struct og0ve1b_sensor_data og0ve1b_data = {
>> +	.name = "og0ve1b",
>>   	.chip_id = OG0VE1B_CHIP_ID,
>>   	.mclk_freq = OG0VE1B_MCLK_FREQ_24MHZ,
>>   	.enable_test_pattern = og0ve1b_enable_test_pattern,
>> +	.test_pattern_menu = og0ve1b_test_pattern_menu,
>> +	.num_test_patterns = ARRAY_SIZE(og0ve1b_test_pattern_menu),
>> +	.cache_test_pattern_reg = true,
>> +	.exposure_shift = 4,
>> +	.pixel_rate_mul = 1,
>>   	.link_freq_menu = og0ve1b_link_freq_menu,
>>   	.num_link_freqs = ARRAY_SIZE(og0ve1b_link_freq_menu),
>>   	.modes = og0ve1b_supported_modes,
>> @@ -332,7 +580,8 @@ static int og0ve1b_set_ctrl(struct v4l2_ctrl *ctrl)
>>   		break;
>>   	case V4L2_CID_EXPOSURE:
>>   		ret = cci_write(og0ve1b->regmap, OG0VE1B_REG_EXPOSURE,
>> -				ctrl->val << 4, NULL);
>> +				ctrl->val << og0ve1b->data->exposure_shift,
>> +				NULL);
>>   		break;
>>   	case V4L2_CID_VBLANK:
>>   		ret = cci_write(og0ve1b->regmap, OG0VE1B_REG_VTS,
>> @@ -360,7 +609,7 @@ static s64 og0ve1b_pixel_rate(const struct og0ve1b_sensor_data *data)
>>   	const struct og0ve1b_mode *mode = &data->modes[0];
>>   	unsigned int bpp = mode->code == MEDIA_BUS_FMT_Y8_1X8 ? 8 : 10;
>>   
>> -	return div_u64(data->link_freq_menu[0], bpp);
>> +	return div_u64(data->link_freq_menu[0] * data->pixel_rate_mul, bpp);
>>   }
>>   
>>   static int og0ve1b_init_controls(struct og0ve1b *og0ve1b)
>> @@ -413,8 +662,8 @@ static int og0ve1b_init_controls(struct og0ve1b *og0ve1b)
>>   
>>   	v4l2_ctrl_new_std_menu_items(ctrl_hdlr, &og0ve1b_ctrl_ops,
>>   				     V4L2_CID_TEST_PATTERN,
>> -				     ARRAY_SIZE(og0ve1b_test_pattern_menu) - 1,
>> -				     0, 0, og0ve1b_test_pattern_menu);
>> +				     data->num_test_patterns - 1,
>> +				     0, 0, data->test_pattern_menu);
>>   
>>   	if (ctrl_hdlr->error)
>>   		return ctrl_hdlr->error;
>> @@ -621,7 +870,7 @@ static int og0ve1b_identify_sensor(struct og0ve1b *og0ve1b)
>>   	u64 val;
>>   	int ret;
>>   
>> -	ret = cci_read(og0ve1b->regmap, OG0VE1B_REG_CHIP_ID, &val, NULL);
>> +	ret = cci_read(og0ve1b->regmap, OG0V_REG_CHIP_ID, &val, NULL);
>>   	if (ret) {
>>   		dev_err(og0ve1b->dev, "failed to read chip id: %d\n", ret);
>>   		return ret;
>> @@ -633,10 +882,12 @@ static int og0ve1b_identify_sensor(struct og0ve1b *og0ve1b)
>>   		return -ENODEV;
>>   	}
>>   
>> -	ret = cci_read(og0ve1b->regmap, OG0VE1B_REG_PRE_ISP,
>> -		       &og0ve1b->pre_isp, NULL);
>> -	if (ret)
>> -		dev_err(og0ve1b->dev, "failed to read pre_isp: %d\n", ret);
>> +	if (og0ve1b->data->cache_test_pattern_reg) {
>> +		ret = cci_read(og0ve1b->regmap, OG0VE1B_REG_PRE_ISP,
>> +			       &og0ve1b->pre_isp, NULL);
>> +		if (ret)
>> +			dev_err(og0ve1b->dev, "failed to read pre_isp: %d\n", ret);
>> +	}
>>   
>>   	return ret;
>>   }
>> @@ -732,6 +983,8 @@ static int og0ve1b_probe(struct i2c_client *client)
>>   		return -ENODEV;
>>   
>>   	v4l2_i2c_subdev_init(&og0ve1b->sd, client, &og0ve1b_subdev_ops);
>> +	v4l2_i2c_subdev_set_name(&og0ve1b->sd, client,
>> +				 og0ve1b->data->name, NULL);
>>   
>>   	og0ve1b->regmap = devm_cci_regmap_init_i2c(client, 16);
>>   	if (IS_ERR(og0ve1b->regmap))
>> @@ -863,6 +1116,7 @@ static const struct dev_pm_ops og0ve1b_pm_ops = {
>>   };
>>   
>>   static const struct of_device_id og0ve1b_of_match[] = {
>> +	{ .compatible = "ovti,og0va1b", .data = &og0va1b_data },
>>   	{ .compatible = "ovti,og0ve1b", .data = &og0ve1b_data },
>>   	{ /* sentinel */ }
>>   };
>> @@ -881,5 +1135,5 @@ static struct i2c_driver og0ve1b_i2c_driver = {
>>   module_i2c_driver(og0ve1b_i2c_driver);
>>   
>>   MODULE_AUTHOR("Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>");
>> -MODULE_DESCRIPTION("OmniVision OG0VE1B sensor driver");
>> +MODULE_DESCRIPTION("OmniVision OG0VE1B/OG0VA1B sensor driver");
>>   MODULE_LICENSE("GPL");
>>
> 


      reply	other threads:[~2026-09-10  8:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-01  7:40 [PATCH v6 0/4] media: i2c: Add OmniVision OG0VA1B camera sensor driver Wenmeng Liu
2026-09-01  7:40 ` [PATCH v6 1/4] dt-bindings: media: i2c: og0ve1b: Add OmniVision OG0VA1B camera sensor Wenmeng Liu
2026-09-01  7:40 ` [PATCH v6 2/4] media: i2c: og0ve1b: Use monochrome-appropriate test pattern name Wenmeng Liu
2026-09-08 11:14   ` Sakari Ailus
2026-09-10  7:34     ` Wenmeng Liu
2026-09-01  7:40 ` [PATCH v6 3/4] media: i2c: og0ve1b: Introduce per-sensor data structure Wenmeng Liu
2026-09-08 11:22   ` Sakari Ailus
2026-09-10  8:14     ` Wenmeng Liu
2026-09-10  8:28       ` Sakari Ailus
2026-09-01  7:40 ` [PATCH v6 4/4] media: i2c: og0ve1b: Add support for OmniVision OG0VA1B Wenmeng Liu
2026-09-08 11:19   ` Sakari Ailus
2026-09-10  8:16     ` Wenmeng Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2116a5a-5144-4f82-9b9a-ea343cb2ff1e@oss.qualcomm.com \
    --to=wenmeng.liu@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=robh@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=vladimir.zapolskiy@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).