Re: [PATCH v3 1/2] media: dt-bindings: bind nokia,n900-ir to generic pwm-ir-tx driver

[Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>]

On 29.08.2018 20:07, Mauro Carvalho Chehab wrote:
> Em Fri, 13 Jul 2018 13:22:29 +0100
> Sean Young <sean@mess.org> escreveu:
> 
>> The generic pwm-ir-tx driver should work for the Nokia n900.
>>
>> Compile tested only.
> 
> It would be good to have some tests...
> 

Unfortunately, it turned out I won't be able to test soon, so please, 
somebody else do it.

>>
>> Cc: Rob Herring <robh@kernel.org>
>> Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
>> Cc: Pali Rohár <pali.rohar@gmail.com>
>> Cc: Pavel Machek <pavel@ucw.cz>
>> Cc: Timo Kokkonen <timo.t.kokkonen@iki.fi>
>> Cc: Tony Lindgren <tony@atomide.com>
> 
> And some acks
> 
> Before merging it.
> 
>> Signed-off-by: Sean Young <sean@mess.org>
>> ---
>>   arch/arm/boot/dts/omap3-n900.dts | 2 +-
>>   drivers/media/rc/pwm-ir-tx.c     | 1 +
>>   2 files changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
>> index 182a53991c90..fd12dea15799 100644
>> --- a/arch/arm/boot/dts/omap3-n900.dts
>> +++ b/arch/arm/boot/dts/omap3-n900.dts
>> @@ -154,7 +154,7 @@
>>   	};
>>   
>>   	ir: n900-ir {
>> -		compatible = "nokia,n900-ir";
>> +		compatible = "nokia,n900-ir", "pwm-ir-tx";
>>   		pwms = <&pwm9 0 26316 0>; /* 38000 Hz */
>>   	};
>>   
>> diff --git a/drivers/media/rc/pwm-ir-tx.c b/drivers/media/rc/pwm-ir-tx.c
>> index 27d0f5837a76..272947b430c8 100644
>> --- a/drivers/media/rc/pwm-ir-tx.c
>> +++ b/drivers/media/rc/pwm-ir-tx.c
>> @@ -30,6 +30,7 @@ struct pwm_ir {
>>   };
>>   
>>   static const struct of_device_id pwm_ir_of_match[] = {
>> +	{ .compatible = "nokia,n900-ir" },
>>   	{ .compatible = "pwm-ir-tx", },
>>   	{ },
>>   };
> 
> 
> 
> Thanks,
> Mauro
>