From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C847A20010A; Wed, 13 May 2026 14:48:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778683694; cv=pass; b=ZfcIH04NtbrGzDieh+72lai+H4h91MqvDxr0CnlEFVz3Ddr9oJCVXdJVDuinUrsqoQtxN6NwOQokY1Irvq6dApeMQopPYuIBtUi9BK4Zhh9kHYr/KTrZngdFGSPezdN5/OHxN0A+jrVzAC4q9RBg4zizkFP5uEnsOr9R3aHhuV4= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778683694; c=relaxed/simple; bh=7Q5KgUM+tw7xqd1TaDwTpSv7r9RU13BFwt3gRw7RFSc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=E3yKhH7m55h+/vHNVkGsP70XXZTxvpGtRHSkm/14/oiexKuLnMLxzYQNU7g2wyTZ5OKFxLPTjBcJ9S+WUC4shN20eemQgnfux8IbnkCkMScSKhlB2OkPlxdQmHWVen3tvXsMUlOsJ3KwKzrlmdfgOrtlkFHpolKbxe74h58n+U4= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=michael.riesch@collabora.com header.b=OiMQMTZx; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=michael.riesch@collabora.com header.b="OiMQMTZx" ARC-Seal: i=1; a=rsa-sha256; t=1778683653; cv=none; d=zohomail.com; s=zohoarc; b=Z34X34TAKvlMFPBzLMiQeMxOY5tJcYfk5GXWV5byHgi+sixNHICT8IWftedkRe3lV2y7SXAmMlkhKaFJPqitasAx4iNYbtpUQwWGcOMj1mOvUo6PBeBPD1k5dJoXm95NYCY0xiV6U8geuK4r+mlvEPyIDNPXK3sWP/W97dxsA+Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778683653; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=Bq9WGORoYPZBXmUGqu1w+1NLwysPb53TwFNAairTvjw=; b=ax02RYhsjy8DejWtvvKv6ZrQXBnP8G55UsSI2RCP5xiBfyC1a9tdz+zAAFUp/obKyDNAJyjSdmLwMOYfi4iAp54c9+J9I6FgIWeWv9rZjldlJfasZbe42nQjI5ZDq/KDlW4nFumKTRmPScMMjToWL6iKfzNRBFbLTBEC2AEDCf0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=michael.riesch@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1778683653; s=zohomail; d=collabora.com; i=michael.riesch@collabora.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=Bq9WGORoYPZBXmUGqu1w+1NLwysPb53TwFNAairTvjw=; b=OiMQMTZxXNdQs0FIeDwRBJMbKqL5MmN/NkGiOTorI9PhSffIctLaUKLziP49bNL/ 658SrtBw1oHTQZ7GSIR349dnJU+Ly9GtCMVslND4aOZELg8+4LliZit9LHYf3B6DkUc xslDa0OBlqy2+r+t2W6ZFYcKTh/nl8wcg2XnWrko= Received: by mx.zohomail.com with SMTPS id 1778683651997490.307654217934; Wed, 13 May 2026 07:47:31 -0700 (PDT) Message-ID: Date: Wed, 13 May 2026 16:47:25 +0200 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/8] media: dt-bindings: add rockchip rk3588 vicap To: Rob Herring Cc: Mehdi Djait , Laurent Pinchart , Mauro Carvalho Chehab , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Kever Yang , Jagan Teki , =?UTF-8?B?0JrRg9C30L3QtdGG0L7QsiDQnNC40YXQsNC40Ls=?= , Charalampos Mitrodimas , Sebastian Reichel , Nicolas Dufresne , Collabora Kernel Team , Sakari Ailus , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Conor Dooley References: <20260508-rk3588-vicap-v4-0-6a6cd6f7c90b@collabora.com> <20260508-rk3588-vicap-v4-2-6a6cd6f7c90b@collabora.com> <20260513124858.GA585254-robh@kernel.org> Content-Language: en-US From: Michael Riesch In-Reply-To: <20260513124858.GA585254-robh@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External Hi Rob, On 5/13/26 14:48, Rob Herring wrote: > On Fri, May 08, 2026 at 09:31:45PM +0200, Michael Riesch wrote: >>[...] >> properties: >> compatible: >> - const: rockchip,rk3568-vicap >> + enum: >> + - rockchip,rk3568-vicap >> + - rockchip,rk3588-vicap >> >> reg: >> maxItems: 1 >> @@ -26,37 +32,23 @@ properties: >> maxItems: 1 >> >> clocks: >> - items: >> - - description: ACLK >> - - description: HCLK >> - - description: DCLK >> - - description: ICLK >> + minItems: 4 >> + maxItems: 5 >> >> clock-names: >> - items: >> - - const: aclk >> - - const: hclk >> - - const: dclk >> - - const: iclk > > Just keep this here and add iclk1 on the end along with 'minItems: 4'. Just to make sure I get it right: The names on the RK3588 would then be aclk, hclk, dclk, iclk, iclk1 ? I liked that zero. But OK. Looking into the future, the RK3576 downstream has aclk, hclk, dclk, iclk{0-4} [0]. Again, if we rename "iclk0" -> "iclk", we can do the same trick. However, the RK3562 downstream has aclk, hclk, dclk, csirx{0-3} [1]. We could rename those to iclk, as those iclks seem to refer to the CSI hosts/receivers. Yeah, should work I think. Will update in v5. Best regards, Michael > >> + minItems: 4 >> + maxItems: 5 > [0] https://github.com/rockchip-linux/kernel/blob/develop-6.6/arch/arm64/boot/dts/rockchip/rk3576.dtsi#L3342 [1] https://github.com/rockchip-linux/kernel/blob/develop-6.6/arch/arm64/boot/dts/rockchip/rk3562.dtsi#L2073