From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A9B33D16E9 for ; Tue, 18 Aug 2026 12:22:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787055748; cv=none; b=QrW/9Al77OAX7AuX9NKaWKpRdFFngbucaA3FeDXw2pRlcynOmwWQWTMPB2OWMDf0gBSxwl60gzLxy/KIK0h8huayh1AMwxUUjiXbi7wjqYBzxAj347PxNmlurqnwEboXWgVQNh6HQfpHYvWC/HAfT+p+FBvlNasOvlNxfIoSwAQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787055748; c=relaxed/simple; bh=8kO2VHWuXi8HRc0kEaow5D4nc+h/R0Hiw0R1pGv46ro=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=Nn9TIHb9BTHqGU2quJwwG5ieMFaii4yFKfDzMT6chOwNKm7r+po14EOnl+6jDrViW5j/JtR31uOvB3JT4ehMa90niExX3ZjcKSDUdvJgH8b3ClMCG048siXc7E2123OmHF1alTQlImJ/zn/9MnEb7rCYPaoqVCeJDb5yxgMQ5wU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TGizrxsq; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NNy7Dppv; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TGizrxsq"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NNy7Dppv" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67IABSsd919338 for ; Tue, 18 Aug 2026 12:22:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kCXqzalmkhIpG31lnKOThkzlwOR/mMpYM6LvnVk4AYg=; b=TGizrxsqdT3dYAEc uBbkltHWLY619Dk/pbN+KvCurxiYOEanNrluguVPCUPHrVZ9r26XBJB0lMponfaF InaToIORSTtiP4529qwW8qhbE7ELOjmW6beE7+HnxK9Bt4dpEgUmimAD5gKk6vuv hOfhtVxkaUs81aSXSVsDm+Ay3eW6u+o4BZ1RwTb+riMfxlnex4v/HW6gyHyeyvAz LSBZJqsv21LBVkWaBB5qImgujFiP/NBfuFrEQfHqjfhLpyslY8Vf0j4zD/EZB2yt zZiFDBnB3nT2r9/CCy/MySy/doQl0kcM21BekRY5oyw3CrdPF0T+8la5mdrp0EA1 kJHs8g== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g4nb18gh1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 18 Aug 2026 12:22:26 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92efd2ca21aso52411085a.0 for ; Tue, 18 Aug 2026 05:22:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787055746; x=1787660546; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:cc:to:subject:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=kCXqzalmkhIpG31lnKOThkzlwOR/mMpYM6LvnVk4AYg=; b=NNy7Dppv3OKclJtUTQDAV0LpxG8bCUGmqnQTjxfMEdJCn2ehTrHNF7Wv6CJTTbMaV5 UpaINmk2Q9vi+wVXDf5gQeGsfbMBIoIxMihxvWFYTU0R8Tz8uLrcTkkZMgU1A/McH1/F zQO1sHj0WRtZpyt7xHaZDQVd2j/l9EOuBGgyiJktjg51xUFp62D7i5+5RybYuiTsMolx 9OP3gdcevdmRiHVgN0/ij8+h2YsFesuaCp3TTDN7SP6vCdvHwEkEX8Tz2oqi5CsPJzqM 2Kf+ybUVzCtzS74nXH7eWSnoRCfDCaj3KzQ9gDg0QTiW/UGLkLJpwwNbKAcQJwgF+vjq XZSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787055746; x=1787660546; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:cc:to:subject:from:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kCXqzalmkhIpG31lnKOThkzlwOR/mMpYM6LvnVk4AYg=; b=GVoezw+ndGn/Ox0NqcBcueu89LQUtrTsiBZO/0XwEDx1i318FQ8y+2B9JDPYSxRAGb +1gpmQ1eaQGg2QR5ELSJBWERyiwu9F+8d10dM8xAjOxfO7/ydgN3HRAtWADiKLM/IYTu /jH1vAnu9Ooi8K8seGf7yABXs8rjJBXIyJEKXjbFKAC4lovnloQHgZLAtwEYnJ5QFjPW vs6T3sqFMpYk6qK5AJ8ekO8j6TZOPUOvECiDSGW+9uGOyOuE+ne7TJamqklfPXRcrHkW zSQzGuEQRuBSFz3mcObYIVhpLGotiB0nXtSyCtLe5frKOu2lobE+Bc6KBOihYltgtK9D WfVA== X-Forwarded-Encrypted: i=1; AHgh+RpDvfaUmHeQFmvoNiPRQr9TVE7TlxItr5LdjM/pgeyDbLLMrbWrguz1VJnmHaIT4Fo7QPM6pnamVbiC7w==@vger.kernel.org X-Gm-Message-State: AOJu0YxjY+nYB5c8DkKr4VsBUoASXYVnn/FEX0E4Jq0YulFBkK40LAvQ DmJGlroXlKJNq1ynVQ8fV36TZdA7pCK29dmbi1f0jttTfMnj1E0pwWLBkjcD5wGibQ8D1s5+gcR Hu2Kfpzibovva+RSjqFHw1aAWiacq3WsZD+BEAELji8BtjWfZ62TXEDPf8Q4rAVeK6Q== X-Gm-Gg: AR+sD13OWrExZHeGbs2GwGZxqxs/KVyeJ5bG/dK1/PEsVA632aE/aXznGMZl4t5+8Li yCqOIs1t1kLBpUMi9K5zX+TA01ijVC3NUFXGZ8AwuSqugESNp36OBZzm5TcJcdybIPa76Q8ffyU JQxKkrcGma+AhTO21SVHwQN2JTT9dp9sRMXMitntorNza9jqLZhnYM4ZJvK88XdZlWb9brbBIvH X17Rb8s56KagDpV8fYgxRDUmcxBeS+XsSDUflj6wYrXKrrX6xMwwBKkieuTEkpRtK+t+7CWXwrK KsKQkOZ2t/aXYN1qxk1X0bd9Hw3+tXyrhwuBTNSRJUxM5v3/aiinn6hdG2t08yFHijI4l+pw2Y7 mtnWji/k1lPPWKLY29DL1YzNXkVAeLm6fOz2cDHMqEKsZVvH1JRfkGrFxXwgqhQQHaa+qd7pxsY eIADvNpLt0jM0kp8X7qwmMhPR0nRd4IWBLU7Y/q6RzuiH5CauLYKX5CN789GjIr5H/0Og= X-Received: by 2002:a05:620a:2b85:b0:936:e80c:e0ba with SMTP id af79cd13be357-936e80ce8dcmr2480290885a.0.1787055745608; Tue, 18 Aug 2026 05:22:25 -0700 (PDT) X-Received: by 2002:a05:620a:2b85:b0:936:e80c:e0ba with SMTP id af79cd13be357-936e80ce8dcmr2480285385a.0.1787055745204; Tue, 18 Aug 2026 05:22:25 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a3d852d915sm1700676a12.9.2026.08.18.05.22.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Aug 2026 05:22:23 -0700 (PDT) Message-ID: Date: Tue, 18 Aug 2026 14:22:22 +0200 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Hans de Goede Subject: Re: [PATCH] platform/x86: int3472: Increase handshake GPIO delay to 200 ms To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Daniel Scally , Sakari Ailus Cc: platform-driver-x86@vger.kernel.org, linux-media@vger.kernel.org, James Alexander , stable@vger.kernel.org References: <20260818121445.160751-1-johannes.goede@oss.qualcomm.com> Content-Language: en-US, nl In-Reply-To: <20260818121445.160751-1-johannes.goede@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE4MDA5MSBTYWx0ZWRfX0EwcsU8gXhsz YooefTut7D+2PVoaSgIuv0vk0MUB3AXXMVo2exSAMSDPJEa/zfXLzA8GO3DooGi2ahB9mePzARm 5yP5RshDvBsIub7rebTcLA3AZzuH6PBcY3T6gmRx2boaiRNMN+DErYy+r9yr99g9Bz4J3SvaRl+ OYMZoOjoC6QKpAqfQ6/4i7KJgcZrmUKOAniqsbPMwiQYT8/0MGKcx67PN24gtO3AU99k3tWu9ta vcWPYUVDgOz5uLc1SeZQ1OwssaEeO6Y/Fc0kxnzzAdsBg7haNy6Tc189XDhwwKVBRHPaZgS7WSl 7FmHclZdMrVsf5KCXUEJGVf73vX5TDGKxHSE8v7qv9TZOwi+F2ccReZ6FBYvGsDvavDRvrTI1Wd ef8rx83xqFCVBfrCZ93mLRRHtv9v6I9JMRvzUm4DXBNfa3VX8riH6S7ZwKyu09BnPyx14orZRfd EK8r1+ABUuDMWXuWz8g== X-Proofpoint-GUID: KU83YiQ2GV8QFEXIBkWMZm0xALt4UZcE X-Authority-Analysis: v=2.4 cv=Ze4t8MVA c=1 sm=1 tr=0 ts=6a844e82 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=VwQbUJbxAAAA:8 a=BEWJZVgQAAAA:8 a=20KFwNOVAAAA:8 a=EUspDBNiAAAA:8 a=isYjQQs3ymCD79PP7cMA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=r2lMSnxMdfrVB7dy-wwo:22 X-Proofpoint-ORIG-GUID: KU83YiQ2GV8QFEXIBkWMZm0xALt4UZcE X-Proofpoint-Spam-Info: AW1haW4tMjYwODE4MDA5MSBTYWx0ZWRfX4b3bnr8JA5HM HivUfV5S2ppuKr5rCIjrd/XN+GOWjMPnzs/0+szB12bKAOYbI2pLXJKyc2GIWYw7EBg8KRY5T/Q mXJD/iUqnuZ6I50qiBfkIO/4KBCqVY0= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-18_01,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 clxscore=1015 phishscore=0 impostorscore=0 adultscore=0 suspectscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608180091 Hi, On 18-Aug-26 14:14, Hans de Goede wrote: > There have been several reports of the sensor not properly powering on, > on laptops where an INT3472 handshake GPIO is used. Both with ov08x40 and > hi556 sensors. > > Testing has shown that a delay of 200 ms is necessary in some cases. > The handshake GPIO is typically used to signal an extra bridge or other IC > with that IC running the full sensor power sequence based on the handshake > signal and also possible controlling I2C pass-through. > > It seems that in some cases that extra IC takes up to 200 ms to before > the sensor is fully powered up and ready for I2C communication. > > With the default handshake signal delay increased to 200 ms the quirk to > increase it to 45 ms for the ov08x40 is no longer necessary and is actually > undesirable since some ov08x40 setups also need the longer delay, drop it. > > Fixes: 30359c239ba8 ("platform/x86: int3472: Increase ov08x40 handshake GPIO delay to 45 ms") > Closes: https://lore.kernel.org/platform-driver-x86/20260816204247.2844986-1-opensource@inspiredexperts.com/ > Reported-by: James Alexander > Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2333331 > Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2333647 > Cc: stable@vger.kernel.org > Signed-off-by: Hans de Goede This does not apply cleanly on media-committers/next, let me send a v2 with this fixed. James, assuming you are not running a -next kernel, if you want to give this a test run you can use this v1 for testing. Regards, Hans > --- > drivers/platform/x86/intel/int3472/discrete.c | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) > > diff --git a/drivers/platform/x86/intel/int3472/discrete.c b/drivers/platform/x86/intel/int3472/discrete.c > index 115bb37577a1..f9e42959647e 100644 > --- a/drivers/platform/x86/intel/int3472/discrete.c > +++ b/drivers/platform/x86/intel/int3472/discrete.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > #include > > /* > @@ -157,13 +158,6 @@ static const struct int3472_gpio_map int3472_gpio_map[] = { > .type_to = INT3472_GPIO_TYPE_RESET, > .con_id = "enable", > }, > - { /* ov08x40's handshake pin needs a 45 ms delay on some HP laptops */ > - .hid = "OVTI08F4", > - .type_from = INT3472_GPIO_TYPE_HANDSHAKE, > - .type_to = INT3472_GPIO_TYPE_HANDSHAKE, > - .con_id = "dvdd", > - .enable_time_us = 45 * USEC_PER_MSEC, > - }, > }; > > static void int3472_get_con_id_and_polarity(struct int3472_discrete_device *int3472, u8 *type, > @@ -234,8 +228,8 @@ static void int3472_get_con_id_and_polarity(struct int3472_discrete_device *int3 > case INT3472_GPIO_TYPE_HANDSHAKE: > *con_id = "dvdd"; > *gpio_flags = GPIO_ACTIVE_HIGH; > - /* Setups using a handshake pin need 25 ms enable delay */ > - *enable_time_us = 25 * USEC_PER_MSEC; > + /* Powering up the sensor through the handshake pin takes up to 200 ms */ > + *enable_time_us = 200 * USEC_PER_MSEC; > break; > default: > *con_id = "unknown";