From: Markus Elfring <Markus.Elfring@web.de>
To: Darshan Rathod <darshanrathod475@gmail.com>, linux-media@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH] media: b2c2: flexcop-eeprom: Fix assignment in if condition
Date: Sat, 19 Jul 2025 15:50:20 +0200 [thread overview]
Message-ID: <fbe09fd7-c73e-4bb5-ace0-ec5eefad0765@web.de> (raw)
In-Reply-To: <20250718125245.82910-1-darshanrathod475@gmail.com>
> Function flexcop_eeprom_check_mac_addr() contains an
> assignment in an 'if' condition. This coding style is not
> accepted in the Linux kernel as it can conceal bugs.
…
You may occasionally put more than 60 characters into text lines
of such a change description.
> Also, correct a few off-by-one spaces in a function call and
> variable declaration.
Please split possible changes into separate update steps.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.16-rc6#n81
Regards,
Markus
prev parent reply other threads:[~2025-07-19 13:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 12:52 [PATCH] media: b2c2: flexcop-eeprom: Fix assignment in if condition Darshan Rathod
2025-07-19 0:45 ` kernel test robot
2025-07-19 4:42 ` kernel test robot
2025-07-19 13:50 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbe09fd7-c73e-4bb5-ace0-ec5eefad0765@web.de \
--to=markus.elfring@web.de \
--cc=darshanrathod475@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).