Linux Media Controller development
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>, linux-media@vger.kernel.org
Cc: Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
	hverkuil@xs4all.nl, laurent.pinchart@ideasonboard.com,
	bingbu.cao@intel.com
Subject: Re: [PATCH v8 4/9] media: Documentation: tx-rx: Move transmitter control out of CSI-2 part
Date: Fri, 20 Dec 2024 15:21:39 +0200	[thread overview]
Message-ID: <fbfefbab-011a-4f69-94f8-62c4bc6742d3@ideasonboard.com> (raw)
In-Reply-To: <20241217215445.901459-5-sakari.ailus@linux.intel.com>


On 17/12/2024 23:54, Sakari Ailus wrote:
> The subsection on stopping the transmitter belongs to the generic part and
> is not specific to CSI-2. Move it out of the CSI-2 section.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
>   Documentation/driver-api/media/tx-rx.rst | 19 +++++++++----------
>   1 file changed, 9 insertions(+), 10 deletions(-)
> 
> diff --git a/Documentation/driver-api/media/tx-rx.rst b/Documentation/driver-api/media/tx-rx.rst
> index 6f9eba189a9f..03768e5aa88f 100644
> --- a/Documentation/driver-api/media/tx-rx.rst
> +++ b/Documentation/driver-api/media/tx-rx.rst
> @@ -62,6 +62,15 @@ to control the transmitter driver's streaming state. These callbacks may not be
>   called directly, but by using ``v4l2_subdev_enable_streams()`` and
>   ``v4l2_subdev_disable_streams()``.
>   
> +Stopping the transmitter
> +^^^^^^^^^^^^^^^^^^^^^^^^
> +
> +A transmitter stops sending the stream of images as a result of
> +calling the ``.disable_streams()`` callback. Some transmitters may stop the
> +stream at a frame boundary whereas others stop immediately,
> +effectively leaving the current frame unfinished. The receiver driver
> +should not make assumptions either way, but function properly in both
> +cases.
>   
>   CSI-2 transmitter drivers
>   -------------------------
> @@ -130,13 +139,3 @@ device, so this should be only done when it is needed.
>   
>   Receiver drivers that do not need explicit LP-11 or LP-111 state setup are
>   waived from calling the two callbacks.
> -
> -Stopping the transmitter
> -^^^^^^^^^^^^^^^^^^^^^^^^
> -
> -A transmitter stops sending the stream of images as a result of
> -calling the ``.disable_streams()`` callback. Some transmitters may stop the
> -stream at a frame boundary whereas others stop immediately,
> -effectively leaving the current frame unfinished. The receiver driver
> -should not make assumptions either way, but function properly in both
> -cases.

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>

  Tomi


  reply	other threads:[~2024-12-20 13:21 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-17 21:54 [PATCH v8 0/9] Use V4L2 mbus config for conveying link frequency Sakari Ailus
2024-12-17 21:54 ` [PATCH v8 1/9] media: v4l: Support passing media pad argument to v4l2_get_link_freq() Sakari Ailus
2024-12-20 13:09   ` Tomi Valkeinen
2025-01-08 13:14     ` Sakari Ailus
2024-12-17 21:54 ` [PATCH v8 2/9] media: v4l: Support obtaining link frequency via get_mbus_config Sakari Ailus
2024-12-20 12:59   ` Tomi Valkeinen
2025-01-08 13:53     ` Sakari Ailus
2024-12-17 21:54 ` [PATCH v8 3/9] media: Documentation: Update link frequency driver documentation Sakari Ailus
2024-12-17 21:54 ` [PATCH v8 4/9] media: Documentation: tx-rx: Move transmitter control out of CSI-2 part Sakari Ailus
2024-12-20 13:21   ` Tomi Valkeinen [this message]
2024-12-17 21:54 ` [PATCH v8 5/9] media: Documentation: Receiver drivers should call v4l2_get_link_freq() Sakari Ailus
2024-12-20 13:22   ` Tomi Valkeinen
2024-12-17 21:54 ` [PATCH v8 6/9] media: Documentation: Add a note to set all fields in get_mbus_config op Sakari Ailus
2024-12-20 13:29   ` Tomi Valkeinen
2025-01-08 13:42     ` Sakari Ailus
2024-12-17 21:54 ` [PATCH v8 7/9] media: intel/ipu6: Obtain link frequency from the remote subdev pad Sakari Ailus
2024-12-17 21:54 ` [PATCH v8 8/9] media: ivsc: csi: Obtain link frequency from the media pad Sakari Ailus
2024-12-17 21:54 ` [PATCH v8 9/9] media: v4l: Convert the users of v4l2_get_link_freq to call it on a pad Sakari Ailus
2024-12-19 11:03   ` [RESEND PATCH " Sakari Ailus
2024-12-19 12:44     ` Naushir Patuck
2025-01-02 10:49     ` Benjamin Mugnier
2024-12-20 13:19   ` [PATCH " Tomi Valkeinen
2025-01-08 12:50     ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fbfefbab-011a-4f69-94f8-62c4bc6742d3@ideasonboard.com \
    --to=tomi.valkeinen@ideasonboard.com \
    --cc=bingbu.cao@intel.com \
    --cc=hverkuil@xs4all.nl \
    --cc=jacopo.mondi@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox