From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 038DAC55186 for ; Sun, 26 Apr 2020 03:04:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D0D02206ED for ; Sun, 26 Apr 2020 03:04:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="Tfsl8COp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726113AbgDZDEE (ORCPT ); Sat, 25 Apr 2020 23:04:04 -0400 Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:19528 "EHLO hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726092AbgDZDEE (ORCPT ); Sat, 25 Apr 2020 23:04:04 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Sat, 25 Apr 2020 20:02:59 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Sat, 25 Apr 2020 20:04:03 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Sat, 25 Apr 2020 20:04:03 -0700 Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sun, 26 Apr 2020 03:04:03 +0000 Received: from [10.2.165.152] (10.124.1.5) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sun, 26 Apr 2020 03:04:02 +0000 Subject: Re: [RFC PATCH v10 6/9] media: tegra: Add Tegra210 Video input driver From: Sowjanya Komatineni To: Dmitry Osipenko , Hans Verkuil , , , , , CC: , , , , , References: <1587700513-28449-1-git-send-email-skomatineni@nvidia.com> <1587700513-28449-7-git-send-email-skomatineni@nvidia.com> <6ca93ff9-ca59-544f-767c-4355d01a5c20@gmail.com> <62546d1f-eca5-06be-2bc2-e45ccd53830a@xs4all.nl> <50fd1016-ca8b-ec5d-e5a8-f257138b152e@gmail.com> <658c4232-94d9-3051-8c93-bff7046cf5f2@nvidia.com> <03426915-25ea-69b4-bc64-f87f3046d33f@nvidia.com> <09f20441-fec6-7496-2edc-c69db535e441@nvidia.com> <61799fab-858c-8b0d-ba7d-846cd041e044@gmail.com> <3a9707b5-b260-6137-f475-fc88d271010f@nvidia.com> <024fc70f-9a65-3fc4-1387-d0b15f3f74e7@nvidia.com> Message-ID: Date: Sat, 25 Apr 2020 20:03:43 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <024fc70f-9a65-3fc4-1387-d0b15f3f74e7@nvidia.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To DRHQMAIL107.nvidia.com (10.27.9.16) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1587870179; bh=lDkWZmQ7v+sGrvdR/Y2ohSDw2AI0NeTwg+e9Khufi9Y=; h=X-PGP-Universal:Subject:From:To:CC:References:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding: Content-Language; b=Tfsl8COp45O25CzVWpTL0S/mAEOhYM5GLJ05Hsu2cMp+AM5bgkYglIfk2Kzh6kkN6 f6MuBPYWUGA676W6XSRH0xjjZVHi5yxvl5uUceAeKGm3b1TL3YjBPWT3OwQZ0JXRxn ZJ4F69RpjqV5RGfErcfJqFLn0PfjKCbpsOdmBTlXFLXvcWTpmLlE6ivjk1GCEUPN4C FTmsNSC9EbApsfx6EcspDDLfc6pCnMV4kCP7fM+5850neZ369QprOBxRG968GL2dNG lS4HYhiHeMt0F5AQH/1czAMbSHM5f3POPUcxB9CvYhSDeUTWfK8ASFZS2IeYljdnAO tNLDHyhM5k7kA== Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On 4/25/20 7:48 PM, Sowjanya Komatineni wrote: > > On 4/25/20 7:38 PM, Dmitry Osipenko wrote: >> External email: Use caution opening links or attachments >> >> >> 26.04.2020 05:19, Sowjanya Komatineni =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>> On 4/25/20 7:10 PM, Dmitry Osipenko wrote: >>>> External email: Use caution opening links or attachments >>>> >>>> >>>> 26.04.2020 04:43, Sowjanya Komatineni =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>>> ... >>>>>> It looks to me that at least all those hardcoded HW format IDs do=20 >>>>>> not >>>>>> match the older SoCs. >>>>> TPG hard coded formats are supported on prior Tegra. >>>>> >>>>> Other supported formats are SoC dependent and=C2=A0 part of soc data = in=20 >>>>> the >>>>> driver already. >>>> But I don't see where that SoC-dependent definition is made in >>>> terga210.c. That tegra_image_format enum looks T210-specific, isn't=20 >>>> it? >>>> >>>> ... >>> Video formats which are SoC variants are made soc specific in driver >>> already tegra_vi_soc structure member video_formats >>> >>> tegra_image_format enum is same for T210 and T186 >>> >>> For T194, enums will be diff and will have diff TEGRA194_VIDEO_FORMAT >>> using corresponding Tegra194 video format enums >> But it is also not the same for older SoCs, correct? All the >> T210-specific things should be separated better, unique parts shouldn't >> be kept in the common code. >> >> Hence the tegra_image_format should be renamed to tegra210_image_format >> and moved out to t210.h, since it's not common. But then you'll probably >> need to rename all TEGRA_ defines to TEGRA210_ to make t210.h reusable >> by T186. > > We can't make t210.h reusable for t186 as all register defines are diff. > > only video format enums are same b/w them so to reuse that for t186 I=20 > had that in common. > > Regarding defines, will change prefix as Tegra210 > >> >> Also, in the end it may not worth the effort to share anything at all, >> it could be cleaner to have a bit of duplication. Although, I have no >> idea how T186 code will look like and what other parts of T210 could be >> reused by T186. All this needs to be taken into account in order to >> avoid struggling with the code's reshuffling in the future. > > Currently as image formats are same for t210 and t186 I had them in=20 > common.h and for t194 where they are diff new enums will be added. > > Other tegra210 soc specific only are all part of tegra210.c/h > Will move video formats to tegra specific file (tegra210.c)...