Re: [PATCH] dvb-usb-v2/gl861: fix wrong memcpy

Antti Palosaari
2019-08-22T03:54:53Z

On 8/22/19 5:00 AM, Akihiro TSUKADA wrote:
> Hi,
>
>> I suspect all whole friio_reset() function is not needed as it has
>> worked even I/O has been broken.
>
> It worked because the old driver
> (that I rmmod'ed before installing the testing driver)
> properly init'ed the device.
> If I re-plug it (or reboot), it does not work.
> So it is needed.
>
>> Also tuner I2C adapter is implemented wrong (I think I mentioned that
>> earlier). As tuner sits behind demod I2C-adapter/gate that whole logic
>> should be on demod driver.
>
> But according to USB packet capture logs of the windows version,
> it makes eccentric use of USB messages ('bRequest' field),
> that (I believe) necessitates the current implementation,
> as I mentioned in the past thread.

That is because it has 2 i2c write methods - one using only
usb_control_msg() header and other header + payload data. When 1 or 2
byte long i2c message is send it is wise to use only "header" to reduce
IO as it could carry needed data.

Anyhow, I will send patch soon which adds needed logic to i2c adapter.
Then it is easier to understand.

regards
Antti

--