From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="a7sZySPb" Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [IPv6:2a00:1098:ed:100::25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F17EC114; Thu, 14 Dec 2023 02:50:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1702551047; bh=KQPPWQ7ff7K6RVCr76kqdYlu1bxc+1vJ5J89gJwofFw=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=a7sZySPblmTeMFftL/9ixGNcikvNBMVPwpY94ey3QDN8xp3HwZybSYjESrfS+Clws gKC2PU3t30NXOSSJGAQ5DIqKacg7UnSxFuJr9dnOe0H6PVtbIdBOYmvYrw/vtk2HBe OgrYq1DrQMk0RteGZEZTlHcwGVuECjh5ymX9mwFOUEKYIzMUEkrhHfqxEzwrtmp6Nb i0JTZP8x44boidCbpYz+BRDQ58irrtLeHEuIRCXJX8d5Ow4jt4A30m9n+zZ8EzuKGO 4dpd+YS+m+3nI6nOAyvcnr6WMllxjKHcys84GxXtC2s1QiTHmlhiodYqayhoUxjxSp A0FAyEJLjVTvg== Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id D487F378000B; Thu, 14 Dec 2023 10:50:46 +0000 (UTC) Message-ID: Date: Thu, 14 Dec 2023 11:50:46 +0100 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] arm64: dts: mediatek: mt8186: Add venc node Content-Language: en-US From: AngeloGioacchino Del Regno To: Eugen Hristev , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@collabora.com, tiffany.lin@mediatek.com, andrew-ct.chen@mediatek.com, matthias.bgg@gmail.com, Kyrie Wu , Allen-KH Cheng , Hsin-Yi Wang References: <20231213122017.102100-1-eugen.hristev@collabora.com> <20231213122017.102100-4-eugen.hristev@collabora.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Il 14/12/23 11:44, AngeloGioacchino Del Regno ha scritto: > Il 13/12/23 13:20, Eugen Hristev ha scritto: >> From: Kyrie Wu >> >> Add video encoder node. >> >> Signed-off-by: Kyrie Wu >> Signed-off-by: Allen-KH Cheng >> Reviewed-by: Hsin-Yi Wang >> [eugen.hristev@collabora.com: minor cleanup] >> Signed-off-by: Eugen Hristev >> --- >>   arch/arm64/boot/dts/mediatek/mt8186.dtsi | 24 ++++++++++++++++++++++++ >>   1 file changed, 24 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/mediatek/mt8186.dtsi >> b/arch/arm64/boot/dts/mediatek/mt8186.dtsi >> index 66ead3f23336..8535ff2b44e9 100644 >> --- a/arch/arm64/boot/dts/mediatek/mt8186.dtsi >> +++ b/arch/arm64/boot/dts/mediatek/mt8186.dtsi >> @@ -1993,6 +1993,30 @@ larb7: smi@17010000 { >>               power-domains = <&spm MT8186_POWER_DOMAIN_VENC>; >>           }; >> +        venc: venc@17020000 { >> +            compatible = "mediatek,mt8183-vcodec-enc"; Sorry for the double email; I've just noticed: where's mediatek,mt8186-vcodec-enc? :-) >> +            #address-cells = <2>; >> +            #size-cells = <2>; >> +            reg = <0 0x17020000 0 0x2000>; >> +            interrupts = ; >> +            iommus = <&iommu_mm IOMMU_PORT_L7_VENC_RCPU>, >> +                 <&iommu_mm IOMMU_PORT_L7_VENC_REC>, >> +                 <&iommu_mm IOMMU_PORT_L7_VENC_BSDMA>, >> +                 <&iommu_mm IOMMU_PORT_L7_VENC_SV_COMV>, >> +                 <&iommu_mm IOMMU_PORT_L7_VENC_RD_COMV>, >> +                 <&iommu_mm IOMMU_PORT_L7_VENC_CUR_LUMA>, >> +                 <&iommu_mm IOMMU_PORT_L7_VENC_CUR_CHROMA>, >> +                 <&iommu_mm IOMMU_PORT_L7_VENC_REF_LUMA>, >> +                 <&iommu_mm IOMMU_PORT_L7_VENC_REF_CHROMA>; >> +            dma-ranges = <0x1 0x0 0x1 0x0 0x1 0x0>; >> +            mediatek,scp = <&scp>; >> +            clocks = <&vencsys CLK_VENC_CKE1_VENC>; >> +            clock-names = "MT_CG_VENC"; > > clock-names = "venc"; (please no underscores and please lower case) > >> +            assigned-clocks = <&topckgen CLK_TOP_VENC>; >> +            assigned-clock-parents = <&topckgen CLK_TOP_UNIVPLL_D3>; >> +            power-domains = <&spm MT8186_POWER_DOMAIN_VENC>; >> +        }; > > > ....also: > > The following order of properties in device nodes is preferred: > > 1. "compatible" > 2. "reg" > 3. "ranges" > 4. Standard/common properties (defined by common bindings, e.g. without >    vendor-prefixes) > 5. Vendor-specific properties > 6. "status" (if applicable) > 7. Child nodes, where each node is preceded with a blank line > > Documentation/devicetree/bindings/dts-coding-style.rst > > Please reorder as per the DTS coding style document, and also please rename the > venc node to use a generic name, such as "video-encoder@xxxx" > > Cheers, > Angelo