Re: [PATCH] media: ti: cal: remove unnecessary error check

[Yemike Abhilash Chandra <y-abhilashchandra@ti.com>]

Hi Dan,
Thank you for the patch.

On 22/09/26 16:04, Dan Carpenter wrote:
> The v4l2_subdev_lock_and_get_active_state() function never returns
> error pointers.  As the comments explain, it "returns the locked active
> state for the subdevice, or NULL if the subdev does not support active
> state."  None of the other callers check for an error pointer return.
> 
> Delete this unnecessary check.
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> I feel like if we don't delete the IS_ERR() check someone will eventually
> try to convert it into a NULL check which would be a bug.
> 

It makes sense for me. Hence

Reviewed-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>

Thanks and regards,
Yemike Abhilash Chandra

>   drivers/media/platform/ti/cal/cal-video.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/media/platform/ti/cal/cal-video.c b/drivers/media/platform/ti/cal/cal-video.c
> index 59f0cc4f0d1a..1990cab77344 100644
> --- a/drivers/media/platform/ti/cal/cal-video.c
> +++ b/drivers/media/platform/ti/cal/cal-video.c
> @@ -130,8 +130,6 @@ static int cal_call_active_state_set_fmt(struct v4l2_subdev *source,
>   	int ret;
>   
>   	source_state = v4l2_subdev_lock_and_get_active_state(source);
> -	if (IS_ERR(source_state))
> -		return PTR_ERR(source_state);
>   
>   	ret = v4l2_subdev_call(source, pad, set_fmt, NULL, source_state, fmt);
>   	if (source_state)