Re: question about SoC Camera driver (Micron)

[Darius <augulis.darius@gmail.com>]

Guennadi Liakhovetski wrote:
> On Thu, 15 May 2008, Darius wrote:
> 
>> Guennadi, can you please describe more detailed struct soc_camera_device
>> structure? All these members xmin, ymin, etc...
> 
> The main point is, that the unit is 1 pixel. The rest is pretty much 
> implementation specific. Just see your datasheet and select some natural 
> values for allowed frame sizes and location. As the struct declaration 
> says:
> 
> 	unsigned short width;		/* Current window */
> 	unsigned short height;		/* sizes */
> 	unsigned short x_min;		/* Camera capabilities */
> 	unsigned short y_min;
> 	unsigned short x_current;	/* Current window location */
> 	unsigned short y_current;
> 

where they are used? as I can see, in *_try_fmt_cap() and *__set_fmt_cap() you are using hard coded constants.
in video_probe you are setting this structure, but these values are never used?

> The vales below are again min and max allowed values.
> 
> 	unsigned short width_min;
> 	unsigned short width_max;
> 	unsigned short height_min;
> 	unsigned short height_max;

should they be used in *_try_fmt_cap() function to inform v4l2 driver about sensor posibilities?
now in *_try_fmt_cap() you are using hard coded constants. values from soc_camera_device *icd struct are not used?

btw, can you tell something about frame rate setting? how to implement that? for example, I want from user space adjust frame rate (4, 15, 25, 30fps...).
Should I pass these setting to sensor driver via *_set_fmt_cap()?

Thanks,

Darius.

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list