Re: question about SoC Camera driver (Micron)

[Darius <augulis.darius@gmail.com>]

> Please, tell me exactly where you suspect bugs. soc_camera.c, 
> pxa_camera.c, mt9?0??.c all have *try_fmt_cap().

I see, but try_fmt_cap does not return camera capabilities, it only tries pixel format, without driver state changing.
Maybe it is good idea to implement additional g_fmt_cap ioctl handler in soc_camera? Or instead try_fmt_cap?
Because s_fmt_cap is for fmt setting, g_fmt_cap for getting camera fmt capabilities, and try_fmt_cap is for what? For getting fmt too?
v4l2 documentation recommends not implement this ioctl in the driver.

> 
>> btw, can you tell something about frame rate setting? how to implement that?
>> for example, I want from user space adjust frame rate (4, 15, 25, 30fps...).
>> Should I pass these setting to sensor driver via *_set_fmt_cap()?
> 
> This is not supported.
> 

I think should be not hard to implement vidioc_g_parm and vidioc_s_parm in soc_camera to support frame rate setting?
Now I'm writing driver for OV7670, and I plan to add these features (frame rate setting and g_fmt_cap) to soc_camera driver.
What is your opinion?

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list