[linux-dvb] [PATCH] 2 patches for dvb-apps gnutv

[linux-dvb] [PATCH] 2 patches for dvb-apps gnutv

[Andrea]

Hi,

I would like to repost 2 patches for gnutv, part of dvb-apps.

http://www.linuxtv.org/pipermail/linux-dvb/2008-July/027177.html

They both try to make gnutv more robust when the system/destination file system are temporary slow.

1) http://www.linuxtv.org/pipermail/linux-dvb/2008-July/027176.html
Once the dvb ringbuffer overflows, it is pointless to stop gnutv. I think it should continue and get 
the rest of the signal.
What has been lost has been lost, let's not loose the future stream

2) http://www.linuxtv.org/pipermail/linux-dvb/2008-July/027177.html
Allow to set a bigger (than default = 2MB) dvb ringbuffer to cope with temporary bottlenecks.

Is anybody interested in reviewing them?

Andrea


_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] [PATCH] 2 patches for dvb-apps gnutv

[Christoph Pfister]

Am Mittwoch 16 Juli 2008 22:28:33 schrieb Andrea:
> Hi,
>
> I would like to repost 2 patches for gnutv, part of dvb-apps.
>
> http://www.linuxtv.org/pipermail/linux-dvb/2008-July/027177.html
>
> They both try to make gnutv more robust when the system/destination file
> system are temporary slow.
>
> 1) http://www.linuxtv.org/pipermail/linux-dvb/2008-July/027176.html
> Once the dvb ringbuffer overflows, it is pointless to stop gnutv. I think
> it should continue and get the rest of the signal.
> What has been lost has been lost, let's not loose the future stream
>
> 2) http://www.linuxtv.org/pipermail/linux-dvb/2008-July/027177.html
> Allow to set a bigger (than default = 2MB) dvb ringbuffer to cope with
> temporary bottlenecks.
>
> Is anybody interested in reviewing them?

Guess no.

But I'll rework the first patch a bit (the sequence of revents <--> errno 
check is already bogus) and commit them. And I really suggest you to use an 
application like dvbstream which does its own buffering (at least I hope 
so ;) - because it has never happened to me yet that the ringbuffer 
overflowed (and it shouldn't with sane applications).

> Andrea

Christoph

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] [PATCH] 2 patches for dvb-apps gnutv

[Andrea]

Christoph Pfister wrote:
> Am Mittwoch 16 Juli 2008 22:28:33 schrieb Andrea:
> 
> But I'll rework the first patch a bit (the sequence of revents <--> errno 
> check is already bogus) and commit them. And I really suggest you to use an 
> application like dvbstream which does its own buffering (at least I hope 
> so ;) - because it has never happened to me yet that the ringbuffer 

I've read the code of dvbstream and it does not use an other buffer,
it writes immediately to the output file, the same as gnutv.

> overflowed (and it shouldn't with sane applications).
> 

It can happen to me when the output file is on a NAS via wireless network.
gnutv is very easy to use, lightweight, command line and saves subtitles too.

> 
> Christoph

Cheers

Andrea


_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb