Re: [PATCH 0 of 2] cx88: Enable additional cx2388x features. Version 2

[Frej Drejhammar <frej.drejhammar@gmail.com>]

Trent,

> One of the things you should do it make the control inactive when in
> SECAM mode.  V4L2 has a flag to indicate controls that don't apply
> to the device's current mode.

I guess it is the V4L2_CTRL_FLAG_INACTIVE flag (in the flag field of
struct v4l2_queryctrl) you are referring to, correct?

> CAGC makes a difference for me too.  Some of my channels are over
> saturated and some are under saturated and CAGC fixes them.  I don't
> recall if I posted pictures last time CAGC came up, but it really
> does make a difference.

Good that I'm not the only one who wants/needs it :)

> I haven't ever been able to notice an effect from color killer.
> Maybe if you had poor reception from a B&W source?  Not much black
> and white on broadcast TV these days.

So maybe I should just skip the color killer then...

>> A quick grep shows that the bttv-driver also exposes chroma AGC as
>> a private control. Cx2584x has chroma AGC enabled by default. Maybe
>> the right thing to do is to enable chroma AGC by default for PAL
>> and NTSC?  Chroma AGC is something you'll find on most VCRs and
>> TVs, and then it is on by default.
>
> That's what I would do.  Have a standard control for CAGC and turn
> it on by default.

Then that's what I'll do. Expect a revised version of the patch which
enables CAGC by default for PAL+NTSC and implements the
V4L2_CTRL_FLAG_INACTIVE by the end of the week.

> If I wanted to be told I wasn't worthy to use my hardware, I'd run
> windows!

Hear, hear! :)

Regards,

--Frej

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list