Re: [PATCH 0 of 2] cx88: Enable additional cx2388x features. Version 2

[Frej Drejhammar <frej.drejhammar@gmail.com>]

> Hans Verkuil <hverkuil@xs4all.nl> wrote:
>
>> What I want to prevent is adding controls as a workaround for what
>> might be a driver bug. So in this case I wonder whether chroma AGC
>> shouldn't be enabled in the cx88 driver as it is for cx2584x.
>> 
>> Looking at the cx25840 datasheet it basically says that it should
>> always be enabled except for component input (YPrPb) or SECAM. So I
>> would suggest doing the same in cx88 rather than adding a
>> control. Only if there are cases where Chroma AGC harms the picture
>> quality rather than improves it, then the addition of a control
>> might become important.

The data sheet for cx2388x is not so clear. For ACGC it describes what
it does and then notes that it can be turned off. The default is off.

For the color-killer there is a similar description, and it then notes
that the color-killer can be disabled. The default is disabled.

Mauro Carvalho Chehab <mchehab@infradead.org> writes:
> IMO, the better would be to add both Chroma AGC and Color Killer
> controls as a generic control.

Is there a procedure for adding controls to the V4L2-spec? Is the
docbook source available in a public repository (not just the tarball
at v4l2spec.bytesex.org)?

> The default value for Chroma AGC should be changed to match the
> datasheet recommended way (0 for SECAM, 1 for PAL/NTSC).

I'll revise the patch to do this.

Regards,

--Frej

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list