From: Frej Drejhammar <frej.drejhammar@gmail.com>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: video4linux-list@redhat.com, Trent Piepho <xyzzy@speakeasy.org>
Subject: Re: [PATCH 6 of 6] cx88: Enable color killer by default
Date: Sat, 29 Mar 2008 12:18:07 +0100 [thread overview]
Message-ID: <kr6dtwzgw.fsf@liva.fdsoft.se> (raw)
In-Reply-To: <20080328154302.2dc73781@gaivota> (Mauro Carvalho Chehab's message of "Fri, 28 Mar 2008 15:43:02 -0300")
> Patches 1 to 5 applied, thanks.
Great.
> I don't think it is a good idea to enable the color killer by
> default. This may lead to weird effects, if the stream uses some
> black and white images, with just a few colors, to produce some sort
> of visual effect.
In the scenario you describe the broadcaster will still generate a
color burst (as color information is present) and that is what the
color killer detects. The color killer protects against decoding color
when no color information is present (i.e. no color burst). Most
better quality TV-sets have the functionality and no way to disable
it.
> Better to have this disabled. If someone wants to see a
> black-and-white movie, or is on an area where the color carrier is
> bogus, he can manually enable the filter.
A more probable scenario is that you have a low quality signal source
(a low amplitude color burst) and want to disable the killer to allow
recovery of at least some color. But anyway, the control is there so I
can just enable it in my start-up scripts...
Regards,
--Frej
--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
next prev parent reply other threads:[~2008-03-29 11:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-23 22:43 [PATCH 0 of 6] cx88: Enable additional cx2388x features. Version 3 Frej Drejhammar
2008-03-23 22:43 ` [PATCH 1 of 6] v4l2-api: Define a standard control for chroma AGC Frej Drejhammar
2008-03-24 0:12 ` Laurent Pinchart
2008-03-24 11:56 ` Frej Drejhammar
2008-03-24 19:27 ` Laurent Pinchart
2008-03-23 22:43 ` [PATCH 2 of 6] cx88: Add user " Frej Drejhammar
2008-03-23 22:43 ` [PATCH 3 of 6] cx88: Enable chroma AGC by default for all non-SECAM modes Frej Drejhammar
2008-03-23 22:43 ` [PATCH 4 of 6] v4l2-api: Define a standard control for color killer functionality Frej Drejhammar
2008-04-21 23:30 ` Brandon Philips
2008-03-23 22:43 ` [PATCH 5 of 6] cx88: Add user control for color killer Frej Drejhammar
2008-03-23 22:43 ` [PATCH 6 of 6] cx88: Enable color killer by default Frej Drejhammar
2008-03-28 18:43 ` Mauro Carvalho Chehab
2008-03-29 11:18 ` Frej Drejhammar [this message]
2008-04-21 23:34 ` [PATCH 0 of 6] cx88: Enable additional cx2388x features. Version 3 Brandon Philips
2008-04-22 16:59 ` Frej Drejhammar
2008-04-22 17:33 ` Brandon Philips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=kr6dtwzgw.fsf@liva.fdsoft.se \
--to=frej.drejhammar@gmail.com \
--cc=mchehab@infradead.org \
--cc=video4linux-list@redhat.com \
--cc=xyzzy@speakeasy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox