From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96BE4C43603 for ; Thu, 5 Dec 2019 02:39:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 69ED121744 for ; Thu, 5 Dec 2019 02:39:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="2AEXe14i" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728624AbfLECjJ (ORCPT ); Wed, 4 Dec 2019 21:39:09 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:38066 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728548AbfLECjI (ORCPT ); Wed, 4 Dec 2019 21:39:08 -0500 Received: by mail-pf1-f193.google.com with SMTP id x185so835536pfc.5 for ; Wed, 04 Dec 2019 18:39:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=27jaH0vN7Z1055mM7vLy7qQTaIl7MlRb9ifdmBrbZDM=; b=2AEXe14iZdFWfADVPMho1nGLswqsSNlAEnAUgFieMyEajydA5UtIA2BcOw3cvQHdZO +7SSE0yQn7fq3n4nHsbvSjKepiS29Gm5WR9rq8NTOvdFdi1YqxhsWZNbYk8a14XIStKF hb74QE/F9ENthSZE3yzn0ZQDkHdLNmssNPXh/EW0qy0yWmB7IFhwbQ7Hy2WVvJXW05oI H1C0sUhnHCdN0aF6ajXMtxjjgQBm0bYucIo02eLqXp6IojHQsBo24gGBGz9ZhVJZDdLp 4LhMKEeYfNiw1x190FxFAVW9rFhpjJNh7tIG1Cx/l25+RJ0xiWa5+IVfaItxv51z2fvq fu0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=27jaH0vN7Z1055mM7vLy7qQTaIl7MlRb9ifdmBrbZDM=; b=Q8pMVpYweg8K2Y/ppftsSj7YdaLko9S9+BtoQ4Zve+Uq/HMOWTzFy/9C0Xd6s46O9J RGuwNfx1wldLnnjl10eM8N2XJ14Pp1M2cuy3JNnw/q6oQRhZRFlaTanHfmCdHzF63E4W 8/A2huSRb17mL9cZ0e6l8wMh0rRRzBHsRANxNwcsCMCieRhP6sezQnzW3dYqIWk3p4xX Y1yCLRy6NEVNe80P21kubg/LdVzJC+4qHGtxL+Hz9UL83fXLGkGLWBHnNcDzkn2eHF07 tMqrJXSQ5scP0zsRzc2vQWvW5f13rYY24CKQwnqWnL+LF3pateVW1kzF9rgCCLs+DDSr lclA== X-Gm-Message-State: APjAAAWZfwc31pd0vLPWOWlqp58m4hkCzLKofwAzA3QYzaEPPZqcvQqg HtlwQF3Oyeb43S0f658NL0dd4Q== X-Google-Smtp-Source: APXvYqyArhAsoFW/09BUx58Mqa57A85qEfp9wqhmY84drnrMDAvAJYGziHESSDaQZke2fKs6Z2jx+w== X-Received: by 2002:a62:6884:: with SMTP id d126mr6446169pfc.109.1575513548166; Wed, 04 Dec 2019 18:39:08 -0800 (PST) Received: from localhost ([2601:602:9200:a1a5:18db:9496:e12f:2012]) by smtp.gmail.com with ESMTPSA id k21sm8765676pgt.22.2019.12.04.18.39.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Dec 2019 18:39:07 -0800 (PST) From: Kevin Hilman To: Colin King , Maxime Jourdan , Mauro Carvalho Chehab , Greg Kroah-Hartman , Hans Verkuil , linux-media@vger.kernel.org, linux-amlogic@lists.infradead.org, devel@driverdev.osuosl.org, linux-arm-kernel@lists.infradead.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: meson: add missing allocation failure check on new_buf In-Reply-To: <20191204141159.1432387-1-colin.king@canonical.com> References: <20191204141159.1432387-1-colin.king@canonical.com> Date: Wed, 04 Dec 2019 18:39:06 -0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Colin King writes: > From: Colin Ian King > > Currently if the allocation of new_buf fails then a null pointer > dereference occurs when assiging new_buf->vb. Avoid this by returning > early on a memory allocation failure as there is not much more can > be done at this point. > > Addresses-Coverity: ("Dereference null return") > Fixes: 3e7f51bd9607 ("media: meson: add v4l2 m2m video decoder driver") > Signed-off-by: Colin Ian King Reviewed-by: Kevin Hilman