From: khalasa@piap.pl (Krzysztof Hałasa)
To: Steve Longerbeam <steve_longerbeam@mentor.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
Steve Longerbeam <slongerbeam@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hans Verkuil <hverkuil@xs4all.nl>, <linux-media@vger.kernel.org>
Subject: Re: [PATCH v2 04/10] media: imx: interweave only for sequential input/interlaced output fields
Date: Wed, 06 Jun 2018 08:26:08 +0200 [thread overview]
Message-ID: <m37encmnwf.fsf@t19.piap.pl> (raw)
In-Reply-To: <c9fcc11a-9f0f-0764-cb8e-66fc9c09d7f4@mentor.com> (Steve Longerbeam's message of "Mon, 4 Jun 2018 17:56:44 -0700")
Steve Longerbeam <steve_longerbeam@mentor.com> writes:
> Yes, I had already implemented this idea yesterday, I've added it
> to branch fix-csi-interlaced.3. The CSI will swap field capture
> (field 1 first, then field 2, by inverting F bit in CCIR registers) if
> the field order input to the CSI is different from the requested
> output field order.
It seems the fix-csi-interlaced.2 was a bit better.
Now I do:
media-ctl -V "'adv7180 2-0020':0 [fmt:UYVY2X8/720x576 field:alternate]"
media-ctl -V "'ipu2_csi1_mux':2 [fmt:UYVY2X8/720x576]"
media-ctl -V "'ipu2_csi1':2 [fmt:AYUV32/720x576 field:interlaced]"
and get:
"adv7180 2-0020":0 [fmt:UYVY2X8/720x576 field:alternate]
"ipu2_csi1_mux":1 [fmt:UYVY2X8/720x576 field:alternate]
"ipu2_csi1_mux":2 [fmt:UYVY2X8/720x576 field:alternate]
"ipu2_csi1":0 [fmt:UYVY2X8/720x576 field:alternate]
"ipu2_csi1":2 [fmt:AYUV32/720x576 field:seq-tb]
Needless to say, the output isn't an interlaced frame.
--
Krzysztof Halasa
Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland
next prev parent reply other threads:[~2018-06-06 6:26 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 0:30 [PATCH v2 00/10] imx-media: Fixes for interlaced capture Steve Longerbeam
2018-06-01 0:30 ` [PATCH v2 01/10] media: imx-csi: Pass sink pad field to ipu_csi_init_interface Steve Longerbeam
2018-06-01 13:22 ` Philipp Zabel
2018-06-02 16:30 ` Steve Longerbeam
2018-06-04 5:25 ` Krzysztof Hałasa
2018-06-04 8:32 ` Philipp Zabel
2018-06-04 16:47 ` Steve Longerbeam
2018-06-05 4:54 ` Krzysztof Hałasa
2018-06-01 0:30 ` [PATCH v2 02/10] gpu: ipu-csi: Check for field type alternate Steve Longerbeam
2018-06-01 13:26 ` Philipp Zabel
2018-06-01 0:30 ` [PATCH v2 03/10] media: videodev2.h: Add macros V4L2_FIELD_IS_{INTERLACED|SEQUENTIAL} Steve Longerbeam
2018-06-01 0:30 ` [PATCH v2 04/10] media: imx: interweave only for sequential input/interlaced output fields Steve Longerbeam
2018-06-01 13:33 ` Philipp Zabel
2018-06-02 16:32 ` Steve Longerbeam
2018-06-04 5:35 ` Krzysztof Hałasa
2018-06-04 8:27 ` Philipp Zabel
2018-06-05 0:56 ` Steve Longerbeam
2018-06-05 8:07 ` Philipp Zabel
2018-06-05 10:43 ` Krzysztof Hałasa
2018-06-05 19:00 ` Steve Longerbeam
2018-06-06 5:48 ` Krzysztof Hałasa
2018-06-06 9:05 ` Philipp Zabel
2018-06-07 3:37 ` Steve Longerbeam
2018-06-07 7:43 ` Krzysztof Hałasa
2018-06-06 6:26 ` Krzysztof Hałasa [this message]
2018-06-01 0:30 ` [PATCH v2 05/10] media: imx: interweave and odd-chroma-row skip are incompatible Steve Longerbeam
2018-06-01 0:30 ` [PATCH v2 06/10] media: imx: Fix field setting logic in try_fmt Steve Longerbeam
2018-06-01 13:34 ` Philipp Zabel
2018-06-02 16:32 ` Steve Longerbeam
2018-06-01 0:30 ` [PATCH v2 07/10] media: imx-csi: Allow skipping odd chroma rows for YVU420 Steve Longerbeam
2018-06-01 13:35 ` Philipp Zabel
2018-06-01 0:30 ` [PATCH v2 08/10] media: imx: vdic: rely on VDIC for correct field order Steve Longerbeam
2018-06-01 0:30 ` [PATCH v2 09/10] media: imx-csi: Move crop/compose reset after filling default mbus fields Steve Longerbeam
2018-06-01 0:30 ` [PATCH v2 10/10] media: imx.rst: Update doc to reflect fixes to interlaced capture Steve Longerbeam
2018-06-01 13:44 ` Philipp Zabel
2018-06-02 17:58 ` Steve Longerbeam
2018-06-02 18:44 ` Steve Longerbeam
2018-06-04 5:52 ` Krzysztof Hałasa
2018-06-04 8:34 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m37encmnwf.fsf@t19.piap.pl \
--to=khalasa@piap.pl \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=slongerbeam@gmail.com \
--cc=steve_longerbeam@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox