From: khalasa@piap.pl (Krzysztof Hałasa)
To: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
linux-media <linux-media@vger.kernel.org>
Subject: Re: [PATCH] media: Support Intersil/Techwell TW686x-based video capture cards
Date: Thu, 28 Jan 2016 08:25:55 +0100 [thread overview]
Message-ID: <m3a8nqf9mk.fsf@t19.piap.pl> (raw)
In-Reply-To: <CAAEAJfDb84ZbRkq9GVOmeWp=vpn_GBX9Fx0w+aGnZ9n29PsR8A@mail.gmail.com> (Ezequiel Garcia's message of "Wed, 27 Jan 2016 09:14:49 -0300")
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> writes:
> Since your driver is not merged, there's no real benefit in my sending
> me patches against it.
And it's not merged because you stated that you have produced
a rewritten driver, using my driver just as a reference, and I was naive
enough to believe it and let it go.
> Since I just submitted a v2 driver that seems to be ready to be
> merged, how about I just add DMA s-g support so you get all the
> functionality you need?
>
> This option sounds much easier than you going through all the pain of
> cleaning up your driver.
Do I really have to answer such questions?
One can't simply take someone's code, replace the MODULE_AUTHOR,
twist a bit to suit his needs, and send it as his own.
In my country, it wouldn't be even legal.
I have at least one similar situation here. I'm using frame grabber
drivers for an I.MX6 processor on-chip feature. The problem is, the
author hasn't yet managed (for years now) to have this functionality
merged into the official tree. Obviously, I'm putting some considerable
work in it. Does this mean I'm free to grab it as my own and request
that it is to be merged instead? No, I have to wait until the original
work is merged, and only then I can ask for my patches to be applied
(in the form of changes, not a raw driver code).
--
Krzysztof Halasa
Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland
next prev parent reply other threads:[~2016-01-28 7:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-27 2:26 [PATCH] media: Support Intersil/Techwell TW686x-based video capture cards Ezequiel Garcia
2016-01-18 13:02 ` Hans Verkuil
2016-01-18 15:20 ` Ezequiel Garcia
2016-01-18 15:28 ` Hans Verkuil
2016-01-18 15:31 ` Ezequiel Garcia
2016-01-25 9:40 ` Krzysztof Hałasa
2016-01-25 12:03 ` Ezequiel Garcia
2016-01-26 11:16 ` Krzysztof Hałasa
2016-01-26 12:35 ` Ezequiel Garcia
2016-01-26 15:00 ` Krzysztof Hałasa
2016-01-27 12:14 ` Ezequiel Garcia
2016-01-28 7:25 ` Krzysztof Hałasa [this message]
2016-01-28 7:43 ` Hans Verkuil
2016-01-28 8:51 ` Krzysztof Hałasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3a8nqf9mk.fsf@t19.piap.pl \
--to=khalasa@piap.pl \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox